Gabriel Krisman Bertazi
5686dee34d
dm multipath: use updated MPATHF_QUEUE_IO on mapping for bio-based mpath ...
When adding devices that don't have a scsi_dh on a BIO based multipath,
I was able to consistently hit the warning below and lock-up the system.
The problem is that __map_bio reads the flag before it potentially being
modified by choose_pgpath, and ends up using the older value.
The WARN_ON below is not trivially linked to the issue. It goes like
this: The activate_path delayed_work is not initialized for non-scsi_dh
devices, but we always set MPATHF_QUEUE_IO, asking for initialization.
That is fine, since MPATHF_QUEUE_IO would be cleared in choose_pgpath.
Nevertheless, only for BIO-based mpath, we cache the flag before calling
choose_pgpath, and use the older version when deciding if we should
initialize the path. Therefore, we end up trying to initialize the
paths, and calling the non-initialized activate_path work.
[ 82.437100] ------------[ cut here ]------------
[ 82.437659] WARNING: CPU: 3 PID: 602 at kernel/workqueue.c:1624
__queue_delayed_work+0x71/0x90
[ 82.438436] Modules linked in:
[ 82.438911] CPU: 3 PID: 602 Comm: systemd-udevd Not tainted 5.6.0-rc6+ #339
[ 82.439680] RIP: 0010:__queue_delayed_work+0x71/0x90
[ 82.440287] Code: c1 48 89 4a 50 81 ff 00 02 00 00 75 2a 4c 89 cf e9
94 d6 07 00 e9 7f e9 ff ff 0f 0b eb c7 0f 0b 48 81 7a 58 40 74 a8 94 74
a7 <0f> 0b 48 83 7a 48 00 74 a5 0f 0b eb a1 89 fe 4c 89 cf e9 c8 c4 07
[ 82.441719] RSP: 0018:ffffb738803977c0 EFLAGS: 00010007
[ 82.442121] RAX: ffffa086389f9740 RBX: 0000000000000002 RCX: 0000000000000000
[ 82.442718] RDX: ffffa086350dd930 RSI: ffffa0863d76f600 RDI: 0000000000000200
[ 82.443484] RBP: 0000000000000200 R08: 0000000000000000 R09: ffffa086350dd970
[ 82.444128] R10: 0000000000000000 R11: 0000000000000000 R12: ffffa086350dd930
[ 82.444773] R13: ffffa0863d76f600 R14: 0000000000000000 R15: ffffa08636738008
[ 82.445427] FS: 00007f6abfe9dd40(0000) GS:ffffa0863dd80000(0000) knlGS:00000
[ 82.446040] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 82.446478] CR2: 0000557d288db4e8 CR3: 0000000078b36000 CR4: 00000000000006e0
[ 82.447104] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 82.447561] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 82.448012] Call Trace:
[ 82.448164] queue_delayed_work_on+0x6d/0x80
[ 82.448472] __pg_init_all_paths+0x7b/0xf0
[ 82.448714] pg_init_all_paths+0x26/0x40
[ 82.448980] __multipath_map_bio.isra.0+0x84/0x210
[ 82.449267] __map_bio+0x3c/0x1f0
[ 82.449468] __split_and_process_non_flush+0x14a/0x1b0
[ 82.449775] __split_and_process_bio+0xde/0x340
[ 82.450045] ? dm_get_live_table+0x5/0xb0
[ 82.450278] dm_process_bio+0x98/0x290
[ 82.450518] dm_make_request+0x54/0x120
[ 82.450778] generic_make_request+0xd2/0x3e0
[ 82.451038] ? submit_bio+0x3c/0x150
[ 82.451278] submit_bio+0x3c/0x150
[ 82.451492] mpage_readpages+0x129/0x160
[ 82.451756] ? bdev_evict_inode+0x1d0/0x1d0
[ 82.452033] read_pages+0x72/0x170
[ 82.452260] __do_page_cache_readahead+0x1ba/0x1d0
[ 82.452624] force_page_cache_readahead+0x96/0x110
[ 82.452903] generic_file_read_iter+0x84f/0xae0
[ 82.453192] ? __seccomp_filter+0x7c/0x670
[ 82.453547] new_sync_read+0x10e/0x190
[ 82.453883] vfs_read+0x9d/0x150
[ 82.454172] ksys_read+0x65/0xe0
[ 82.454466] do_syscall_64+0x4e/0x210
[ 82.454828] entry_SYSCALL_64_after_hwframe+0x49/0xbe
[...]
[ 82.462501] ---[ end trace bb39975e9cf45daa ]---
Cc: stable@vger.kernel.org
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
2020-04-28 19:51:46 -04:00
2020-03-02 20:01:32 -07:00
2020-01-14 20:15:53 -05:00
2019-11-05 14:53:03 -05:00
2020-01-07 12:07:08 -05:00
2020-03-03 10:02:46 -05:00
2019-09-13 17:00:21 -04:00
2018-04-30 15:40:40 -04:00
2019-04-18 16:18:25 -04:00
2018-10-16 14:34:59 -04:00
2020-03-03 11:10:21 -05:00
2020-03-27 14:42:51 -04:00
2020-03-27 14:42:51 -04:00
2020-03-27 14:42:51 -04:00
2019-04-04 15:33:59 -04:00
2020-03-24 11:17:33 -04:00
2019-04-26 11:29:32 -04:00
2020-01-07 11:43:36 -05:00
2019-05-21 10:50:45 +02:00
2019-05-16 15:55:48 -07:00
2019-11-12 19:12:07 -07:00
2019-07-15 11:03:01 -03:00
2020-04-03 13:07:41 -04:00
2018-06-05 08:47:43 -06:00
2019-09-16 10:18:01 -04:00
2019-08-15 15:57:39 -04:00
2019-11-12 19:12:07 -07:00
2018-05-30 15:33:32 -06:00
2019-07-09 14:13:33 -04:00
2020-04-28 19:51:46 -04:00
2018-01-29 13:44:58 -05:00
2019-08-26 11:05:32 -04:00
2020-01-07 11:43:37 -05:00
2018-06-12 18:28:00 -07:00
2019-09-05 19:52:34 -06:00
2019-03-05 14:48:50 -05:00
2018-01-29 13:44:58 -05:00
2020-01-15 21:43:09 -07:00
2020-01-07 12:07:17 -05:00
2019-09-04 09:39:22 -04:00
2019-11-05 14:09:59 -05:00
2019-03-05 14:48:51 -05:00
2018-10-11 11:36:09 -04:00
2019-12-03 08:51:25 -07:00
2019-04-25 15:38:52 -04:00
2020-02-27 12:00:53 -05:00
2019-12-05 17:05:24 -05:00
2020-01-14 20:23:13 -05:00
2019-05-30 11:26:35 -07:00
2019-05-30 11:26:35 -07:00
2018-12-18 09:02:26 -05:00
2020-04-16 16:16:38 -04:00
2019-05-30 11:26:32 -07:00
2020-03-03 11:10:21 -05:00
2019-08-23 10:13:14 -04:00
2019-08-23 10:13:14 -04:00
2019-08-23 10:13:14 -04:00
2020-04-16 16:04:13 -04:00
2020-03-24 12:21:48 -04:00
2019-11-07 10:08:36 -05:00
2020-03-03 11:10:21 -05:00
2019-11-07 10:08:36 -05:00
2020-04-03 11:32:19 -04:00
2019-08-23 10:13:12 -04:00
2019-11-20 10:35:31 -05:00
2019-09-12 09:32:31 -04:00
2020-02-08 13:04:49 -08:00
2018-08-01 15:49:39 -07:00
2019-05-24 17:27:12 +02:00
2018-10-18 09:36:35 -07:00
2019-05-24 17:27:13 +02:00
2019-10-24 15:22:40 -07:00
2019-10-24 15:22:40 -07:00
2018-05-30 15:33:32 -06:00
2020-02-04 03:05:26 +00:00
2020-01-13 11:44:10 -08:00
2020-01-15 21:43:09 -07:00
2019-09-13 13:10:05 -07:00
2019-06-15 01:37:35 -06:00
2020-01-13 11:44:10 -08:00
2018-05-30 15:33:32 -06:00
2019-06-05 17:36:37 +02:00
2019-03-12 10:15:18 -07:00
2019-12-09 10:36:44 -08:00
2020-01-13 11:44:09 -08:00
2019-09-13 13:14:43 -07:00
2019-11-11 16:47:39 -08:00
2018-05-30 15:33:32 -06:00
5686dee34d