Xiaoming Ni 5788ccf3c8 mtd: clear cache_state to avoid writing to bad blocks repeatedly
The function call process is as follows:
	mtd_blktrans_work()
	  while (1)
	    do_blktrans_request()
	      mtdblock_writesect()
	        do_cached_write()
	          write_cached_data() /*if cache_state is STATE_DIRTY*/
	            erase_write()

write_cached_data() returns failure without modifying cache_state
and cache_offset. So when do_cached_write() is called again,
write_cached_data() will be called again to perform erase_write()
on the same cache_offset.

But if this cache_offset points to a bad block, erase_write() will
always return -EIO. Writing to this mtdblk is equivalent to losing
the current data, and repeatedly writing to the bad block.

Repeatedly writing a bad block has no real benefits,
but brings some negative effects:
1 Lost subsequent data
2 Loss of flash device life
3 erase_write() bad blocks are very time-consuming. For example:
	the function do_erase_oneblock() in chips/cfi_cmdset_0020.c or
	chips/cfi_cmdset_0002.c may take more than 20 seconds to return

Therefore, when erase_write() returns -EIO in write_cached_data(),
clear cache_state to avoid writing to bad blocks repeatedly.

Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
2020-06-05 10:16:14 +02:00
..
2020-03-23 07:59:38 +01:00
2020-05-22 11:10:42 -07:00
2020-04-10 11:32:22 +02:00
2020-05-22 20:06:25 +02:00
2020-05-29 12:32:46 -07:00
2020-04-27 13:28:27 -07:00
2020-04-04 18:07:59 -07:00
2020-04-16 13:52:31 -07:00
2020-03-30 11:43:51 -07:00
2020-03-19 23:04:32 -05:00
2020-04-03 15:05:35 -07:00
2020-04-03 14:25:02 -07:00
2020-04-08 21:03:40 -07:00
2020-03-31 10:05:01 -07:00
2020-04-23 09:28:15 -07:00
2020-04-17 06:05:29 -04:00
2020-04-07 19:48:52 -07:00
2020-04-02 15:50:04 -07:00
2020-04-03 15:05:35 -07:00
2020-05-21 12:59:29 -07:00
2020-04-07 20:24:34 -07:00
2020-03-19 07:41:03 +01:00
2020-04-17 10:35:17 -07:00
2020-04-03 13:12:26 -07:00
2020-04-08 10:51:53 -07:00
2020-04-08 10:51:53 -07:00