linux

iv/linux

History

Paul Bolle 57d88cffc8 IB/mlx4: Fix compiler warning about uninitialized 'vlan' variable

Building qp.o triggers this gcc warning:

    drivers/infiniband/hw/mlx4/qp.c: In function ‘mlx4_ib_post_send’:
    drivers/infiniband/hw/mlx4/qp.c:1862:62: warning: ‘vlan’ may be used uninitialized in this function [-Wmaybe-uninitialized]
    drivers/infiniband/hw/mlx4/qp.c:1752:6: note: ‘vlan’ was declared here

Looking at the code it is clear 'vlan' is only set and used if 'is_eth'
is non-zero. But by initializing 'vlan' to 0xffff, on

    gcc (Ubuntu 4.7.2-22ubuntu1) 4.7.2

on x86-64 at least, we fix the warning, and the compiler was already
setting 'vlan' to 0 in the generated code, so there's no real downside.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>

[ Get rid of unnecessary move of 'is_vlan' initialization.  - Roland ]

Signed-off-by: Roland Dreier <roland@purestorage.com>

2013-02-25 09:17:13 -08:00

ah.c

IB/mlx4: Fix SL to 802.1Q priority-bits mapping for IBoE

2012-01-03 21:00:02 -08:00

alias_GUID.c

IB/mlx4: Fix build error on platforms where UL is not 64 bits

2012-10-18 10:29:01 -07:00

cm.c

IB/mlx4: Fix spinlock order to avoid lockdep warnings

2012-11-29 12:14:45 -08:00

cq.c

mlx4: 64-byte CQE/EQE support