iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Pedro Tammela 338469d677 net/sched: clear actions pointer in miss cookie init fail 
Palash reports a UAF when using a modified version of syzkaller[1].

When 'tcf_exts_miss_cookie_base_alloc()' fails in 'tcf_exts_init_ex()'
a call to 'tcf_exts_destroy()' is made to free up the tcf_exts
resources.
In flower, a call to '__fl_put()' when 'tcf_exts_init_ex()' fails is made;
Then calling 'tcf_exts_destroy()', which triggers an UAF since the
already freed tcf_exts action pointer is lingering in the struct.

Before the offending patch, this was not an issue since there was no
case where the tcf_exts action pointer could linger. Therefore, restore
the old semantic by clearing the action pointer in case of a failure to
initialize the miss_cookie.

[1] https://github.com/cmu-pasta/linux-kernel-enriched-corpus

v1->v2: Fix compilation on configs without tc actions (kernel test robot)

Fixes: 80cd22c35c90 ("net/sched: cls_api: Support hardware miss to tc action")
Reported-by: Palash Oswal <oswalpalash@gmail.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-04-17 10:06:23 +01:00
..
act_api.c
net/sched: act_api: add specific EXT_WARN_MSG for tc action
2023-03-16 21:25:45 -07:00
act_bpf.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_connmark.c
net/sched: act_connmark: handle errno on tcf_idr_check_alloc
2023-03-01 08:19:09 +00:00
act_csum.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_ct.c
net: extract nf_ct_handle_fragments to nf_conntrack_ovs
2023-02-10 16:23:03 -08:00
act_ctinfo.c
net/sched: act_ctinfo: use percpu stats
2023-02-13 20:09:01 -08:00
act_gact.c
Networking changes for 6.2.
2022-12-13 15:47:48 -08:00
act_gate.c
net/sched: act_gate: use percpu stats
2023-02-16 10:39:28 +01:00
act_ife.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_ipt.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_meta_mark.c
…
act_meta_skbprio.c
…
act_meta_skbtcindex.c
…
act_mirred.c
act_mirred: use the backlog for nested calls to mirred ingress
2023-01-24 10:30:54 +01:00
act_mpls.c
net/sched: act_mpls: fix action bind logic
2023-02-26 18:27:45 +00:00
act_nat.c
net/sched: act_nat: transition to percpu stats and rcu
2023-02-16 10:39:28 +01:00
act_pedit.c
net/sched: act_pedit: fix action bind logic
2023-02-26 18:27:45 +00:00
act_police.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_sample.c
net/sched: act_sample: fix action bind logic
2023-02-26 18:27:45 +00:00
act_simple.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbedit.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_skbmod.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_tunnel_key.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
act_vlan.c
net/sched: avoid indirect act functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_api.c
net/sched: clear actions pointer in miss cookie init fail
2023-04-17 10:06:23 +01:00
cls_basic.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_bpf.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_cgroup.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_flow.c
treewide: Convert del_timer*() to timer_shutdown*()
2022-12-25 13:38:09 -08:00
cls_flower.c
net/sched: flower: fix fl_change() error recovery path
2023-03-01 08:49:54 +00:00
cls_fw.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_matchall.c
net/sched: support per action hw stats
2023-02-14 11:00:01 +01:00
cls_route.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
cls_u32.c
net/sched: avoid indirect classify functions on retpoline kernels
2022-12-09 09:18:07 +00:00
em_canid.c
…
em_cmp.c
…
em_ipset.c
…
em_ipt.c
…
em_meta.c
net_sched: em_meta: add READ_ONCE() in var_sk_bound_if()
2022-05-16 10:31:06 +01:00
em_nbyte.c
net: sched: Return the correct errno code
2021-02-06 11:15:28 -08:00
em_text.c
…
em_u32.c
…
ematch.c
net_sched: reject TCF_EM_SIMPLE case for complex ematch module
2022-12-19 09:43:18 +00:00
Kconfig
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
Makefile
net/sched: Retire rsvp classifier
2023-02-16 09:27:07 +01:00
sch_api.c
net/sched: fix error recovery in qdisc_create()
2023-02-13 09:51:59 +00:00
sch_blackhole.c
…
sch_cake.c
net: sched: use skb_ip_totlen and iph_totlen
2023-02-01 20:54:27 -08:00
sch_cbs.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_choke.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
sch_codel.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_drr.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_etf.c
net: sched: etf: remove true check in etf_enable_offload()
2022-09-01 20:08:32 -07:00
sch_ets.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_fifo.c
net_sched: fix NULL deref in fifo_set_limit()
2021-10-01 14:59:10 -07:00
sch_fq_codel.c
Revert "net: sched: fq_codel: remove redundant resource cleanup in fq_codel_init()"
2022-10-19 13:47:09 +01:00
sch_fq_pie.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_fq.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_frag.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2021-12-31 14:35:40 +00:00
sch_generic.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-09-01 12:58:02 -07:00
sch_gred.c
net: sched: gred: prevent races when adding offloads to stats
2023-01-18 20:28:25 -08:00
sch_hfsc.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_hhf.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_htb.c
net: sched: sch: Fix off by one in htb_activate_prios()
2023-02-07 23:38:53 -08:00
sch_ingress.c
…
sch_mq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_mqprio_lib.c
net/sched: refactor mqprio qopt reconstruction to a library function
2023-02-06 10:06:44 +00:00
sch_mqprio_lib.h
net/sched: refactor mqprio qopt reconstruction to a library function
2023-02-06 10:06:44 +00:00
sch_mqprio.c
net/sched: refactor mqprio qopt reconstruction to a library function
2023-02-06 10:06:44 +00:00
sch_multiq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_netem.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
sch_pie.c
treewide: use get_random_bytes() when possible
2022-10-11 17:42:58 -06:00
sch_plug.c
net: sched: remove redundant NULL check in change hook function
2022-09-01 08:06:45 +02:00
sch_prio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_qfq.c
net: sched: sch_qfq: prevent slab-out-of-bounds in qfq_activate_agg
2023-04-14 10:59:26 +01:00
sch_red.c
net: sched: Fix use after free in red_enqueue()
2022-10-31 11:55:39 +00:00
sch_sfb.c
Networking fixes for 6.1-rc2, including fixes from netfilter
2022-10-20 17:24:59 -07:00
sch_sfq.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_skbprio.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_taprio.c
net/sched: taprio: dynamic max_sdu larger than the max_mtu is unlimited
2023-02-20 08:46:57 +01:00
sch_tbf.c
net/sched: use tc_qdisc_stats_dump() in qdisc
2022-09-22 17:34:10 -07:00
sch_teql.c
net: sched: delete duplicate cleanup of backlog and qlen
2022-08-25 15:10:17 +02:00