Anant Thazhemadam 9a9e774959 net: team: fix memory leak in __team_options_register
The variable "i" isn't initialized back correctly after the first loop
under the label inst_rollback gets executed.

The value of "i" is assigned to be option_count - 1, and the ensuing
loop (under alloc_rollback) begins by initializing i--.
Thus, the value of i when the loop begins execution will now become
i = option_count - 2.

Thus, when kfree(dst_opts[i]) is called in the second loop in this
order, (i.e., inst_rollback followed by alloc_rollback),
dst_optsp[option_count - 2] is the first element freed, and
dst_opts[option_count - 1] does not get freed, and thus, a memory
leak is caused.

This memory leak can be fixed, by assigning i = option_count (instead of
option_count - 1).

Fixes: 80f7c6683fe0 ("team: add support for per-port options")
Reported-by: syzbot+69b804437cfec30deac3@syzkaller.appspotmail.com
Tested-by: syzbot+69b804437cfec30deac3@syzkaller.appspotmail.com
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-10-04 14:47:22 -07:00
..
2020-09-04 13:19:19 -07:00
2020-09-13 09:02:59 -07:00
2020-08-02 18:26:51 +03:00
2020-09-18 11:48:25 -07:00
2020-09-04 12:12:39 -07:00
2020-09-20 15:18:11 -07:00
2020-07-27 11:49:37 +02:00
2020-09-18 08:52:06 +10:00
2020-09-15 16:20:43 -07:00
2020-08-29 12:37:00 -07:00
2020-08-05 19:24:27 -07:00
2020-09-03 08:22:16 -07:00
2020-08-28 10:15:33 -07:00
2020-09-13 08:52:21 -07:00
2020-09-04 12:41:55 +02:00
2020-08-14 16:00:09 -07:00
2020-09-11 11:25:55 -07:00
2020-09-11 11:35:55 -07:00
2020-09-08 11:42:58 -07:00
2020-09-15 13:52:14 +02:00
2020-09-20 10:46:26 -07:00
2020-09-06 09:59:27 -07:00