Marek Szyprowski 588fb54b0c clk: Manage proper runtime PM state in clk_change_rate() ...

clk_change_rate() propagates rate change down to all its children. Such
operation requires managing proper runtime PM state of each child, what
was missing. Add needed calls to clk_pm_runtime*() to ensure that
set_rate() clock callback is called on runtime active clock.

This fixes following issue found on Exynos5433 TM2 board with devfreq
enabled:

Synchronous External Abort: synchronous external abort (0x96000210) at 0xffffff80093f5600
Internal error: : 96000210 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 5 Comm: kworker/u16:0 Not tainted 4.15.0-rc1-next-20171129+ #4
Hardware name: Samsung TM2 board (DT)
Workqueue: devfreq_wq devfreq_monitor
task: ffffffc0ca96b600 task.stack: ffffff80093a8000
pstate: a0000085 (NzCv daIf -PAN -UAO)
pc : clk_divider_set_rate+0x54/0x118
lr : clk_divider_set_rate+0x44/0x118
...
Process kworker/u16:0 (pid: 5, stack limit = 0xffffff80093a8000)
Call trace:
 clk_divider_set_rate+0x54/0x118
 clk_change_rate+0xfc/0x4e0
 clk_change_rate+0x1f0/0x4e0
 clk_change_rate+0x1f0/0x4e0
 clk_change_rate+0x1f0/0x4e0
 clk_core_set_rate_nolock+0x138/0x148
 clk_set_rate+0x28/0x50
 exynos_bus_passive_target+0x6c/0x11c
 update_devfreq_passive+0x58/0xb4
 devfreq_passive_notifier_call+0x50/0x5c
 notifier_call_chain+0x4c/0x88
 __srcu_notifier_call_chain+0x54/0x80
 srcu_notifier_call_chain+0x14/0x1c
 update_devfreq+0x100/0x1b4
 devfreq_monitor+0x2c/0x88
 process_one_work+0x148/0x3d8
 worker_thread+0x13c/0x3f8
 kthread+0x100/0x12c
 ret_from_fork+0x10/0x18

Reported-by: Chanwoo Choi <cw00.choi@samsung.com>
Fixes: 9a34b45397e5 ("clk: Add support for runtime PM")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Chanwoo Choi <cw00.choi@samsung.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

2017-12-05 15:20:03 -08:00

..

at91

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

axis

clk: axis: Use new macro CLK_OF_DECLARE_DRIVER

2016-08-12 18:00:37 -07:00

axs10x

clk: axs10x: introduce AXS10X pll driver

2017-07-17 11:50:59 -07:00

bcm

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

berlin

clk: Convert to using %pOF instead of full_name

2017-07-21 15:49:54 -07:00

h8300

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

hisilicon

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

imgtec

Update MIPS email addresses

2017-11-03 09:02:30 -07:00

imx

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

ingenic

Update MIPS email addresses

2017-11-03 09:02:30 -07:00

keystone

clk: keystone: sci-clk: Fix sci_clk_get

2017-08-02 18:37:26 -07:00

loongson1

CLK: Add Loongson1C clock support

2016-09-23 14:49:21 -07:00

mediatek

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

meson

clk: meson: gxbb: Add VPU and VAPB clocks data

2017-10-20 10:34:49 +02:00

microchip

clk: microchip: Initialize SOSC clock rate for PIC32MZDA.

2016-08-24 16:05:24 -07:00

mmp

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

mvebu

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

mxs

clk: mxs: make clk_ops const

2017-11-01 23:25:43 -07:00

nxp

clk: nxp: clk-lpc32xx: rename clk_gate_is_enabled()

2017-08-31 18:35:44 -07:00

pistachio

clk: pistachio: correct critical clock list

2015-08-26 11:34:43 -07:00

pxa

clk: pxa: fix building on older compilers

2017-11-14 15:55:53 -08:00

qcom

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

renesas

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

rockchip

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

samsung

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

sirf

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

socfpga

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

spear

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

st

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

sunxi

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

sunxi-ng

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

tegra

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

ti

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

uniphier

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

ux500

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

versatile

We have two changes to the core framework this time around. The first being a

2017-11-17 20:04:24 -08:00

x86

clk: x86: Do not gate clocks enabled by the firmware

2017-07-18 16:23:13 -07:00

zte

clk: zte: constify clk_div_table

2017-08-30 22:30:30 -07:00

zynq

clk: zynq: Remove CLK_IS_ROOT

2016-03-02 17:48:26 -08:00

clk-asm9260.c

clk: Convert to using %pOF instead of full_name

2017-07-21 15:49:54 -07:00

clk-axi-clkgen.c

clk: axi-clkgen: Migrate to clk_hw based OF and registration APIs

2016-08-24 16:10:31 -07:00

clk-axm5516.c

clk: axm5516: Migrate to clk_hw based OF and registration APIs

2016-08-24 16:11:07 -07:00

clk-bulk.c

clk: Export clk_bulk_prepare()

2017-09-29 14:17:17 -07:00

clk-cdce706.c

clk: cdce: Migrate to clk_hw based OF and registration APIs

2016-08-24 16:12:38 -07:00

clk-cdce925.c

clk: cdce925: remove redundant check for non-null parent_name

2017-11-13 17:44:15 -08:00

clk-clps711x.c

clk: clps711x: Migrate to clk_hw based OF and registration APIs

2016-08-24 17:19:26 -07:00

clk-composite.c

Merge branch 'clk-hw-register' (early part) into clk-next

2016-04-21 14:47:18 -07:00

clk-conf.c

clk: Convert to using %pOF instead of full_name

2017-07-21 15:49:54 -07:00

clk-cs2000-cp.c

clk: cs2000: Add cs2000_set_saved_rate

2017-08-31 11:32:32 -07:00

clk-devres.c

clk: add managed version of clk_bulk_get

2017-06-02 15:37:49 -07:00

clk-divider.c

clk: Don't write error code into divider register

2017-08-31 18:43:38 -07:00

clk-efm32gg.c

clk: efm32gg: Pass correct type to hw provider registration

2016-11-16 11:08:55 -08:00

clk-fixed-factor.c

clk: fixed-factor: Remove export symbol on setup function

2016-08-15 15:08:03 -07:00

clk-fixed-rate.c

clk: fixed-rate: Remove export symbol on setup function

2016-08-15 15:08:06 -07:00

clk-fractional-divider.c

clk: fractional-divider: allow overriding of approximation

2017-08-08 17:39:48 +02:00

clk-gate.c

clk: gate: expose clk_gate_ops::is_enabled

2017-08-31 18:35:45 -07:00

clk-gemini.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

clk-gpio.c

clk: clk-gpio: Request GPIO descriptor as LOW

2017-11-02 01:20:40 -07:00

clk-hi655x.c

clk: hi6220: Add the hi655x's pmic clock

2017-04-21 19:18:53 -07:00

clk-highbank.c

clk: highbank: Migrate to clk_hw based registration and OF APIs

2016-06-30 12:25:28 -07:00

clk-hsdk-pll.c

ARC: clk: fix spelling mistake: "configurarion" -> "configuration"

2017-11-13 17:44:26 -08:00

clk-max77686.c

clk: max77686: fix number of clocks setup for clk_hw based registration

2016-10-17 15:31:59 -07:00

clk-moxart.c

clk: Convert to using %pOF instead of full_name

2017-07-21 15:49:54 -07:00

clk-multiplier.c

clk: multiplier: Prevent the multiplier from under / over flowing

2016-06-20 13:00:00 -07:00

clk-mux.c

clk: clk-mux: Improve a size determination in clk_hw_register_mux_table()

2017-11-13 17:28:39 -08:00

clk-nomadik.c

clk: nomadik: Delete error messages for a failed memory allocation in two functions

2017-04-21 19:47:14 -07:00

clk-nspire.c

clk: nspire: Migrate to clk_hw based OF and registration APIs

2016-08-24 17:23:21 -07:00

clk-oxnas.c

clk: oxnas: Add OX820 Gate clocks

2016-10-23 10:18:45 -07:00

clk-palmas.c

clk: palmas: undo preparation of a clock source.

2017-06-02 10:51:34 -07:00

clk-pwm.c

clk: pwm: Migrate to clk_hw based OF and registration APIs

2016-08-24 17:23:27 -07:00

clk-qoriq.c

clk: Convert to using %pOF instead of full_name

2017-07-21 15:49:54 -07:00

clk-rk808.c

clk: rk808: Pass the right pointer as the get_hw context

2016-09-09 11:07:07 -07:00

clk-s2mps11.c

clk: s2mps11: Migrate to clk_hw based OF and registration APIs

2016-06-30 12:29:14 -07:00

clk-scpi.c

clk: scpi: error when clock fails to register

2017-06-29 18:47:35 -07:00

clk-si514.c

clk: si514: Migrate to clk_hw based OF and registration APIs

2016-08-24 17:29:59 -07:00

clk-si570.c

clk: si570: Migrate to clk_hw based OF and registration APIs

2016-08-24 17:30:01 -07:00

clk-si5351.c

clk: si5351: fix PLL reset

2017-09-01 16:00:54 -07:00

clk-si5351.h

…

clk-stm32f4.c

clk: Convert to using %pOF instead of full_name

2017-07-21 15:49:54 -07:00

clk-stm32h7.c

clk: stm32h7: fix test of clock config

2017-11-14 17:06:49 -08:00

clk-tango4.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

clk-twl6040.c

clk: make clk_init_data const

2017-11-01 23:25:51 -07:00

clk-u300.c

clk: clk-u300: Fix a typo in two comment lines

2017-11-13 17:39:43 -08:00

clk-versaclock5.c

clk: vc5: Add support for IDT VersaClock 5P49V5925

2017-07-17 11:51:00 -07:00

clk-vt8500.c

clk: vt8500: Migrate to clk_hw based registration APIs

2016-08-24 17:35:48 -07:00

clk-wm831x.c

clk: make clk_init_data const

2017-11-01 23:25:51 -07:00

clk-xgene.c

clk: clk-xgene: Adjust six checks for null pointers

2017-11-13 17:40:03 -08:00

clk.c

clk: Manage proper runtime PM state in clk_change_rate()

2017-12-05 15:20:03 -08:00

clk.h

clk: Replace of_clk_get_by_clkspec() with of_clk_get_from_provider()

2015-03-12 12:20:34 -07:00

clkdev.c

clk: Convert to using %pOF instead of full_name

2017-07-21 15:49:54 -07:00

Kconfig

clk: Kconfig: Name RK805 in Kconfig for COMMON_CLK_RK808

2017-08-31 16:20:12 -07:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00