iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/sched
History
Davide Caratti 484afd1bd3 net/sched: act_police: add missing spinlock initialization 
commit f2cbd4852820 ("net/sched: act_police: fix race condition on state
variables") introduces a new spinlock, but forgets its initialization.
Ensure that tcf_police_init() initializes 'tcfp_lock' every time a 'police'
action is newly created, to avoid the following lockdep splat:

 INFO: trying to register non-static key.
 the code is fine but needs lockdep annotation.
 turning off the locking correctness validator.
 <...>
 Call Trace:
  dump_stack+0x85/0xcb
  register_lock_class+0x581/0x590
  __lock_acquire+0xd4/0x1330
  ? tcf_police_init+0x2fa/0x650 [act_police]
  ? lock_acquire+0x9e/0x1a0
  lock_acquire+0x9e/0x1a0
  ? tcf_police_init+0x2fa/0x650 [act_police]
  ? tcf_police_init+0x55a/0x650 [act_police]
  _raw_spin_lock_bh+0x34/0x40
  ? tcf_police_init+0x2fa/0x650 [act_police]
  tcf_police_init+0x2fa/0x650 [act_police]
  tcf_action_init_1+0x384/0x4c0
  tcf_action_init+0xf6/0x160
  tcf_action_add+0x73/0x170
  tc_ctl_action+0x122/0x160
  rtnetlink_rcv_msg+0x2a4/0x490
  ? netlink_deliver_tap+0x99/0x400
  ? validate_linkmsg+0x370/0x370
  netlink_rcv_skb+0x4d/0x130
  netlink_unicast+0x196/0x230
  netlink_sendmsg+0x2e5/0x3e0
  sock_sendmsg+0x36/0x40
  ___sys_sendmsg+0x280/0x2f0
  ? _raw_spin_unlock+0x24/0x30
  ? handle_pte_fault+0xafe/0xf30
  ? find_held_lock+0x2d/0x90
  ? syscall_trace_enter+0x1df/0x360
  ? __sys_sendmsg+0x5e/0xa0
  __sys_sendmsg+0x5e/0xa0
  do_syscall_64+0x60/0x210
  entry_SYSCALL_64_after_hwframe+0x49/0xbe
 RIP: 0033:0x7f1841c7cf10
 Code: c3 48 8b 05 82 6f 2c 00 f7 db 64 89 18 48 83 cb ff eb dd 0f 1f 80 00 00 00 00 83 3d 8d d0 2c 00 00 75 10 b8 2e 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 31 c3 48 83 ec 08 e8 ae cc 00 00 48 89 04 24
 RSP: 002b:00007ffcf9df4d68 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
 RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007f1841c7cf10
 RDX: 0000000000000000 RSI: 00007ffcf9df4dc0 RDI: 0000000000000003
 RBP: 000000005bf56105 R08: 0000000000000002 R09: 00007ffcf9df8edc
 R10: 00007ffcf9df47e0 R11: 0000000000000246 R12: 0000000000671be0
 R13: 00007ffcf9df4e84 R14: 0000000000000008 R15: 0000000000000000

Fixes: f2cbd4852820 ("net/sched: act_police: fix race condition on state variables")
Reported-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2018-11-23 11:20:02 -08:00
..
act_api.c
net: Add extack to nlmsg_parse
2018-10-08 10:39:04 -07:00
act_bpf.c
Revert "net: sched: act: add extack for lookup callback"
2018-08-31 22:50:15 -07:00
act_connmark.c
net_sched: add missing tcf_lock for act_connmark
2018-08-31 22:57:43 -07:00
act_csum.c
Revert "net: sched: act: add extack for lookup callback"
2018-08-31 22:50:15 -07:00
act_gact.c
net/sched: act_gact: disallow 'goto chain' on fallback control action
2018-10-22 19:40:55 -07:00
act_ife.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-09-04 21:33:03 -07:00
act_ipt.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-10-03 21:00:17 -07:00
act_meta_mark.c
net: remove duplicate includes
2017-12-13 13:18:46 -05:00
act_meta_skbprio.c
net sched actions: change IFE modules alias names
2017-10-12 22:13:20 -07:00
act_meta_skbtcindex.c
net: remove duplicate includes
2017-12-13 13:18:46 -05:00
act_mirred.c
act_mirred: clear skb->tstamp on redirect
2018-11-11 10:21:31 -08:00
act_nat.c
net: sched: act_nat: remove dependency on rtnl lock
2018-09-08 10:18:25 -07:00
act_pedit.c
net/sched: act_pedit: fix memory leak when IDR allocation fails
2018-11-16 19:53:45 -08:00
act_police.c
net/sched: act_police: add missing spinlock initialization
2018-11-23 11:20:02 -08:00
act_sample.c
Merge ra.kernel.org:/pub/scm/linux/kernel/git/davem/net
2018-09-18 09:33:27 -07:00
act_simple.c
Revert "net: sched: act: add extack for lookup callback"
2018-08-31 22:50:15 -07:00
act_skbedit.c
net: sched: act_skbedit: remove dependency on rtnl lock
2018-09-08 10:17:35 -07:00
act_skbmod.c
Revert "net: sched: act: add extack for lookup callback"
2018-08-31 22:50:15 -07:00
act_tunnel_key.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-09-12 22:22:42 -07:00
act_vlan.c
Revert "net: sched: act: add extack for lookup callback"
2018-08-31 22:50:15 -07:00
cls_api.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-10-19 11:03:06 -07:00
cls_basic.c
sched: fix trailing whitespace
2018-07-24 14:10:42 -07:00
cls_bpf.c
cls_bpf: Use kmemdup instead of duplicating it in cls_bpf_prog_from_ops
2018-07-29 13:19:49 -07:00
cls_cgroup.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_flow.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_flower.c
net: sched: cls_flower: validate nested enc_opts_policy to avoid warning
2018-11-10 09:55:30 -08:00
cls_fw.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_matchall.c
cls_matchall: fix tcf_unbind_filter missing
2018-08-16 12:08:26 -07:00
cls_route.c
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_rsvp6.c
…
cls_rsvp.c
…
cls_rsvp.h
net_sched: switch to rcu_work
2018-05-24 22:56:15 -04:00
cls_tcindex.c
net_sched: Fix missing res info when create new tc_index filter
2018-08-13 19:37:42 -07:00
cls_u32.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-10-12 21:38:46 -07:00
em_canid.c
net: sched: remove tcf_proto from ematch calls
2014-10-06 18:02:32 -04:00
em_cmp.c
…
em_ipset.c
netfilter: x_tables: move hook state into xt_action_param structure
2016-11-03 10:56:21 +01:00
em_ipt.c
net: sched: add em_ipt ematch for calling xtables matches
2018-02-21 13:15:33 -05:00
em_meta.c
net: convert sock.sk_refcnt from atomic_t to refcount_t
2017-07-01 07:39:08 -07:00
em_nbyte.c
net: sched: em_nbyte: don't add the data offset twice
2018-01-24 14:52:40 -05:00
em_text.c
net: Remove state argument from skb_find_text()
2015-02-22 15:59:54 -05:00
em_u32.c
…
ematch.c
net: sched: ematch: obtain net pointer from blocks
2017-10-16 21:00:40 +01:00
Kconfig
tc: Add support for configuring the taprio scheduler
2018-10-04 13:52:23 -07:00
Makefile
tc: Add support for configuring the taprio scheduler
2018-10-04 13:52:23 -07:00
sch_api.c
net: sched: Remove TCA_OPTIONS from policy
2018-10-24 14:35:09 -07:00
sch_atm.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_blackhole.c
net_sched: blackhole: tell upper qdisc about dropped packets
2018-06-17 08:42:33 +09:00
sch_cake.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2018-10-12 21:38:46 -07:00
sch_cbq.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_cbs.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_choke.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_codel.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_drr.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_dsmark.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_etf.c
net/sched: Make etf report drops on error_queue
2018-07-04 22:30:28 +09:00
sch_fifo.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_fq_codel.c
net: Add and use skb_mark_not_on_list().
2018-09-10 10:06:54 -07:00
sch_fq.c
net_sched: sch_fq: ensure maxrate fq parameter applies to EDT flows
2018-11-15 11:42:12 -08:00
sch_generic.c
net: sched: avoid writing on noop_qdisc
2018-10-10 22:49:16 -07:00
sch_gred.c
net: sched: gred: pass the right attribute to gred_change_table_def()
2018-10-28 19:23:26 -07:00
sch_hfsc.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_hhf.c
net: Add and use skb_mark_not_on_list().
2018-09-10 10:06:54 -07:00
sch_htb.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_ingress.c
net: sched: allow ingress and clsact qdiscs to share filter blocks
2018-01-17 14:53:57 -05:00
sch_mq.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_mqprio.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_multiq.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_netem.c
act_mirred: clear skb->tstamp on redirect
2018-11-11 10:21:31 -08:00
sch_pie.c
net: sched: pie: fix coding style issues
2018-10-07 20:39:01 -07:00
sch_plug.c
net: sched: sch: add extack for change qdisc ops
2017-12-21 12:32:50 -05:00
sch_prio.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_qfq.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_red.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_sfb.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_sfq.c
net: sch: api: add extack support in tcf_block_get
2017-12-21 12:32:51 -05:00
sch_skbprio.c
net/sched: add skbprio scheduler
2018-07-24 14:44:00 -07:00
sch_taprio.c
tc: Add support for configuring the taprio scheduler
2018-10-04 13:52:23 -07:00
sch_tbf.c
net: sched: rename qdisc_destroy() to qdisc_put()
2018-09-25 20:17:35 -07:00
sch_teql.c
net: sched: sch: add extack for init callback
2017-12-21 12:32:50 -05:00