d1c73cbdf9
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
Lastly, fix the following checkpatch warning:
CHECK: Prefer kernel type 'u32' over 'u_int32_t'
#61: FILE: drivers/net/ethernet/cisco/enic/vnic_devcmd.h:653:
+ u_int32_t val[];
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 76497732932f ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
84 lines
2.7 KiB
C
84 lines
2.7 KiB
C
/*
|
|
* Copyright 2010 Cisco Systems, Inc. All rights reserved.
|
|
*
|
|
* This program is free software; you may redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
|
|
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
|
|
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
|
|
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
|
|
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
* SOFTWARE.
|
|
*
|
|
*/
|
|
|
|
#ifndef _VNIC_VIC_H_
|
|
#define _VNIC_VIC_H_
|
|
|
|
/* Note: All integer fields in NETWORK byte order */
|
|
|
|
/* Note: String field lengths include null char */
|
|
|
|
#define VIC_PROVINFO_CISCO_OUI { 0x00, 0x00, 0x0c }
|
|
#define VIC_PROVINFO_GENERIC_TYPE 0x4
|
|
|
|
enum vic_generic_prov_tlv_type {
|
|
VIC_GENERIC_PROV_TLV_PORT_PROFILE_NAME_STR = 0,
|
|
VIC_GENERIC_PROV_TLV_CLIENT_MAC_ADDR = 1,
|
|
VIC_GENERIC_PROV_TLV_CLIENT_NAME_STR = 2,
|
|
VIC_GENERIC_PROV_TLV_CLUSTER_PORT_NAME_STR = 3,
|
|
VIC_GENERIC_PROV_TLV_CLUSTER_PORT_UUID_STR = 4,
|
|
VIC_GENERIC_PROV_TLV_CLUSTER_UUID_STR = 5,
|
|
VIC_GENERIC_PROV_TLV_CLUSTER_NAME_STR = 7,
|
|
VIC_GENERIC_PROV_TLV_HOST_UUID_STR = 8,
|
|
VIC_GENERIC_PROV_TLV_CLIENT_UUID_STR = 9,
|
|
VIC_GENERIC_PROV_TLV_INCARNATION_NUMBER = 10,
|
|
VIC_GENERIC_PROV_TLV_OS_TYPE = 11,
|
|
VIC_GENERIC_PROV_TLV_OS_VENDOR = 12,
|
|
VIC_GENERIC_PROV_TLV_CLIENT_TYPE = 15,
|
|
};
|
|
|
|
enum vic_generic_prov_os_type {
|
|
VIC_GENERIC_PROV_OS_TYPE_UNKNOWN = 0,
|
|
VIC_GENERIC_PROV_OS_TYPE_ESX = 1,
|
|
VIC_GENERIC_PROV_OS_TYPE_LINUX = 2,
|
|
VIC_GENERIC_PROV_OS_TYPE_WINDOWS = 3,
|
|
VIC_GENERIC_PROV_OS_TYPE_SOLARIS = 4,
|
|
};
|
|
|
|
struct vic_provinfo {
|
|
u8 oui[3]; /* OUI of data provider */
|
|
u8 type; /* provider-specific type */
|
|
u32 length; /* length of data below */
|
|
u32 num_tlvs; /* number of tlvs */
|
|
struct vic_provinfo_tlv {
|
|
u16 type;
|
|
u16 length;
|
|
u8 value[0];
|
|
} tlv[];
|
|
} __packed;
|
|
|
|
#define VIC_PROVINFO_ADD_TLV(vp, tlvtype, tlvlen, data) \
|
|
do { \
|
|
err = vic_provinfo_add_tlv(vp, tlvtype, tlvlen, data); \
|
|
if (err) \
|
|
goto add_tlv_failure; \
|
|
} while (0)
|
|
|
|
#define VIC_PROVINFO_MAX_DATA 1385
|
|
#define VIC_PROVINFO_MAX_TLV_DATA (VIC_PROVINFO_MAX_DATA - \
|
|
sizeof(struct vic_provinfo))
|
|
|
|
struct vic_provinfo *vic_provinfo_alloc(gfp_t flags, const u8 *oui,
|
|
const u8 type);
|
|
void vic_provinfo_free(struct vic_provinfo *vp);
|
|
int vic_provinfo_add_tlv(struct vic_provinfo *vp, u16 type, u16 length,
|
|
const void *value);
|
|
size_t vic_provinfo_size(struct vic_provinfo *vp);
|
|
|
|
#endif /* _VNIC_VIC_H_ */
|