Milosz Tanski 5a6f282a20 fscache: Netfs function for cleanup post readpages ... Currently the fscache code expect the netfs to call fscache_readpages_or_alloc inside the aops readpages callback. It marks all the pages in the list provided by readahead with PG_private_2. In the cases that the netfs fails to read all the pages (which is legal) it ends up returning to the readahead and triggering a BUG. This happens because the page list still contains marked pages. This patch implements a simple fscache_readpages_cancel function that the netfs should call before returning from readpages. It will revoke the pages from the underlying cache backend and unmark them. The problem was originally worked out in the Ceph devel tree, but it also occurs in CIFS. It appears that NFS, AFS and 9P are okay as read_cache_pages() will clean up the unprocessed pages in the case of an error. This can be used to address the following oops: [12410647.597278] BUG: Bad page state in process petabucket pfn:3d504e [12410647.597292] page:ffffea000f541380 count:0 mapcount:0 mapping: (null) index:0x0 [12410647.597298] page flags: 0x200000000001000(private_2) ... [12410647.597334] Call Trace: [12410647.597345] [<ffffffff815523f2>] dump_stack+0x19/0x1b [12410647.597356] [<ffffffff8111def7>] bad_page+0xc7/0x120 [12410647.597359] [<ffffffff8111e49e>] free_pages_prepare+0x10e/0x120 [12410647.597361] [<ffffffff8111fc80>] free_hot_cold_page+0x40/0x170 [12410647.597363] [<ffffffff81123507>] __put_single_page+0x27/0x30 [12410647.597365] [<ffffffff81123df5>] put_page+0x25/0x40 [12410647.597376] [<ffffffffa02bdcf9>] ceph_readpages+0x2e9/0x6e0 [ceph] [12410647.597379] [<ffffffff81122a8f>] __do_page_cache_readahead+0x1af/0x260 [12410647.597382] [<ffffffff81122ea1>] ra_submit+0x21/0x30 [12410647.597384] [<ffffffff81118f64>] filemap_fault+0x254/0x490 [12410647.597387] [<ffffffff8113a74f>] __do_fault+0x6f/0x4e0 [12410647.597391] [<ffffffff810125bd>] ? __switch_to+0x16d/0x4a0 [12410647.597395] [<ffffffff810865ba>] ? finish_task_switch+0x5a/0xc0 [12410647.597398] [<ffffffff8113d856>] handle_pte_fault+0xf6/0x930 [12410647.597401] [<ffffffff81008c33>] ? pte_mfn_to_pfn+0x93/0x110 [12410647.597403] [<ffffffff81008cce>] ? xen_pmd_val+0xe/0x10 [12410647.597405] [<ffffffff81005469>] ? __raw_callee_save_xen_pmd_val+0x11/0x1e [12410647.597407] [<ffffffff8113f361>] handle_mm_fault+0x251/0x370 [12410647.597411] [<ffffffff812b0ac4>] ? call_rwsem_down_read_failed+0x14/0x30 [12410647.597414] [<ffffffff8155bffa>] __do_page_fault+0x1aa/0x550 [12410647.597418] [<ffffffff8108011d>] ? up_write+0x1d/0x20 [12410647.597422] [<ffffffff8113141c>] ? vm_mmap_pgoff+0xbc/0xe0 [12410647.597425] [<ffffffff81143bb8>] ? SyS_mmap_pgoff+0xd8/0x240 [12410647.597427] [<ffffffff8155c3ae>] do_page_fault+0xe/0x10 [12410647.597431] [<ffffffff81558818>] page_fault+0x28/0x30 Signed-off-by: Milosz Tanski <milosz@adfin.com> Signed-off-by: David Howells <dhowells@redhat.com>		2013-09-06 09:17:30 +01:00
..
caching	fscache: Netfs function for cleanup post readpages	2013-09-06 09:17:30 +01:00
configfs	configfs: convert to umode_t	2012-01-03 22:54:57 -05:00
nfs	SUNRPC: Use gssproxy upcall for server RPCGSS authentication.	2013-04-26 11:41:28 -04:00
pohmelfs	Documentation: Fix multiple typo in Documentation	2012-03-07 16:08:24 +01:00
9p.txt	9p: fix 9p.txt to advertise msize instead of maxdata	2011-10-24 11:13:12 -05:00
00-INDEX	Introduce a new file system, Flash-Friendly File System (F2FS), to Linux 3.8.	2012-12-20 13:54:52 -08:00
adfs.txt	adfs: add hexadecimal filetype suffix option	2011-03-22 17:44:17 -07:00
affs.txt	Documentation: update broken web addresses.	2010-08-04 15:21:40 +02:00
afs.txt	AFS: Documentation updates	2009-08-19 10:40:13 -07:00
autofs4-mount-control.txt	Fix common misspellings	2011-03-31 11:26:23 -03:00
automount-support.txt
befs.txt	Documentation: befs.txt: no maintainer, orphaned	2011-08-13 18:34:03 -07:00
bfs.txt
btrfs.txt	btrfs: document mount options in Documentation/fs/btrfs.txt	2013-05-06 15:54:26 -04:00
ceph.txt	ceph: enable/disable dentry complete flags via mount option	2012-01-12 11:00:40 -08:00
cifs.txt
coda.txt
cramfs.txt
debugfs.txt	debugfs: more tightly restrict default mount mode	2012-08-27 13:42:02 -07:00
devpts.txt
directory-locking
dlmfs.txt	Documentation/: it's -> its where appropriate	2010-04-23 02:09:52 +02:00
dnotify_test.c	Documentation/fs/: split txt and source files	2010-03-12 15:52:35 -08:00
dnotify.txt	Documentation/fs/: split txt and source files	2010-03-12 15:52:35 -08:00
ecryptfs.txt
efivarfs.txt	efivarfs: Add documentation for the EFI variable filesystem	2012-10-30 10:39:18 +00:00
exofs.txt	exofs: Add option to mount by osdname	2011-03-15 15:02:51 +02:00
ext2.txt	Doc fix: ext2 can only have 32,000 subdirs, not 32,768	2009-06-18 13:03:44 -07:00
ext3.txt	ext3: update documentation with barrier=1 default	2012-04-11 11:12:45 +02:00
ext4.txt	ext4: introduce reserved space	2013-04-09 22:11:22 -04:00
f2fs.txt	f2fs: add remount_fs callback support	2013-06-17 21:17:55 +09:00
fiemap.txt	Documentation/: it's -> its where appropriate	2010-04-23 02:09:52 +02:00
files.txt	Wrap accesses to the fd_sets in struct fdtable	2012-02-19 10:30:52 -08:00
fuse.txt	Documentation/: it's -> its where appropriate	2010-04-23 02:09:52 +02:00
gfs2-glocks.txt	GFS2: Update glock doc to add new stats info	2012-05-10 12:41:40 +01:00
gfs2-uevents.txt	Documentation: Fix multiple typo in Documentation	2012-03-07 16:08:24 +01:00
gfs2.txt	GFS2: Update main gfs2 doc	2012-05-10 11:45:31 +01:00
hfs.txt	Documentation: HFS is orphaned	2011-11-04 12:01:48 -07:00
hfsplus.txt
hpfs.txt	Documentation/: it's -> its where appropriate	2010-04-23 02:09:52 +02:00
inotify.txt	Documentation: fix inotify source file paths	2011-11-04 12:01:47 -07:00
isofs.txt	Documentation: update broken web addresses.	2010-08-04 15:21:40 +02:00
jfs.txt	doc: fix misspellings with 'codespell' tool	2013-05-28 12:02:12 +02:00
Locking	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2013-07-03 09:10:19 -07:00
locks.txt	doc: fix broken references	2011-09-27 18:08:04 +02:00
logfs.txt	fix "seperate" typos in comments	2010-05-10 11:56:30 +02:00
Makefile	Documentation/fs/: split txt and source files	2010-03-12 15:52:35 -08:00
mandatory-locking.txt
ncpfs.txt	ncpfs: remove dead URL from documentation	2009-09-23 07:39:42 -07:00
nilfs2.txt	nilfs2: remove resize from unsupported features list	2011-07-13 16:08:59 +09:00
ntfs.txt	Fix common misspellings	2011-03-31 11:26:23 -03:00
ocfs2.txt	ocfs2: clean up mount option about atime in ocfs2.txt	2011-05-23 23:37:12 -07:00
omfs.txt
path-lookup.txt	Fix common misspellings	2011-03-31 11:26:23 -03:00
porting	[readdir] ->readdir() is gone	2013-06-29 12:57:04 +04:00
proc.txt	mm: soft-dirty bits for user memory changes tracking	2013-07-03 16:07:26 -07:00
qnx6.txt	doc: fix misspellings with 'codespell' tool	2013-05-28 12:02:12 +02:00
quota.txt
ramfs-rootfs-initramfs.txt	Documentation: Fix Broken URL "freshmeat"	2012-02-21 11:43:45 +01:00
relay.txt
romfs.txt	Documentation/filesystems/romfs.txt: fixing link to genromfs	2011-02-17 22:04:46 +01:00
seq_file.txt	seq_file: use proc_create() in documentation	2009-12-16 07:20:07 -08:00
sharedsubtree.txt	Documentation: Fix trivial typo in filesystems/sharedsubtree.txt	2010-10-25 21:18:21 -04:00
spufs.txt
squashfs.txt	Squashfs: Update documentation to include xattrs	2011-12-30 01:20:24 +00:00
sysfs-pci.txt	PCI: Allow read/write access to sysfs I/O port resources	2010-07-30 09:32:08 -07:00
sysfs-tagging.txt	sysfs-namespaces: add a high-level Documentation file	2010-05-21 09:37:31 -07:00
sysfs.txt	sysfs: propagate umode_t	2012-01-03 22:55:03 -05:00
sysv-fs.txt
tmpfs.txt	mempolicy: document cpuset interaction with tmpfs mpol mount option	2010-05-25 08:06:57 -07:00
ubifs.txt	UBIFS: switch self-check knobs to debugfs	2011-07-04 10:54:28 +03:00
udf.txt
ufs.txt
vfat.txt	doc: fix misspellings with 'codespell' tool	2013-05-28 12:02:12 +02:00
vfs.txt	documentation: document the is_dirty_writeback aops callback	2013-07-03 16:07:40 -07:00
xfs-delayed-logging-design.txt	Fix common misspellings	2011-03-31 11:26:23 -03:00
xfs-self-describing-metadata.txt	xfs: add metadata CRC documentation	2013-04-27 13:27:43 -05:00
xfs.txt	xfs: update mount options documentation	2013-07-09 16:26:18 -05:00
xip.txt