Miklos Szeredi 5aae6c46a5 fuse: fix possibly missed wake-up after abort
commit 2d84a2d19b6150c6dbac1e6ebad9c82e4c123772 upstream.

In current fuse_drop_waiting() implementation it's possible that
fuse_wait_aborted() will not be woken up in the unlikely case that
fuse_abort_conn() + fuse_wait_aborted() runs in between checking
fc->connected and calling atomic_dec(&fc->num_waiting).

Do the atomic_dec_and_test() unconditionally, which also provides the
necessary barrier against reordering with the fc->connected check.

The explicit smp_mb() in fuse_wait_aborted() is not actually needed, since
the spin_unlock() in fuse_abort_conn() provides the necessary RELEASE
barrier after resetting fc->connected.  However, this is not a performance
sensitive path, and adding the explicit barrier makes it easier to
document.

Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: b8f95e5d13f5 ("fuse: umount should wait for all requests")
Cc: <stable@vger.kernel.org> #v4.19
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-05-02 17:23:15 +02:00
..
2020-01-29 10:24:34 +01:00
2016-10-15 12:09:13 -07:00
2019-08-06 18:29:38 +02:00
2019-12-21 10:41:21 +01:00
2020-01-23 08:19:37 +01:00
2017-11-30 08:39:04 +00:00
2019-03-13 14:04:52 -07:00
2018-12-21 14:11:31 +01:00
2016-09-27 21:20:53 -04:00
2020-04-24 07:58:54 +02:00
2020-04-02 17:20:27 +02:00
2018-02-17 13:21:15 +01:00
2017-06-14 15:06:01 +02:00