Vincent Guittot 5ab297bab9 sched/fair: Fix reordering of enqueue/dequeue_task_fair()
Even when a cgroup is throttled, the group se of a child cgroup can still
be enqueued and its gse->on_rq stays true. When a task is enqueued on such
child, we still have to update the load_avg and increase
h_nr_running of the throttled cfs. Nevertheless, the 1st
for_each_sched_entity() loop is skipped because of gse->on_rq == true and the
2nd loop because the cfs is throttled whereas we have to update both
load_avg with the old h_nr_running and increase h_nr_running in such case.

The same sequence can happen during dequeue when se moves to parent before
breaking in the 1st loop.

Note that the update of load_avg will effectively happen only once in order
to sync up to the throttled time. Next call for updating load_avg will stop
early because the clock stays unchanged.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Fixes: 6d4d22468dae ("sched/fair: Reorder enqueue/dequeue_task_fair path")
Link: https://lkml.kernel.org/r/20200306084208.12583-1-vincent.guittot@linaro.org
2020-03-06 12:57:25 +01:00
..
2019-11-27 11:42:01 -08:00
2020-02-28 11:43:30 -08:00
2019-12-18 18:07:31 +01:00
2019-07-08 18:55:42 -07:00
2020-01-03 11:17:14 -08:00
2020-01-29 19:56:50 -08:00
2020-01-09 13:23:40 +01:00
2020-02-09 16:05:50 -08:00
2019-12-04 19:44:14 -08:00
2020-01-08 16:32:55 +00:00
2019-05-24 20:16:01 +02:00
2020-01-14 12:20:48 +01:00
2019-12-11 16:37:02 +08:00
2020-01-13 21:49:36 +01:00
2019-12-04 15:18:39 +01:00
2019-12-18 18:07:31 +01:00
2019-07-08 19:36:47 -07:00
2019-07-08 19:36:47 -07:00