Laurentiu Tudor 5aeb05b27f software node: balance refcount for managed software nodes ... software_node_notify(), on KOBJ_REMOVE drops the refcount twice on managed software nodes, thus leading to underflow errors. Balance the refcount by bumping it in the device_create_managed_software_node() function. The error [1] was encountered after adding a .shutdown() op to our fsl-mc-bus driver. [1] pc : refcount_warn_saturate+0xf8/0x150 lr : refcount_warn_saturate+0xf8/0x150 sp : ffff80001009b920 x29: ffff80001009b920 x28: ffff1a2420318000 x27: 0000000000000000 x26: ffffccac15e7a038 x25: 0000000000000008 x24: ffffccac168e0030 x23: ffff1a2428a82000 x22: 0000000000080000 x21: ffff1a24287b5000 x20: 0000000000000001 x19: ffff1a24261f4400 x18: ffffffffffffffff x17: 6f72645f726f7272 x16: 0000000000000000 x15: ffff80009009b607 x14: 0000000000000000 x13: ffffccac16602670 x12: 0000000000000a17 x11: 000000000000035d x10: ffffccac16602670 x9 : ffffccac16602670 x8 : 00000000ffffefff x7 : ffffccac1665a670 x6 : ffffccac1665a670 x5 : 0000000000000000 x4 : 0000000000000000 x3 : 00000000ffffffff x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff1a2420318000 Call trace: refcount_warn_saturate+0xf8/0x150 kobject_put+0x10c/0x120 software_node_notify+0xd8/0x140 device_platform_notify+0x4c/0xb4 device_del+0x188/0x424 fsl_mc_device_remove+0x2c/0x4c rebofind sp.c__fsl_mc_device_remove+0x14/0x2c device_for_each_child+0x5c/0xac dprc_remove+0x9c/0xc0 fsl_mc_driver_remove+0x28/0x64 __device_release_driver+0x188/0x22c device_release_driver+0x30/0x50 bus_remove_device+0x128/0x134 device_del+0x16c/0x424 fsl_mc_bus_remove+0x8c/0x114 fsl_mc_bus_shutdown+0x14/0x20 platform_shutdown+0x28/0x40 device_shutdown+0x15c/0x330 __do_sys_reboot+0x218/0x2a0 __arm64_sys_reboot+0x28/0x34 invoke_syscall+0x48/0x114 el0_svc_common+0x40/0xdc do_el0_svc+0x2c/0x94 el0_svc+0x2c/0x54 el0t_64_sync_handler+0xa8/0x12c el0t_64_sync+0x198/0x19c ---[ end trace 32eb1c71c7d86821 ]--- Fixes: 151f6ff78c ("software node: Provide replacement for device_add_properties()") Reported-by: Jon Nettleton <jon@solid-run.com> Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com> Cc: 5.12+ <stable@vger.kernel.org> # 5.12+ [ rjw: Fix up the software_node_notify() invocation ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>		2021-09-16 13:13:48 +02:00
..
firmware_loader	Merge 5.14-rc5 into driver-core-next	2021-08-09 09:03:47 +02:00
power	Merge branches 'pm-cpufreq', 'pm-sleep' and 'pm-em'	2021-09-10 20:26:08 +02:00
regmap	Merge series "Use raw spinlocks in the ls-extirq driver" from Vladimir Oltean <vladimir.oltean@nxp.com>:	2021-08-26 13:40:35 +01:00
test	device property: Remove some casts in property-entry-test	2021-06-23 16:37:21 -06:00
arch_numa.c	memblock: make memblock_find_in_range method private	2021-09-03 09:58:17 -07:00
arch_topology.c	cpufreq: qcom-cpufreq-hw: Add dcvs interrupt support	2021-08-30 10:43:35 +05:30
attribute_container.c	driver core: attribute_container: fix W=1 warnings	2021-05-14 13:37:10 +02:00
auxiliary.c	Merge 5.14-rc3 into driver-core-next	2021-07-27 09:22:08 +02:00
base.h	software nodes: Split software_node_notify()	2021-07-16 19:17:05 +02:00
bus.c	driver: base: Replace symbolic permissions with octal permissions	2021-07-21 14:56:00 +02:00
cacheinfo.c	cacheinfo: clear cache_leaves(cpu) in free_cache_attributes()	2021-07-21 17:29:40 +02:00
class.c	drivers: base: fix some kernel-doc markups	2020-11-09 18:56:49 +01:00
component.c	component: Rename 'dev' to 'parent'	2021-05-27 15:49:59 +02:00
container.c
core.c	Merge branch 'stable/for-linus-5.15' of git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb	2021-09-03 10:34:44 -07:00
cpu.c	driver: base: Prefer unsigned int to bare use of unsigned	2021-07-21 17:30:09 +02:00
dd.c	Merge 5.14-rc5 into driver-core-next	2021-08-09 09:03:47 +02:00
devcoredump.c	devcoredump: remove contact information	2021-06-04 15:05:44 +02:00
devres.c	devres: Enable trace events	2021-06-15 17:14:36 +02:00
devtmpfs.c	devtmpfs: actually reclaim some init memory	2021-03-23 14:57:35 +01:00
driver.c
firmware.c
hypervisor.c
init.c	driver core: auxiliary bus: Fix calling stage for auxiliary bus init	2021-02-11 08:43:03 +01:00
isa.c	bus: Make remove callback return void	2021-07-21 11:53:42 +02:00
Kconfig	RISC-V Patches for the 5.12 Merge Window	2021-02-26 10:28:35 -08:00
Makefile	devres: Enable trace events	2021-06-15 17:14:36 +02:00
map.c	driver: base: Prefer unsigned int to bare use of unsigned	2021-07-21 17:30:09 +02:00
memory.c	Merge branch 'akpm' (patches from Andrew)	2021-09-08 12:55:35 -07:00
module.c
node.c	Merge branch 'akpm' (patches from Andrew)	2021-09-08 12:55:35 -07:00
pinctrl.c
platform-msi.c	platform-msi: Add ABI to show msi_irqs of platform devices	2021-08-24 09:16:20 +02:00
platform.c	driver core: platform: Remove platform_device_add_properties()	2021-08-18 16:08:11 +02:00
property.c	Revert "media: device property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary"	2021-08-16 18:35:42 +02:00
soc.c	soc: fix comment for freeing soc_dev_attr	2020-12-09 19:46:31 +01:00
swnode.c	software node: balance refcount for managed software nodes	2021-09-16 13:13:48 +02:00
syscore.c
topology.c	topology: use bin_attribute to break the size limitation of cpumap ABI	2021-08-13 10:27:49 +02:00
trace.c	devres: Enable trace events	2021-06-15 17:14:36 +02:00
trace.h	devres: Enable trace events	2021-06-15 17:14:36 +02:00
transport_class.c