iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers
History
Emil Tantilov 5b0948dfe1 PCI: Lock each enable/disable num_vfs operation in sysfs 
Enabling/disabling SRIOV via sysfs by echo-ing multiple values
simultaneously:

  # echo 63 > /sys/class/net/ethX/device/sriov_numvfs&
  # echo 63 > /sys/class/net/ethX/device/sriov_numvfs

  # sleep 5

  # echo 0 > /sys/class/net/ethX/device/sriov_numvfs&
  # echo 0 > /sys/class/net/ethX/device/sriov_numvfs

results in the following bug:

  kernel BUG at drivers/pci/iov.c:495!
  invalid opcode: 0000 [#1] SMP
  CPU: 1 PID: 8050 Comm: bash Tainted: G   W   4.9.0-rc7-net-next #2092
  RIP: 0010:[<ffffffff813b1647>]
	    [<ffffffff813b1647>] pci_iov_release+0x57/0x60

  Call Trace:
   [<ffffffff81391726>] pci_release_dev+0x26/0x70
   [<ffffffff8155be6e>] device_release+0x3e/0xb0
   [<ffffffff81365ee7>] kobject_cleanup+0x67/0x180
   [<ffffffff81365d9d>] kobject_put+0x2d/0x60
   [<ffffffff8155bc27>] put_device+0x17/0x20
   [<ffffffff8139c08a>] pci_dev_put+0x1a/0x20
   [<ffffffff8139cb6b>] pci_get_dev_by_id+0x5b/0x90
   [<ffffffff8139cca5>] pci_get_subsys+0x35/0x40
   [<ffffffff8139ccc8>] pci_get_device+0x18/0x20
   [<ffffffff8139ccfb>] pci_get_domain_bus_and_slot+0x2b/0x60
   [<ffffffff813b09e7>] pci_iov_remove_virtfn+0x57/0x180
   [<ffffffff813b0b95>] pci_disable_sriov+0x65/0x140
   [<ffffffffa00a1af7>] ixgbe_disable_sriov+0xc7/0x1d0 [ixgbe]
   [<ffffffffa00a1e9d>] ixgbe_pci_sriov_configure+0x3d/0x170 [ixgbe]
   [<ffffffff8139d28c>] sriov_numvfs_store+0xdc/0x130
  ...
  RIP  [<ffffffff813b1647>] pci_iov_release+0x57/0x60

Use the existing mutex lock to protect each enable/disable operation.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
CC: Alexander Duyck <alexander.h.duyck@intel.com>
2017-02-03 13:42:38 -06:00
..
accessibility
…
acpi
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
amba
…
android
…
ata
Merge branch 'for-4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2016-12-13 15:30:50 -08:00
atm
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
auxdisplay
…
base
avoid spurious "may be used uninitialized" warning
2016-12-25 14:56:58 -08:00
bcma
…
block
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
bluetooth
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-12-16 10:24:44 -08:00
bus
cpu/hotplug: Cleanup state names
2016-12-25 10:47:44 +01:00
cdrom
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
char
clocksource: Use a plain u64 instead of cycle_t
2016-12-25 11:04:12 +01:00
clk
Merge branch 'for-linus' of git://git.armlinux.org.uk/~rmk/linux-arm
2016-12-15 16:06:15 -08:00
clocksource
Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-12-25 14:30:04 -08:00
connector
…
cpufreq
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
cpuidle
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
crypto
crypto: add virtio-crypto driver
2016-12-16 00:13:32 +02:00
dax
libnvdimm for 4.10
2016-12-18 15:49:10 -08:00
dca
…
devfreq
devfreq: rk3399_dmc: Don't use OPP structures outside of RCU locks
2016-12-08 01:46:07 +01:00
dio
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
dma
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
dma-buf
…
edac
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
eisa
…
extcon
sound updates for 4.10-rc1
2016-12-14 11:14:28 -08:00
firewire
…
firmware
firmware: dmi_scan: Always show system identification string
2016-12-19 10:01:47 +01:00
fmc
…
fpga
…
gpio
- New Device Support
2016-12-19 08:16:26 -08:00
gpu
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
hid
Merge branches 'for-4.10/asus', 'for-4.10/cp2112', 'for-4.10/i2c-hid-nopower', 'for-4.10/intel-ish', 'for-4.10/mayflash', 'for-4.10/microsoft-surface-3', 'for-4.10/multitouch', 'for-4.10/sony', 'for-4.10/udraw-ps3', 'for-4.10/upstream' and 'for-4.10/wacom/generic' into for-linus
2016-12-14 10:12:26 +01:00
hsi
…
hv
clocksource: Use a plain u64 instead of cycle_t
2016-12-25 11:04:12 +01:00
hwmon
hwmon: (g762) Fix overflows and crash seen when writing limit attributes
2016-12-12 11:33:44 -08:00
hwspinlock
…
hwtracing
coresight/etm3/4x: Consolidate hotplug state space
2016-12-25 10:47:44 +01:00
i2c
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
ide
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
idle
Power management material for v4.10-rc1
2016-12-13 10:41:53 -08:00
iio
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
infiniband
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
input
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
iommu
More ACPI updates for v4.10-rc1
2016-12-22 10:19:32 -08:00
ipack
…
irqchip
Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-12-25 14:30:04 -08:00
isdn
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
leds
cpu/hotplug: Cleanup state names
2016-12-25 10:47:44 +01:00
lguest
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
lightnvm
Char/Misc driver patches for 4.10-rc1
2016-12-13 12:11:01 -08:00
macintosh
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
mailbox
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
mcb
…
md
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
media
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
memory
…
memstick
Merge branch 'for-4.10/block' of git://git.kernel.dk/linux-block
2016-12-13 10:19:16 -08:00
message
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
mfd
- New Device Support
2016-12-19 08:16:26 -08:00
misc
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
mmc
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
mtd
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
net
Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-12-25 14:30:04 -08:00
nfc
…
ntb
ntb_transport: Remove unnecessary call to ntb_peer_spad_read
2016-12-23 16:11:07 -05:00
nubus
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
nvdimm
libnvdimm for 4.10
2016-12-18 15:49:10 -08:00
nvme
nvme : Use correct scnprintf in cmb show
2016-12-19 08:35:24 -07:00
nvmem
…
of
pci-v4.10-changes
2016-12-15 12:46:48 -08:00
oprofile
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
parisc
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
parport
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
pci
PCI: Lock each enable/disable num_vfs operation in sysfs
2017-02-03 13:42:38 -06:00
pcmcia
drivers/pcmcia/m32r_pcc.c: check return from add_pcc_socket
2016-12-12 18:55:06 -08:00
perf
cpu/hotplug: Cleanup state names
2016-12-25 10:47:44 +01:00
phy
SCSI misc on 20161213
2016-12-14 10:49:33 -08:00
pinctrl
ARM: DT updates for v4.10
2016-12-15 15:50:24 -08:00
platform
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
pnp
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
power
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
powercap
…
pps
…
ps3
…
ptp
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-12-12 19:56:15 -08:00
pwm
pwm: Changes for v4.10-rc1
2016-12-15 11:45:13 -08:00
rapidio
…
ras
…
regulator
- New Device Support
2016-12-19 08:16:26 -08:00
remoteproc
remoteproc: qcom_adsp_pil: select qcom_scm
2016-12-09 16:16:56 -08:00
reset
ARM: SoC driver updates for v4.10
2016-12-15 16:03:25 -08:00
rpmsg
rpmsg updates for v4.10
2016-12-13 08:52:45 -08:00
rtc
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
s390
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
sbus
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
scsi
Merge branch 'timers-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2016-12-25 14:30:04 -08:00
sfi
…
sh
lib: radix-tree: check accounting of existing slot replacement users
2016-12-12 18:55:08 -08:00
sn
…
soc
powerpc updates for 4.10
2016-12-16 09:26:42 -08:00
spi
dmaengine updates for 4.10-rc1
2016-12-14 20:42:45 -08:00
spmi
…
ssb
…
staging
staging/lustre/libcfs: Convert to hotplug state machine
2016-12-25 10:47:43 +01:00
target
Merge branch 'scsi-target-for-v4.10' of git://git.kernel.org/pub/scm/linux/kernel/git/bvanassche/linux
2016-12-21 10:16:05 -08:00
tc
…
thermal
Power management material for v4.10-rc1
2016-12-13 10:41:53 -08:00
thunderbolt
Char/Misc driver patches for 4.10-rc1
2016-12-13 12:11:01 -08:00
tty
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
uio
uio-hv-generic: store physical addresses instead of virtual
2016-12-10 14:57:58 +01:00
usb
ktime: Cleanup ktime_set() usage
2016-12-25 17:21:22 +01:00
uwb
…
vfio
powerpc updates for 4.10
2016-12-16 09:26:42 -08:00
vhost
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-12-16 10:24:44 -08:00
video
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
virt
…
virtio
virtio_mmio: Set dev.release() to avoid warning
2016-12-16 00:13:39 +02:00
vlynq
…
vme
…
w1
…
watchdog
Watchdog updates for v4.10
2016-12-24 11:27:45 -08:00
xen
cpu/hotplug: Cleanup state names
2016-12-25 10:47:44 +01:00
zorro
Replace <asm/uaccess.h> with <linux/uaccess.h> globally
2016-12-24 11:46:01 -08:00
Kconfig
…
Makefile
…