Ido Schimmel 5b8d5429da bridge: netlink: register netdevice before executing changelink ... Peter reported a kernel oops when executing the following command: $ ip link add name test type bridge vlan_default_pvid 1 [13634.939408] BUG: unable to handle kernel NULL pointer dereference at 0000000000000190 [13634.939436] IP: __vlan_add+0x73/0x5f0 [...] [13634.939783] Call Trace: [13634.939791] ? pcpu_next_unpop+0x3b/0x50 [13634.939801] ? pcpu_alloc+0x3d2/0x680 [13634.939810] ? br_vlan_add+0x135/0x1b0 [13634.939820] ? __br_vlan_set_default_pvid.part.28+0x204/0x2b0 [13634.939834] ? br_changelink+0x120/0x4e0 [13634.939844] ? br_dev_newlink+0x50/0x70 [13634.939854] ? rtnl_newlink+0x5f5/0x8a0 [13634.939864] ? rtnl_newlink+0x176/0x8a0 [13634.939874] ? mem_cgroup_commit_charge+0x7c/0x4e0 [13634.939886] ? rtnetlink_rcv_msg+0xe1/0x220 [13634.939896] ? lookup_fast+0x52/0x370 [13634.939905] ? rtnl_newlink+0x8a0/0x8a0 [13634.939915] ? netlink_rcv_skb+0xa1/0xc0 [13634.939925] ? rtnetlink_rcv+0x24/0x30 [13634.939934] ? netlink_unicast+0x177/0x220 [13634.939944] ? netlink_sendmsg+0x2fe/0x3b0 [13634.939954] ? _copy_from_user+0x39/0x40 [13634.939964] ? sock_sendmsg+0x30/0x40 [13634.940159] ? ___sys_sendmsg+0x29d/0x2b0 [13634.940326] ? __alloc_pages_nodemask+0xdf/0x230 [13634.940478] ? mem_cgroup_commit_charge+0x7c/0x4e0 [13634.940592] ? mem_cgroup_try_charge+0x76/0x1a0 [13634.940701] ? __handle_mm_fault+0xdb9/0x10b0 [13634.940809] ? __sys_sendmsg+0x51/0x90 [13634.940917] ? entry_SYSCALL_64_fastpath+0x1e/0xad The problem is that the bridge's VLAN group is created after setting the default PVID, when registering the netdevice and executing its ndo_init(). Fix this by changing the order of both operations, so that br_changelink() is only processed after the netdevice is registered, when the VLAN group is already initialized. Fixes: b6677449df ("bridge: netlink: call br_changelink() during br_dev_newlink()") Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com> Signed-off-by: Ido Schimmel <idosch@mellanox.com> Reported-by: Peter V. Saveliev <peter@svinota.eu> Tested-by: Peter V. Saveliev <peter@svinota.eu> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-04-11 22:22:44 -04:00
..
6lowpan	6lowpan: use rb_entry()	2017-01-22 16:46:13 -05:00
9p	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-03-03 21:44:35 -08:00
802	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
8021q	net: remove ndo_neigh_{construct, destroy} from stacked devices	2017-02-06 11:25:57 -05:00
appletalk	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
atm	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
ax25	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
batman-adv	Here are two batman-adv bugfixes:	2017-03-16 12:05:38 -07:00
bluetooth	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
bridge	bridge: netlink: register netdevice before executing changelink	2017-04-11 22:22:44 -04:00
caif	sched/headers: Prepare for new header dependencies before moving code to <linux/sched/signal.h>	2017-03-02 08:42:29 +01:00
can	can: bcm: fix hrtimer/tasklet termination in bcm op removal	2017-01-30 11:05:04 +01:00
ceph	libceph: force GFP_NOIO for socket allocations	2017-03-23 12:03:36 +01:00
core	Merge branch 'for-davem' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2017-04-06 11:57:04 -07:00
dcb	net: dcb: set error code on failures	2016-12-03 23:54:25 -05:00
dccp	dccp: fix memory leak during tear-down of unsuccessful connection request	2017-03-13 22:00:42 -07:00
decnet	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
dns_resolver	Merge branch 'WIP.sched-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2017-03-03 10:16:38 -08:00
dsa	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-02-11 02:31:11 -05:00
ethernet	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2017-02-16 21:25:49 -05:00
hsr	net/hsr: use eth_hw_addr_random()	2017-02-21 13:25:22 -05:00
ieee802154	lib/vsprintf.c: remove %Z support	2017-02-27 18:43:47 -08:00
ife	net: Introduce ife encapsulation module	2017-02-03 15:16:45 -05:00
ipv4	tcp: clear saved_syn in tcp_disconnect()	2017-04-09 18:27:28 -07:00
ipv6	ipv6: make sure to initialize sockc.tsflags before first use	2017-03-22 12:40:22 -07:00
ipx	ktime: Get rid of the union	2016-12-25 17:21:22 +01:00
irda	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
iucv	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
kcm	kcm: return immediately after copy_from_user() failure	2017-03-24 13:13:53 -07:00
key	netns: make struct pernet_operations::id unsigned int	2016-11-18 10:59:15 -05:00
l2tp	l2tp: don't mask errors in pppol2tp_getsockopt()	2017-04-08 08:29:04 -07:00
l3mdev
lapb	Replace <asm/uaccess.h> with <linux/uaccess.h> globally	2016-12-24 11:46:01 -08:00
llc	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
mac80211	mac80211: unconditionally start new netdev queues with iTXQ support	2017-03-29 14:20:40 +02:00
mac802154	sched/headers: Prepare to use <linux/rcuupdate.h> instead of <linux/rculist.h> in <linux/sched.h>	2017-03-02 08:42:38 +01:00
mpls	net: mpls: Fix nexthop alive tracking on down events	2017-03-16 20:22:18 -07:00
ncsi	net/ncsi: Improve HNCDSC AEN handler	2016-10-20 11:23:08 -04:00
netfilter	netfilter: nfnetlink_queue: fix secctx memory leak	2017-03-29 12:20:50 +02:00
netlabel	netlabel: add CALIPSO to the list of built-in protocols	2017-01-06 22:20:45 -05:00
netlink	genetlink: fix counting regression on ctrl_dumpfamily()	2017-03-22 15:38:43 -07:00
netrom	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
nfc	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
openvswitch	openvswitch: Fix ovs_flow_key_update()	2017-04-01 12:16:46 -07:00
packet	net/packet: fix overflow in check for tp_reserve	2017-03-30 11:04:00 -07:00
phonet	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
psample	net: Introduce psample, a new genetlink channel for packet sampling	2017-01-24 13:44:28 -05:00
qrtr	net: qrtr: Mark 'buf' as little endian	2017-01-10 20:45:04 -05:00
rds	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
rfkill	rfkill: remove rfkill-regulator	2017-01-24 11:07:35 +01:00
rose	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
rxrpc	rxrpc: Ignore BUSY packets on old calls	2017-03-16 21:27:57 -07:00
sched	net_sched: check noop_qdisc before qdisc_hash_add()	2017-04-06 12:28:39 -07:00
sctp	sctp: listen on the sock only when it's state is listening or closed	2017-04-06 13:55:51 -07:00
smc	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
strparser	strparser: destroy workqueue on module exit	2017-03-03 20:43:26 -08:00
sunrpc	The restriction of NFSv4 to TCP went overboard and also broke the	2017-04-01 10:43:37 -07:00
switchdev	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2016-10-30 12:42:58 -04:00
tipc	tipc: fix nametbl deadlock at tipc_nametbl_unsubscribe	2017-03-22 11:59:16 -07:00
unix	net: unix: properly re-increment inflight counter of GC discarded candidates	2017-03-21 15:25:10 -07:00
vmw_vsock	vsock: cancel packets when failing to connect	2017-03-21 14:41:47 -07:00
wimax	genetlink: mark families as __ro_after_init	2016-10-27 16:16:09 -04:00
wireless	cfg80211: check rdev resume callback only for registered wiphy	2017-03-29 09:11:29 +02:00
x25	net: Work around lockdep limitation in sockets that use sockets	2017-03-09 18:23:27 -08:00
xfrm	Merge branch 'apw' (xfrm_user fixes)	2017-03-29 13:26:22 -07:00
compat.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2017-02-22 10:15:09 -08:00
Kconfig	bpf: make jited programs visible in traces	2017-02-17 13:40:05 -05:00
Makefile	net: Introduce ife encapsulation module	2017-02-03 15:16:45 -05:00
socket.c	tcp: mark skbs with SCM_TIMESTAMPING_OPT_STATS	2017-03-21 18:44:17 -07:00
sysctl_net.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2016-10-06 09:52:23 -07:00