71c789760f
The mtk-vcodec uses some internal defined debug formats for printing. This patch fixes some things in those defines: 1. use the 'pr_fmt' define to print function name and line. 2. remove 'if(DEBUG)' condition for the defines. This condition prevents the debugs from being shown in case of dynamic debugs. Instead replace 'pr_info' with 'pr_debug' 3. remove module parameters that enable/disable debug. There is no reason for the driver to have those params. Having those params require the user to explicitly set them when user wants to see debug prints instead of using the global debugs setting as expected by drivers to conform. In addition to that, fix some warnings about debug formatting [hverkuil: used %zu instead of %lu for sizeof() arguments] Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
62 lines
1.7 KiB
C
62 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2016 MediaTek Inc.
|
|
* Author: PC Chen <pc.chen@mediatek.com>
|
|
* Tiffany Lin <tiffany.lin@mediatek.com>
|
|
*/
|
|
|
|
#ifndef _MTK_VCODEC_UTIL_H_
|
|
#define _MTK_VCODEC_UTIL_H_
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/dma-direction.h>
|
|
|
|
struct mtk_vcodec_mem {
|
|
size_t size;
|
|
void *va;
|
|
dma_addr_t dma_addr;
|
|
};
|
|
|
|
struct mtk_vcodec_fb {
|
|
size_t size;
|
|
dma_addr_t dma_addr;
|
|
};
|
|
|
|
struct mtk_vcodec_ctx;
|
|
struct mtk_vcodec_dev;
|
|
|
|
#undef pr_fmt
|
|
#define pr_fmt(fmt) "%s(),%d: " fmt, __func__, __LINE__
|
|
|
|
#define mtk_v4l2_err(fmt, args...) \
|
|
pr_err("[MTK_V4L2][ERROR] " fmt "\n", ##args)
|
|
|
|
#define mtk_vcodec_err(h, fmt, args...) \
|
|
pr_err("[MTK_VCODEC][ERROR][%d]: " fmt "\n", \
|
|
((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args)
|
|
|
|
|
|
#define mtk_v4l2_debug(level, fmt, args...) pr_debug(fmt, ##args)
|
|
|
|
#define mtk_v4l2_debug_enter() mtk_v4l2_debug(3, "+")
|
|
#define mtk_v4l2_debug_leave() mtk_v4l2_debug(3, "-")
|
|
|
|
#define mtk_vcodec_debug(h, fmt, args...) \
|
|
pr_debug("[MTK_VCODEC][%d]: " fmt "\n", \
|
|
((struct mtk_vcodec_ctx *)(h)->ctx)->id, ##args)
|
|
|
|
#define mtk_vcodec_debug_enter(h) mtk_vcodec_debug(h, "+")
|
|
#define mtk_vcodec_debug_leave(h) mtk_vcodec_debug(h, "-")
|
|
|
|
void __iomem *mtk_vcodec_get_reg_addr(struct mtk_vcodec_ctx *data,
|
|
unsigned int reg_idx);
|
|
int mtk_vcodec_mem_alloc(struct mtk_vcodec_ctx *data,
|
|
struct mtk_vcodec_mem *mem);
|
|
void mtk_vcodec_mem_free(struct mtk_vcodec_ctx *data,
|
|
struct mtk_vcodec_mem *mem);
|
|
void mtk_vcodec_set_curr_ctx(struct mtk_vcodec_dev *dev,
|
|
struct mtk_vcodec_ctx *ctx);
|
|
struct mtk_vcodec_ctx *mtk_vcodec_get_curr_ctx(struct mtk_vcodec_dev *dev);
|
|
|
|
#endif /* _MTK_VCODEC_UTIL_H_ */
|