Paul E. McKenney
87834546ea
mm/mmap.c: Add cond_resched() for exit_mmap() CPU stalls
...
[ Upstream commit 0a3b3c253a1eb2c7fe7f34086d46660c909abeb3 ]
A large process running on a heavily loaded system can encounter the
following RCU CPU stall warning:
rcu: INFO: rcu_sched self-detected stall on CPU
rcu: 3-....: (20998 ticks this GP) idle=4ea/1/0x4000000000000002 softirq=556558/556558 fqs=5190
(t=21013 jiffies g=1005461 q=132576)
NMI backtrace for cpu 3
CPU: 3 PID: 501900 Comm: aio-free-ring-w Kdump: loaded Not tainted 5.2.9-108_fbk12_rc3_3858_gb83b75af7909 #1
Hardware name: Wiwynn HoneyBadger/PantherPlus, BIOS HBM6.71 02/03/2016
Call Trace:
<IRQ>
dump_stack+0x46/0x60
nmi_cpu_backtrace.cold.3+0x13/0x50
? lapic_can_unplug_cpu.cold.27+0x34/0x34
nmi_trigger_cpumask_backtrace+0xba/0xca
rcu_dump_cpu_stacks+0x99/0xc7
rcu_sched_clock_irq.cold.87+0x1aa/0x397
? tick_sched_do_timer+0x60/0x60
update_process_times+0x28/0x60
tick_sched_timer+0x37/0x70
__hrtimer_run_queues+0xfe/0x270
hrtimer_interrupt+0xf4/0x210
smp_apic_timer_interrupt+0x5e/0x120
apic_timer_interrupt+0xf/0x20
</IRQ>
RIP: 0010:kmem_cache_free+0x223/0x300
Code: 88 00 00 00 0f 85 ca 00 00 00 41 8b 55 18 31 f6 f7 da 41 f6 45 0a 02 40 0f 94 c6 83 c6 05 9c 41 5e fa e8 a0 a7 01 00 41 56 9d <49> 8b 47 08 a8 03 0f 85 87 00 00 00 65 48 ff 08 e9 3d fe ff ff 65
RSP: 0018:ffffc9000e8e3da8 EFLAGS: 00000206 ORIG_RAX: ffffffffffffff13
RAX: 0000000000020000 RBX: ffff88861b9de960 RCX: 0000000000000030
RDX: fffffffffffe41e8 RSI: 000060777fe3a100 RDI: 000000000001be18
RBP: ffffea00186e7780 R08: ffffffffffffffff R09: ffffffffffffffff
R10: ffff88861b9dea28 R11: ffff88887ffde000 R12: ffffffff81230a1f
R13: ffff888854684dc0 R14: 0000000000000206 R15: ffff8888547dbc00
? remove_vma+0x4f/0x60
remove_vma+0x4f/0x60
exit_mmap+0xd6/0x160
mmput+0x4a/0x110
do_exit+0x278/0xae0
? syscall_trace_enter+0x1d3/0x2b0
? handle_mm_fault+0xaa/0x1c0
do_group_exit+0x3a/0xa0
__x64_sys_exit_group+0x14/0x20
do_syscall_64+0x42/0x100
entry_SYSCALL_64_after_hwframe+0x44/0xa9
And on a PREEMPT=n kernel, the "while (vma)" loop in exit_mmap() can run
for a very long time given a large process. This commit therefore adds
a cond_resched() to this loop, providing RCU any needed quiescent states.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>
Reviewed-by: Shakeel Butt <shakeelb@google.com>
Reviewed-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-08-19 08:16:02 +02:00
..
2020-05-27 17:46:48 +02:00
2020-05-14 07:58:30 +02:00
2019-09-04 07:42:01 -04:00
2019-07-12 12:24:03 -07:00
2019-05-14 09:47:45 -07:00
2019-07-16 19:23:21 -07:00
2020-07-09 09:37:57 +02:00
2020-03-05 16:43:51 +01:00
2019-07-12 11:05:46 -07:00
2017-12-11 14:54:44 +01:00
2019-08-30 22:43:58 -07:00
2019-07-12 11:05:43 -07:00
2020-08-05 09:59:41 +02:00
2019-09-25 17:51:41 -07:00
2019-06-19 17:09:52 +02:00
2020-01-09 10:20:00 +01:00
2020-06-17 16:40:30 +02:00
2018-12-28 12:11:47 -08:00
2019-09-07 04:28:04 -03:00
2020-06-22 09:31:14 +02:00
2019-11-15 18:34:00 -08:00
2020-04-29 16:33:14 +02:00
2019-06-03 15:39:40 +02:00
2019-10-19 06:32:32 -04:00
2020-01-09 10:19:55 +01:00
2019-06-19 17:09:08 +02:00
2019-09-24 15:54:11 -07:00
2019-09-24 15:54:08 -07:00
2020-07-29 10:18:44 +02:00
2019-06-05 17:37:06 +02:00
2019-10-14 08:56:16 -07:00
2020-04-29 16:33:15 +02:00
2019-07-12 11:05:44 -07:00
2020-01-17 19:48:40 +01:00
2020-03-25 08:25:57 +01:00
2019-09-24 15:54:10 -07:00
2019-10-19 06:32:32 -04:00
2020-07-29 10:18:43 +02:00
2019-09-24 15:54:08 -07:00
2020-03-12 13:00:19 +01:00
2019-10-19 06:32:31 -04:00
2020-01-09 10:19:55 +01:00
2020-04-08 09:08:47 +02:00
2019-03-05 21:07:20 -08:00
2020-01-09 10:19:56 +01:00
2020-02-11 04:35:13 -08:00
2019-09-25 17:51:41 -07:00
2019-09-25 17:51:41 -07:00
2019-05-21 10:50:45 +02:00
2020-08-19 08:16:02 +02:00
2020-02-11 04:35:42 -08:00
2019-11-06 08:47:50 -08:00
2020-03-12 13:00:19 +01:00
2020-06-07 13:18:46 +02:00
2019-09-25 17:51:41 -07:00
2020-03-25 08:25:58 +01:00
2020-01-09 10:19:57 +01:00
2020-06-22 09:31:14 +02:00
2018-06-07 17:34:36 -07:00
2019-10-14 15:04:00 -07:00
2019-06-29 16:43:45 +08:00
2019-11-15 18:34:00 -08:00
2019-07-12 11:05:43 -07:00
2019-10-19 06:32:31 -04:00
2019-09-24 15:54:08 -07:00
2019-09-24 15:54:08 -07:00
2020-01-23 08:22:41 +01:00
2019-09-07 04:28:04 -03:00
2019-03-13 12:25:31 -07:00
2019-06-05 17:37:16 +02:00
2019-06-05 17:37:16 +02:00
2019-06-05 17:37:16 +02:00
2019-09-04 13:40:49 -07:00
2018-10-09 16:51:11 +02:00
2019-05-30 11:26:32 -07:00
2019-05-21 10:50:45 +02:00
2019-10-19 06:32:32 -04:00
2019-06-05 17:37:17 +02:00
2020-05-20 08:20:03 +02:00
2019-10-07 15:47:19 -07:00
2019-05-14 19:52:48 -07:00
2020-07-29 10:18:44 +02:00
2020-01-23 08:22:40 +01:00
2019-11-06 08:47:50 -08:00
2019-10-07 15:47:20 -07:00
2020-07-09 09:37:50 +02:00
2019-07-18 17:08:07 -07:00
2020-04-01 11:02:03 +02:00
2018-08-22 10:52:44 -07:00
2020-07-09 09:37:49 +02:00
2019-09-25 17:51:41 -07:00
2020-04-01 11:02:02 +02:00
2019-10-19 06:32:33 -04:00
2019-09-17 15:20:17 -07:00
2019-06-19 17:09:53 +02:00
2020-06-17 16:40:23 +02:00
2018-09-13 15:18:04 -10:00
2020-04-29 16:33:14 +02:00
2019-10-07 15:47:19 -07:00
2020-02-28 17:22:20 +01:00
2019-11-06 08:47:50 -08:00
2019-08-13 16:06:52 -07:00
2019-10-07 15:47:19 -07:00
2019-05-21 10:50:45 +02:00
2019-09-24 15:54:12 -07:00
2020-01-09 10:19:56 +01:00
2019-09-24 15:54:12 -07:00