Tejun Heo 5c0338c687 workqueue: restore WQ_UNBOUND/max_active==1 to be ordered
The combination of WQ_UNBOUND and max_active == 1 used to imply
ordered execution.  After NUMA affinity 4c16bd327c74 ("workqueue:
implement NUMA affinity for unbound workqueues"), this is no longer
true due to per-node worker pools.

While the right way to create an ordered workqueue is
alloc_ordered_workqueue(), the documentation has been misleading for a
long time and people do use WQ_UNBOUND and max_active == 1 for ordered
workqueues which can lead to subtle bugs which are very difficult to
trigger.

It's unlikely that we'd see noticeable performance impact by enforcing
ordering on WQ_UNBOUND / max_active == 1 workqueues.  Let's
automatically set __WQ_ORDERED for those workqueues.

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Christoph Hellwig <hch@infradead.org>
Reported-by: Alexei Potashnik <alexei@purestorage.com>
Fixes: 4c16bd327c74 ("workqueue: implement NUMA affinity for unbound workqueues")
Cc: stable@vger.kernel.org # v3.10+
2017-07-19 11:24:19 -04:00
..
2017-05-12 15:57:15 -07:00
2017-07-13 13:17:19 -07:00
2017-05-23 10:01:37 +02:00
2017-06-12 18:07:43 -04:00
2017-01-12 07:01:56 -07:00
2017-05-18 10:30:19 -06:00
2017-05-08 17:15:12 -07:00
2017-07-14 15:05:13 -07:00
2017-07-12 17:22:01 -07:00
2017-07-06 16:24:33 -07:00
2016-12-22 22:58:37 -05:00
2017-07-12 09:15:00 -07:00