iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/ata
History
Niklas Cassel 5d92c7c566 ata: libata-core: Fix null pointer dereference on error 
If the ata_port_alloc() call in ata_host_alloc() fails,
ata_host_release() will get called.

However, the code in ata_host_release() tries to free ata_port struct
members unconditionally, which can lead to the following:

BUG: unable to handle page fault for address: 0000000000003990
PGD 0 P4D 0
Oops: Oops: 0000 [#1] PREEMPT SMP NOPTI
CPU: 10 PID: 594 Comm: (udev-worker) Not tainted 6.10.0-rc5 #44
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.16.3-2.fc40 04/01/2014
RIP: 0010:ata_host_release.cold+0x2f/0x6e [libata]
Code: e4 4d 63 f4 44 89 e2 48 c7 c6 90 ad 32 c0 48 c7 c7 d0 70 33 c0 49 83 c6 0e 41
RSP: 0018:ffffc90000ebb968 EFLAGS: 00010246
RAX: 0000000000000041 RBX: ffff88810fb52e78 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffff88813b3218c0 RDI: ffff88813b3218c0
RBP: ffff88810fb52e40 R08: 0000000000000000 R09: 6c65725f74736f68
R10: ffffc90000ebb738 R11: 73692033203a746e R12: 0000000000000004
R13: 0000000000000000 R14: 0000000000000011 R15: 0000000000000006
FS:  00007f6cc55b9980(0000) GS:ffff88813b300000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000003990 CR3: 00000001122a2000 CR4: 0000000000750ef0
PKRU: 55555554
Call Trace:
 <TASK>
 ? __die_body.cold+0x19/0x27
 ? page_fault_oops+0x15a/0x2f0
 ? exc_page_fault+0x7e/0x180
 ? asm_exc_page_fault+0x26/0x30
 ? ata_host_release.cold+0x2f/0x6e [libata]
 ? ata_host_release.cold+0x2f/0x6e [libata]
 release_nodes+0x35/0xb0
 devres_release_group+0x113/0x140
 ata_host_alloc+0xed/0x120 [libata]
 ata_host_alloc_pinfo+0x14/0xa0 [libata]
 ahci_init_one+0x6c9/0xd20 [ahci]

Do not access ata_port struct members unconditionally.

Fixes: 633273a3ed1c ("libata-pmp: hook PMP support and enable it")
Cc: stable@vger.kernel.org
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20240629124210.181537-7-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
2024-06-30 22:16:15 +02:00
..
pata_parport
ata: pata_parport: make pata_parport_bus_type const
2024-02-06 10:41:57 +01:00
acard-ahci.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
ahci_brcm.c
ata: libata: Make ata_platform_remove_one return void
2023-05-15 06:49:39 +09:00
ahci_ceva.c
ata: ahci_ceva: fix error handling for Xilinx GT PHY support
2024-02-19 10:44:37 +01:00
ahci_da850.c
ata: libata: Make ata_platform_remove_one return void
2023-05-15 06:49:39 +09:00
ahci_dm816.c
ata: libata: Make ata_platform_remove_one return void
2023-05-15 06:49:39 +09:00
ahci_dwc.c
ata: Explicitly include correct DT includes
2023-08-02 17:37:05 +09:00
ahci_imx.c
ata: imx: Use device_get_match_data()
2023-10-11 17:54:05 +09:00
ahci_mtk.c
ata: Explicitly include correct DT includes
2023-08-02 17:37:05 +09:00
ahci_mvebu.c
ata: Explicitly include correct DT includes
2023-08-02 17:37:05 +09:00
ahci_octeon.c
ata: ahci_octeon: Convert to devm_platform_ioremap_resource()
2023-08-02 17:37:06 +09:00
ahci_platform.c
driver core changes for 6.5-rc1
2023-07-03 12:56:23 -07:00
ahci_qoriq.c
ata: fix debounce timings type
2023-08-02 17:37:06 +09:00
ahci_seattle.c
ata: ahci_seattle: Convert to devm_platform_ioremap_resource()
2023-08-02 17:37:06 +09:00
ahci_st.c
ata: ahci_st: Remove an unused field in struct st_ahci_drv_data
2024-04-02 12:18:15 +09:00
ahci_sunxi.c
ata: Explicitly include correct DT includes
2023-08-02 17:37:05 +09:00
ahci_tegra.c
ata: ahci_tegra: Convert to devm_platform_ioremap_resource()
2023-08-02 17:37:06 +09:00
ahci_xgene.c
ata: xgene: Use of_device_get_match_data()
2023-10-11 17:53:37 +09:00
ahci.c
ata: ahci: Do not enable LPM if no LPM states are supported by the HBA
2024-06-19 13:19:38 +02:00
ahci.h
scsi: libata: Switch to using ->device_configure
2024-04-11 21:37:50 -04:00
ata_generic.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
ata_piix.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
Kconfig
ata: add HAS_IOPORT dependencies
2024-04-08 10:07:28 +09:00
libahci_platform.c
ata: Explicitly include correct DT includes
2023-08-02 17:37:05 +09:00
libahci.c
ahci: print the number of implemented ports
2024-02-21 19:13:43 +01:00
libata-acpi.c
ata: make use of ata_port_is_frozen() helper
2022-10-18 13:53:27 +09:00
libata-core.c
ata: libata-core: Fix null pointer dereference on error
2024-06-30 22:16:15 +02:00
libata-eh.c
scsi: sd: Fix TCG OPAL unlock on system resume
2024-03-25 15:46:12 -04:00
libata-pata-timings.c
ata: separate PATA timings code from libata-core.c
2020-03-26 10:28:19 -06:00
libata-pmp.c
ata: libata: add tracepoints for ATA error handling
2022-01-05 19:33:01 +09:00
libata-sata.c
scsi: libata: Switch to using ->device_configure
2024-04-11 21:37:50 -04:00
libata-scsi.c
ata: libata-scsi: Set the RMB bit only for removable media devices
2024-06-14 14:18:46 +02:00
libata-sff.c
ata: add HAS_IOPORT dependencies
2024-04-08 10:07:28 +09:00
libata-trace.c
ata: scsi: rename flag ATA_QCFLAG_FAILED to ATA_QCFLAG_EH
2023-01-04 13:36:26 +09:00
libata-transport.c
ata: libata-core: Do not register PM operations for SAS ports
2023-09-28 21:23:14 +09:00
libata-transport.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
libata-zpodd.c
libata: zpodd: Fix small read overflow in zpodd_get_mech_type()
2019-07-29 16:00:14 -06:00
libata.h
SCSI misc on 20240514
2024-05-14 18:25:53 -07:00
Makefile
ATA changes for 6.3-rc1
2023-02-22 13:35:51 -08:00
pata_acpi.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ali.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_amd.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_arasan_cf.c
ata: pata_arasan_cf: Convert to platform remove callback returning void
2023-08-02 17:53:09 +09:00
pata_artop.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_atiixp.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_atp867x.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_buddha.c
ata: pata_buddha: Remove #include <asm/ide.h>
2023-08-24 08:09:59 +09:00
pata_cmd64x.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cmd640.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cs5520.c
ata: pata_cs5520: Remove unnecessary call to pci_enable_device_io()
2024-05-16 14:35:08 -05:00
pata_cs5530.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cs5535.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cs5536.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_cypress.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_efar.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ep93xx.c
ata: pata_ep93xx: use soc_device_match for UDMA modes
2023-08-25 22:09:43 +09:00
pata_falcon.c
ata: pata_falcon: Convert to platform remove callback returning void
2023-11-08 09:00:44 +09:00
pata_ftide010.c
ata: pata_ftide010: Add missing MODULE_DESCRIPTION
2023-08-25 08:21:03 +09:00
pata_gayle.c
ata: pata_gayle: Convert to platform remove callback returning void
2023-11-08 09:00:49 +09:00
pata_hpt3x2n.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_hpt3x3.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_hpt37x.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_hpt366.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_icside.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_imx.c
ata: pata_imx: Use helper function devm_clk_get_enabled()
2023-08-17 07:45:32 +09:00
pata_isapnp.c
ata: pata_isapnp: Add missing error check for devm_ioport_map()
2023-11-20 09:22:26 +09:00
pata_it821x.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_it8213.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ixp4xx_cf.c
ata: pata_ixp4xx: Remove unnecessary return value check
2023-08-02 17:37:06 +09:00
pata_jmicron.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_legacy.c
ata: pata_legacy: make legacy_exit() work again
2024-05-07 07:23:31 +09:00
pata_macio.c
ata: pata_macio: Fix max_segment_size with PAGE_SIZE == 64K
2024-06-06 14:53:34 +02:00
pata_marvell.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_mpc52xx.c
ata: pata_mpc52xx: Convert to platform remove callback returning void
2023-08-02 17:55:49 +09:00
pata_mpiix.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_netcell.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ninja32.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ns87410.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_ns87415.c
ata: pata_ns87415: mark ns87560_tf_read static
2023-07-28 08:52:42 +09:00
pata_octeon_cf.c
ata: pata_octeon_cf: fix error return code in octeon_cf_probe()
2023-07-26 08:32:21 +09:00
pata_of_platform.c
ata: libata: Make ata_platform_remove_one return void
2023-05-15 06:49:39 +09:00
pata_oldpiix.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_opti.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_optidma.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_pcmcia.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_pdc202xx_old.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_pdc2027x.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_piccolo.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_platform.c
ata: libata: Make ata_platform_remove_one return void
2023-05-15 06:49:39 +09:00
pata_pxa.c
ata: pata_pxa: convert not to use dma_request_slave_channel()
2023-11-20 09:28:25 +09:00
pata_radisys.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_rb532_cf.c
ata: pata_rb532_cf: Convert to platform remove callback returning void
2023-08-02 17:55:52 +09:00
pata_rdc.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_rz1000.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sc1200.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sch.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_serverworks.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sil680.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sis.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_sl82c105.c
ata: libata: remove deprecated EH callbacks
2023-08-02 17:45:42 +09:00
pata_triflex.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pata_via.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
pdc_adma.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sata_dwc_460ex.c
ata: sata_dwc_460ex: Convert to platform remove callback returning void
2023-08-02 17:55:52 +09:00
sata_fsl.c
ata: sata_fsl: Convert to platform remove callback returning void
2023-08-02 17:55:52 +09:00
sata_gemini.c
ata: sata_gemini: Check clk_enable() result
2024-04-04 12:42:00 +09:00
sata_gemini.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
sata_highbank.c
ata: fix debounce timings type
2023-08-02 17:37:06 +09:00
sata_inic162x.c
ata: fix debounce timings type
2023-08-02 17:37:06 +09:00
sata_mv.c
SCSI misc on 20240514
2024-05-14 18:25:53 -07:00
sata_nv.c
scsi: libata: Switch to using ->device_configure
2024-04-11 21:37:50 -04:00
sata_promise.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sata_promise.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18
2019-05-21 11:28:46 +02:00
sata_qstor.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sata_rcar.c
ata: sata_rcar: Convert to platform remove callback returning void
2023-08-02 17:55:52 +09:00
sata_sil24.c
scsi: libata: Switch to using ->device_configure
2024-04-11 21:37:50 -04:00
sata_sil.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sata_sis.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sata_svw.c
ata: Use of_property_read_reg() to parse "reg"
2023-06-13 15:38:48 +09:00
sata_sx4.c
ata: sata_sx4: fix pdc20621_get_from_dimm() on 64-bit
2024-04-01 07:52:17 +09:00
sata_uli.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sata_via.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sata_vsc.c
scsi: ata: Declare SCSI host templates const
2023-03-24 19:19:19 -04:00
sis.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00