Shunsuke Mie
8e30538eca
misc: pci_endpoint_test: Fix pci_endpoint_test_{copy,write,read}() panic ...
The dma_map_single() doesn't permit zero length mapping. It causes a follow
panic.
A panic was reported on arm64:
[ 60.137988] ------------[ cut here ]------------
[ 60.142630] kernel BUG at kernel/dma/swiotlb.c:624!
[ 60.147508] Internal error: Oops - BUG: 0 [#1 ] PREEMPT SMP
[ 60.152992] Modules linked in: dw_hdmi_cec crct10dif_ce simple_bridge rcar_fdp1 vsp1 rcar_vin videobuf2_vmalloc rcar_csi2 v4l
2_mem2mem videobuf2_dma_contig videobuf2_memops pci_endpoint_test videobuf2_v4l2 videobuf2_common rcar_fcp v4l2_fwnode v4l2_asyn
c videodev mc gpio_bd9571mwv max9611 pwm_rcar ccree at24 authenc libdes phy_rcar_gen3_usb3 usb_dmac display_connector pwm_bl
[ 60.186252] CPU: 0 PID: 508 Comm: pcitest Not tainted 6.0.0-rc1rpci-dev+ #237
[ 60.193387] Hardware name: Renesas Salvator-X 2nd version board based on r8a77951 (DT)
[ 60.201302] pstate: 00000005 (nzcv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 60.208263] pc : swiotlb_tbl_map_single+0x2c0/0x590
[ 60.213149] lr : swiotlb_map+0x88/0x1f0
[ 60.216982] sp : ffff80000a883bc0
[ 60.220292] x29: ffff80000a883bc0 x28: 0000000000000000 x27: 0000000000000000
[ 60.227430] x26: 0000000000000000 x25: ffff0004c0da20d0 x24: ffff80000a1f77c0
[ 60.234567] x23: 0000000000000002 x22: 0001000040000010 x21: 000000007a000000
[ 60.241703] x20: 0000000000200000 x19: 0000000000000000 x18: 0000000000000000
[ 60.248840] x17: 0000000000000000 x16: 0000000000000000 x15: ffff0006ff7b9180
[ 60.255977] x14: ffff0006ff7b9180 x13: 0000000000000000 x12: 0000000000000000
[ 60.263113] x11: 0000000000000000 x10: 0000000000000000 x9 : 0000000000000000
[ 60.270249] x8 : 0001000000000010 x7 : ffff0004c6754b20 x6 : 0000000000000000
[ 60.277385] x5 : ffff0004c0da2090 x4 : 0000000000000000 x3 : 0000000000000001
[ 60.284521] x2 : 0000000040000000 x1 : 0000000000000000 x0 : 0000000040000010
[ 60.291658] Call trace:
[ 60.294100] swiotlb_tbl_map_single+0x2c0/0x590
[ 60.298629] swiotlb_map+0x88/0x1f0
[ 60.302115] dma_map_page_attrs+0x188/0x230
[ 60.306299] pci_endpoint_test_ioctl+0x5e4/0xd90 [pci_endpoint_test]
[ 60.312660] __arm64_sys_ioctl+0xa8/0xf0
[ 60.316583] invoke_syscall+0x44/0x108
[ 60.320334] el0_svc_common.constprop.0+0xcc/0xf0
[ 60.325038] do_el0_svc+0x2c/0xb8
[ 60.328351] el0_svc+0x2c/0x88
[ 60.331406] el0t_64_sync_handler+0xb8/0xc0
[ 60.335587] el0t_64_sync+0x18c/0x190
[ 60.339251] Code: 52800013 d2e00414 35fff45c d503201f (d4210000)
[ 60.345344] ---[ end trace 0000000000000000 ]---
To fix it, this patch adds a checking the payload length if it is zero.
Fixes: 343dc693f7b7 ("misc: pci_endpoint_test: Prevent some integer overflows")
Cc: stable <stable@kernel.org>
Signed-off-by: Shunsuke Mie <mie@igel.co.jp>
Link: https://lore.kernel.org/r/20220907020100.122588-2-mie@igel.co.jp
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-09-09 10:24:12 +02:00
2022-09-01 16:29:42 +02:00
2022-09-01 16:29:32 +02:00
2020-11-03 10:12:10 +01:00
2022-07-11 08:32:58 +02:00
2021-10-05 15:50:05 +02:00
2022-07-14 16:53:52 +02:00
2020-07-23 09:44:15 +02:00
2022-09-01 16:29:42 +02:00
2021-09-27 15:39:40 +02:00
2022-07-12 09:09:31 +03:00
2021-07-05 13:42:16 -07:00
2022-02-09 13:00:45 +00:00
2022-08-04 11:05:48 -07:00
2022-09-09 10:03:13 +02:00
2022-09-01 16:29:42 +02:00
2022-09-01 16:29:50 +02:00
2022-04-29 16:54:59 +02:00
2022-06-27 16:15:17 +02:00
2022-07-08 15:41:39 +02:00
2021-05-13 17:03:20 +02:00
2022-07-01 10:35:08 +02:00
2022-09-09 10:22:32 +02:00
2021-10-13 14:35:37 +02:00
2022-02-09 13:00:45 +00:00
2021-10-13 14:35:37 +02:00
2021-10-13 14:35:37 +02:00
2022-08-03 11:03:03 +02:00
2021-04-05 13:15:52 +02:00
2021-10-22 11:25:39 +02:00
2022-09-05 07:53:56 +02:00
2021-10-05 15:47:18 +02:00
2022-03-02 22:28:50 +01:00
2021-09-14 10:57:31 +02:00
2021-06-04 15:28:23 +02:00
2021-06-04 15:28:23 +02:00
2021-03-02 22:41:23 +11:00
2022-09-01 16:29:42 +02:00
2020-12-09 19:35:34 +01:00
2022-09-02 14:49:05 +02:00
2022-03-18 14:17:56 +01:00
2022-02-09 13:00:45 +00:00
2022-09-02 14:49:05 +02:00
2022-02-04 16:45:39 +01:00
2020-07-01 15:05:37 +02:00
2022-09-09 10:24:12 +02:00
2020-06-29 18:43:42 +02:00
2022-06-10 14:51:36 +02:00
2021-12-08 15:16:05 +01:00
2021-08-05 14:27:46 +02:00
2021-09-21 17:33:31 +02:00
2021-09-21 17:33:31 +02:00
2022-07-14 16:54:17 +02:00
2022-08-05 16:32:45 -07:00
2022-09-09 10:22:36 +02:00
8e30538eca