Steven Rostedt (Google)
60e092289c
tracing: Inform kmemleak of saved_cmdlines allocation ...
commit 2394ac4145ea91b92271e675a09af2a9ea6840b7 upstream.
The allocation of the struct saved_cmdlines_buffer structure changed from:
s = kmalloc(sizeof(*s), GFP_KERNEL);
s->saved_cmdlines = kmalloc_array(TASK_COMM_LEN, val, GFP_KERNEL);
to:
orig_size = sizeof(*s) + val * TASK_COMM_LEN;
order = get_order(orig_size);
size = 1 << (order + PAGE_SHIFT);
page = alloc_pages(GFP_KERNEL, order);
if (!page)
return NULL;
s = page_address(page);
memset(s, 0, sizeof(*s));
s->saved_cmdlines = kmalloc_array(TASK_COMM_LEN, val, GFP_KERNEL);
Where that s->saved_cmdlines allocation looks to be a dangling allocation
to kmemleak. That's because kmemleak only keeps track of kmalloc()
allocations. For allocations that use page_alloc() directly, the kmemleak
needs to be explicitly informed about it.
Add kmemleak_alloc() and kmemleak_free() around the page allocation so
that it doesn't give the following false positive:
unreferenced object 0xffff8881010c8000 (size 32760):
comm "swapper", pid 0, jiffies 4294667296
hex dump (first 32 bytes):
ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ................
backtrace (crc ae6ec1b9):
[<ffffffff86722405>] kmemleak_alloc+0x45/0x80
[<ffffffff8414028d>] __kmalloc_large_node+0x10d/0x190
[<ffffffff84146ab1>] __kmalloc+0x3b1/0x4c0
[<ffffffff83ed7103>] allocate_cmdlines_buffer+0x113/0x230
[<ffffffff88649c34>] tracer_alloc_buffers.isra.0+0x124/0x460
[<ffffffff8864a174>] early_trace_init+0x14/0xa0
[<ffffffff885dd5ae>] start_kernel+0x12e/0x3c0
[<ffffffff885f5758>] x86_64_start_reservations+0x18/0x30
[<ffffffff885f582b>] x86_64_start_kernel+0x7b/0x80
[<ffffffff83a001c3>] secondary_startup_64_no_verify+0x15e/0x16b
Link: https://lore.kernel.org/linux-trace-kernel/87r0hfnr9r.fsf@kernel.org/
Link: https://lore.kernel.org/linux-trace-kernel/20240214112046.09a322d6@gandalf.local.home
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Fixes: 44dc5c41b5b1 ("tracing: Fix wasted memory in saved_cmdlines logic")
Reported-by: Kalle Valo <kvalo@kernel.org>
Tested-by: Kalle Valo <kvalo@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-02-23 08:25:13 +01:00
2024-02-23 08:24:57 +01:00
2023-10-25 11:53:19 +02:00
2024-01-25 14:34:32 -08:00
2024-01-25 14:34:25 -08:00
2024-02-23 08:25:03 +01:00
2023-01-18 11:41:42 +01:00
2023-11-28 16:50:18 +00:00
2022-10-26 13:22:18 +02:00
2023-11-28 16:50:13 +00:00
2024-02-23 08:24:48 +01:00
2022-04-15 14:18:08 +02:00
2023-03-11 16:43:54 +01:00
2023-07-27 08:37:42 +02:00
2024-02-23 08:25:08 +01:00
2024-02-23 08:25:13 +01:00
2021-05-11 14:04:16 +02:00
2023-01-18 11:41:34 +01:00
2023-06-09 10:29:01 +02:00
2022-09-05 10:27:38 +02:00
2021-09-03 10:08:16 +02:00
2023-11-28 16:50:18 +00:00
2024-02-23 08:24:54 +01:00
2022-04-15 14:18:04 +02:00
2020-06-22 09:30:59 +02:00
2023-09-23 10:59:46 +02:00
2023-04-20 12:07:32 +02:00
2023-04-05 11:16:42 +02:00
2019-07-30 18:34:15 +02:00
2020-06-22 09:31:22 +02:00
2023-12-13 18:18:09 +01:00
2023-12-20 15:41:18 +01:00
2023-06-09 10:29:01 +02:00
2023-06-09 10:29:01 +02:00
2023-03-11 16:44:15 +01:00
2023-09-23 11:00:03 +02:00
2019-10-06 09:11:37 -06:00
2023-06-09 10:29:01 +02:00
2020-09-03 11:27:10 +02:00
2019-08-29 15:10:10 +01:00
2020-07-16 08:16:44 +02:00
2021-01-09 13:44:55 +01:00
2019-07-22 18:05:11 +02:00
2023-07-27 08:37:10 +02:00
2019-09-06 23:58:44 +02:00
2023-06-21 15:44:10 +02:00
2019-08-19 21:54:15 -07:00
2023-05-17 11:35:33 +02:00
2020-04-17 10:50:22 +02:00
2023-03-11 16:44:02 +01:00
2021-09-12 08:56:39 +02:00
2021-05-11 14:04:16 +02:00
2021-04-07 14:47:38 +02:00
2021-04-07 14:47:38 +02:00
2023-09-23 10:59:36 +02:00
2020-10-01 13:17:23 +02:00
2023-11-28 16:50:14 +00:00
2023-02-06 07:52:50 +01:00
2019-08-19 21:54:16 -07:00
2021-09-22 12:26:37 +02:00
2019-07-16 19:23:24 -07:00
2022-08-25 11:18:02 +02:00
2022-06-14 18:11:24 +02:00
2023-11-28 16:50:19 +00:00
2023-05-17 11:35:58 +02:00
2020-06-24 17:50:35 +02:00
2022-02-16 12:52:53 +01:00
2022-07-21 20:59:27 +02:00
2022-04-20 09:19:39 +02:00
2021-02-07 15:35:49 +01:00
2019-11-04 21:19:25 +01:00
2019-10-17 12:47:12 +02:00
2022-09-05 10:27:38 +02:00
2023-01-24 07:17:59 +01:00
2020-10-01 13:17:10 +02:00
2023-08-30 16:27:26 +02:00
2020-01-09 10:19:54 +01:00
2019-08-01 14:30:22 -07:00
2021-07-14 16:53:08 +02:00
2022-02-23 11:59:57 +01:00
2019-07-18 17:08:07 -07:00
2020-10-14 10:32:58 +02:00
2021-05-14 09:44:33 +02:00
2023-07-27 08:37:10 +02:00
2022-08-25 11:18:37 +02:00
2023-10-25 11:53:18 +02:00
60e092289c