Jakub Kicinski 6b486676b4 net: tls: set MSG_SPLICE_PAGES consistently ... We used to change the flags for the last segment, because non-last segments had the MSG_SENDPAGE_NOTLAST flag set. That flag is no longer a thing so remove the setting. Since flags most likely don't have MSG_SPLICE_PAGES set this avoids passing parts of the sg as splice and parts as non-splice. Before commit under Fixes we'd have called tcp_sendpage() which would add the MSG_SPLICE_PAGES. Why this leads to trouble remains unclear but Tariq reports hitting the WARN_ON(!sendpage_ok()) due to page refcount of 0. Fixes: e117dcfd64 ("tls: Inline do_tcp_sendpages()") Reported-by: Tariq Toukan <tariqt@nvidia.com> Link: https://lore.kernel.org/all/4c49176f-147a-4283-f1b1-32aac7b4b996@gmail.com/ Tested-by: Tariq Toukan <tariqt@nvidia.com> Link: https://lore.kernel.org/r/20230808180917.1243540-1-kuba@kernel.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-08-10 11:36:57 -07:00
..
Kconfig	net/tls: Select SOCK_RX_QUEUE_MAPPING from TLS_DEVICE	2021-02-11 19:08:06 -08:00
Makefile	tls: rx: async: hold onto the input skb	2022-07-18 11:24:11 +01:00
tls_device_fallback.c	net/tls: fix comment typo	2023-06-22 19:38:46 -07:00
tls_device.c	net: tls: avoid discarding data on record close	2023-08-06 08:32:18 +01:00
tls_main.c	net: tls: set MSG_SPLICE_PAGES consistently	2023-08-10 11:36:57 -07:00
tls_proc.c	tls: rx: add counter for NoPad violations	2022-07-11 19:48:33 -07:00
tls_strp.c	tls: improve lockless access safety of tls_err_abort()	2023-05-26 10:35:58 +01:00
tls_sw.c	net: Kill MSG_SENDPAGE_NOTLAST	2023-06-24 15:50:13 -07:00
tls_toe.c	tls: create an internal header	2022-07-08 18:38:45 -07:00
tls.h	sock: Remove ->sendpage*() in favour of sendmsg(MSG_SPLICE_PAGES)	2023-06-24 15:50:13 -07:00
trace.c	net/tls: add tracing for device/offload events	2019-10-05 16:29:00 -07:00
trace.h	net/tls: add device decrypted trace point	2019-10-05 16:29:00 -07:00