Martin Schiller c4efc61423 net/x25: fix nonblocking connect ...

commit e21dba7a4df4d93da237da65a096084b4f2e87b4 upstream.

This patch fixes 2 issues in x25_connect():

1. It makes absolutely no sense to reset the neighbour and the
connection state after a (successful) nonblocking call of x25_connect.
This prevents any connection from being established, since the response
(call accept) cannot be processed.

2. Any further calls to x25_connect() while a call is pending should
simply return, instead of creating new Call Request (on different
logical channels).

This patch should also fix the "KASAN: null-ptr-deref Write in
x25_connect" and "BUG: unable to handle kernel NULL pointer dereference
in x25_connect" bugs reported by syzbot.

Signed-off-by: Martin Schiller <ms@dev.tdt.de>
Reported-by: syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com
Reported-by: syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2020-01-29 10:24:41 +01:00

..

af_x25.c

net/x25: fix nonblocking connect

2020-01-29 10:24:41 +01:00

Kconfig

net: x25: Fix dead URLs in Kconfig

2013-10-29 17:35:17 -04:00

Makefile

…

sysctl_net_x25.c

net: x25: fix one potential use-after-free issue

2018-04-13 19:48:00 +02:00

x25_dev.c

x25: convert printks to pr_<level>

2013-12-09 20:24:18 -05:00

x25_facilities.c

net: fix a kernel infoleak in x25 module

2016-05-09 22:45:33 -04:00

x25_forward.c

x25: convert printks to pr_<level>

2013-12-09 20:24:18 -05:00

x25_in.c

net: Fix use after free by removing length arg from sk_data_ready callbacks.

2014-04-11 16:15:36 -04:00

x25_link.c

x25: convert printks to pr_<level>

2013-12-09 20:24:18 -05:00

x25_out.c

x25: remove the BKL

2011-03-05 10:55:45 +01:00

x25_proc.c

x25: use proc_remove_subtree()

2013-04-09 14:13:35 -04:00

x25_route.c

net: Fix (nearly-)kernel-doc comments for various functions

2012-07-10 23:13:45 -07:00

x25_subr.c

x25: convert printks to pr_<level>

2013-12-09 20:24:18 -05:00

x25_timer.c

…