iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5ef7e0ba10
linux/sound/soc/atmel
History
Alexandre Belloni 0f0be40ba5
ASoC: atmel-classd: select correct Kconfig symbol 
SND_ATMEL_SOC_CLASSD selects SND_ATMEL_SOC_DMA but the driver itself
handles its own DMA operations and doesn't need anything from
atmel-pcm-dma.c or atmel_ssc_dai.c.

Replace SND_ATMEL_SOC_DMA by SND_SOC_GENERIC_DMAENGINE_PCM which is the
only one actually required.

This may end up in a configuration leading to a link error:

sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_set_audio':
atmel_ssc_dai.c:(.text+0x79c): undefined reference to `atmel_pcm_dma_platform_register'
atmel_ssc_dai.c:(.text+0x79c): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_register'
sound/soc/atmel/atmel_ssc_dai.o: In function `atmel_ssc_put_audio':
atmel_ssc_dai.c:(.text+0xf24): undefined reference to `atmel_pcm_dma_platform_unregister'
atmel_ssc_dai.c:(.text+0xf24): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `atmel_pcm_dma_platform_unregister'

Tested on sama5d2 xplained with the following configuration
where nothing selects SND_ATMEL_SOC_DMA:

CONFIG_SND_ATMEL_SOC=y
CONFIG_SND_ATMEL_SOC_CLASSD=y

Reported-by: Arnd Bergmann <arnd@arndb.de>
Tested-by: Arnd Bergmann <arnd@arndb.de>
Fixes: e0a25b6d18 ("ASoC: atmel-classd: add the Audio Class D Amplifier")
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
2017-12-08 18:48:45 +00:00
..
atmel_ssc_dai.c ASoC: atmel_ssc_dai: if not provided, default to sensible dividers 2016-11-16 11:02:31 +00:00
atmel_ssc_dai.h ASoC: atmel_ssc_dai: if not provided, default to sensible dividers 2016-11-16 11:02:31 +00:00
atmel_wm8904.c ASoC: atmel_wm8904: constify snd_soc_ops structures 2016-10-24 18:32:54 +01:00
atmel-classd.c The diff is dominated by the Allwinner A10/A20 SoCs getting converted to 2017-09-13 11:04:14 -07:00
atmel-classd.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
atmel-pcm-dma.c ASoC: dmaengine_pcm: Make FLAG_NO_RESIDUE internal 2015-04-27 19:26:07 +01:00
atmel-pcm-pdc.c ASoC: constify snd_pcm_ops structures 2016-09-12 20:04:09 +01:00
atmel-pcm.h ASoC: atmel: Use IS_ENABLED() 2017-05-17 10:44:29 +01:00
atmel-pdmic.c ASoC: atmel: Remove unnecessary function call 2017-08-21 17:12:19 +01:00
atmel-pdmic.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
Kconfig ASoC: atmel-classd: select correct Kconfig symbol 2017-12-08 18:48:45 +00:00
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
sam9g20_wm8731.c ASoC: at91sam9g20ek: Automatically disconnect non-connected pins 2015-04-27 15:39:23 +01:00
sam9x5_wm8731.c ASoC: atmel: drop owner assignment from platform_drivers 2014-10-20 16:22:03 +02:00
tse850-pcm5142.c ASoC: atmel: tse850: fix off-by-one in the "ANA" enumeration count 2017-06-06 19:53:36 +01:00