YueHaibing
cf254b4f68
can: bcm: Fix UAF in bcm_proc_show() ...
commit 55c3b96074f3f9b0aee19bf93cd71af7516582bb upstream.
BUG: KASAN: slab-use-after-free in bcm_proc_show+0x969/0xa80
Read of size 8 at addr ffff888155846230 by task cat/7862
CPU: 1 PID: 7862 Comm: cat Not tainted 6.5.0-rc1-00153-gc8746099c197 #230
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.15.0-1 04/01/2014
Call Trace:
<TASK>
dump_stack_lvl+0xd5/0x150
print_report+0xc1/0x5e0
kasan_report+0xba/0xf0
bcm_proc_show+0x969/0xa80
seq_read_iter+0x4f6/0x1260
seq_read+0x165/0x210
proc_reg_read+0x227/0x300
vfs_read+0x1d5/0x8d0
ksys_read+0x11e/0x240
do_syscall_64+0x35/0xb0
entry_SYSCALL_64_after_hwframe+0x63/0xcd
Allocated by task 7846:
kasan_save_stack+0x1e/0x40
kasan_set_track+0x21/0x30
__kasan_kmalloc+0x9e/0xa0
bcm_sendmsg+0x264b/0x44e0
sock_sendmsg+0xda/0x180
____sys_sendmsg+0x735/0x920
___sys_sendmsg+0x11d/0x1b0
__sys_sendmsg+0xfa/0x1d0
do_syscall_64+0x35/0xb0
entry_SYSCALL_64_after_hwframe+0x63/0xcd
Freed by task 7846:
kasan_save_stack+0x1e/0x40
kasan_set_track+0x21/0x30
kasan_save_free_info+0x27/0x40
____kasan_slab_free+0x161/0x1c0
slab_free_freelist_hook+0x119/0x220
__kmem_cache_free+0xb4/0x2e0
rcu_core+0x809/0x1bd0
bcm_op is freed before procfs entry be removed in bcm_release(),
this lead to bcm_proc_show() may read the freed bcm_op.
Fixes: ffd980f976e7 ("[CAN]: Add broadcast manager (bcm) protocol")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Oliver Hartkopp <socketcan@hartkopp.net>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Link: https://lore.kernel.org/all/20230715092543.15548-1-yuehaibing@huawei.com
Cc: stable@vger.kernel.org
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-07-27 08:44:35 +02:00
2021-09-15 09:50:34 +02:00
2023-04-20 12:10:25 +02:00
2023-01-14 10:16:18 +01:00
2023-05-30 12:57:53 +01:00
2021-04-07 15:00:08 +02:00
2023-06-09 10:30:12 +02:00
2022-06-22 14:13:17 +02:00
2023-06-21 15:45:40 +02:00
2023-06-14 11:09:52 +02:00
2023-01-14 10:15:31 +01:00
2021-07-14 16:56:29 +02:00
2023-07-27 08:44:09 +02:00
2023-03-17 08:45:11 +01:00
2023-07-27 08:44:35 +02:00
2022-05-25 09:17:56 +02:00
2023-07-27 08:44:21 +02:00
2022-03-08 19:09:37 +01:00
2023-04-26 11:27:42 +02:00
2023-06-21 15:45:38 +02:00
2023-07-27 08:44:10 +02:00
2023-01-24 07:19:55 +01:00
2023-04-05 11:23:52 +02:00
2022-11-03 23:57:51 +09:00
2023-07-27 08:44:09 +02:00
2023-07-27 08:44:22 +02:00
2023-03-22 13:30:00 +01:00
2022-11-25 17:45:56 +01:00
2023-05-30 12:57:51 +01:00
2023-04-26 11:27:41 +02:00
2022-04-27 13:53:50 +02:00
2021-02-10 09:29:14 +01:00
2023-05-30 12:57:46 +01:00
2023-05-30 12:57:53 +01:00
2022-12-14 11:32:01 +01:00
2023-02-22 12:55:58 +01:00
2023-04-26 11:27:41 +02:00
2023-05-17 11:48:10 +02:00
2023-07-27 08:44:17 +02:00
2022-04-13 21:01:00 +02:00
2023-07-27 08:43:43 +02:00
2023-06-09 10:30:05 +02:00
2023-07-27 08:43:43 +02:00
2023-05-30 12:57:52 +01:00
2023-02-22 12:55:57 +01:00
2023-06-09 10:30:05 +02:00
2022-01-11 15:25:01 +01:00
2021-03-07 12:34:07 +01:00
2023-04-20 12:10:26 +02:00
2023-03-11 16:39:26 +01:00
2023-02-22 12:55:53 +01:00
2023-05-17 11:48:11 +02:00
2023-07-27 08:44:33 +02:00
2023-07-27 08:44:08 +02:00
2023-06-14 11:09:39 +02:00
2021-11-18 14:04:27 +01:00
2023-07-27 08:44:02 +02:00
2021-02-07 15:37:12 +01:00
2023-06-21 15:45:40 +02:00
2023-05-30 12:57:46 +01:00
2023-05-30 12:57:46 +01:00
2023-05-30 12:57:52 +01:00
2023-07-27 08:43:41 +02:00
2023-02-15 17:22:15 +01:00
2023-07-27 08:44:09 +02:00
2023-06-28 10:28:10 +02:00
2021-06-18 10:00:06 +02:00
2023-06-21 15:45:38 +02:00
2023-06-21 15:45:38 +02:00
2023-07-27 08:43:37 +02:00
cf254b4f68