Taehee Yoo
60086c3773
net: openvswitch: do not free vport if register_netdevice() is failed. ...
[ Upstream commit 309b66970ee2abf721ecd0876a48940fa0b99a35 ]
In order to create an internal vport, internal_dev_create() is used and
that calls register_netdevice() internally.
If register_netdevice() fails, it calls dev->priv_destructor() to free
private data of netdev. actually, a private data of this is a vport.
Hence internal_dev_create() should not free and use a vport after failure
of register_netdevice().
Test command
ovs-dpctl add-dp bonding_masters
Splat looks like:
[ 1035.667767] kasan: GPF could be caused by NULL-ptr deref or user memory access
[ 1035.675958] general protection fault: 0000 [#1 ] SMP DEBUG_PAGEALLOC KASAN PTI
[ 1035.676916] CPU: 1 PID: 1028 Comm: ovs-vswitchd Tainted: G B 5.2.0-rc3+ #240
[ 1035.676916] RIP: 0010:internal_dev_create+0x2e5/0x4e0 [openvswitch]
[ 1035.676916] Code: 48 c1 ea 03 80 3c 02 00 0f 85 9f 01 00 00 4c 8b 23 48 b8 00 00 00 00 00 fc ff df 49 8d bc 24 60 05 00 00 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 86 01 00 00 49 8b bc 24 60 05 00 00 e8 e4 68 f4
[ 1035.713720] RSP: 0018:ffff88810dcb7578 EFLAGS: 00010206
[ 1035.713720] RAX: dffffc0000000000 RBX: ffff88810d13fe08 RCX: ffffffff84297704
[ 1035.713720] RDX: 00000000000000ac RSI: 0000000000000000 RDI: 0000000000000560
[ 1035.713720] RBP: 00000000ffffffef R08: fffffbfff0d3b881 R09: fffffbfff0d3b881
[ 1035.713720] R10: 0000000000000001 R11: fffffbfff0d3b880 R12: 0000000000000000
[ 1035.768776] R13: 0000607ee460b900 R14: ffff88810dcb7690 R15: ffff88810dcb7698
[ 1035.777709] FS: 00007f02095fc980(0000) GS:ffff88811b400000(0000) knlGS:0000000000000000
[ 1035.777709] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1035.777709] CR2: 00007ffdf01d2f28 CR3: 0000000108258000 CR4: 00000000001006e0
[ 1035.777709] Call Trace:
[ 1035.777709] ovs_vport_add+0x267/0x4f0 [openvswitch]
[ 1035.777709] new_vport+0x15/0x1e0 [openvswitch]
[ 1035.777709] ovs_vport_cmd_new+0x567/0xd10 [openvswitch]
[ 1035.777709] ? ovs_dp_cmd_dump+0x490/0x490 [openvswitch]
[ 1035.777709] ? __kmalloc+0x131/0x2e0
[ 1035.777709] ? genl_family_rcv_msg+0xa54/0x1030
[ 1035.777709] genl_family_rcv_msg+0x63a/0x1030
[ 1035.777709] ? genl_unregister_family+0x630/0x630
[ 1035.841681] ? debug_show_all_locks+0x2d0/0x2d0
[ ... ]
Fixes: cf124db566e6 ("net: Fix inconsistent teardown and release of private netdev state.")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-06-22 08:16:15 +02:00
2018-10-03 17:00:47 -07:00
2019-04-20 09:15:04 +02:00
2017-11-02 11:10:55 +01:00
2019-05-16 19:42:34 +02:00
2019-04-20 09:15:07 +02:00
2019-04-27 09:35:33 +02:00
2019-06-22 08:16:14 +02:00
2019-05-31 06:47:33 -07:00
2019-06-15 11:54:59 +02:00
2019-05-16 19:42:33 +02:00
2019-05-08 07:20:45 +02:00
2019-01-31 08:13:46 +01:00
2019-03-27 14:13:51 +09:00
2019-06-22 08:16:14 +02:00
2018-09-19 22:43:43 +02:00
2019-04-03 06:25:08 +02:00
2018-02-25 11:07:52 +01:00
2018-07-22 14:28:49 +02:00
2019-05-16 19:42:34 +02:00
2019-03-19 13:13:22 +01:00
2019-04-27 09:35:40 +02:00
2018-04-29 11:33:13 +02:00
2019-06-17 19:52:45 +02:00
2019-06-22 08:16:14 +02:00
2017-11-02 11:10:55 +01:00
2018-03-31 18:10:41 +02:00
2019-04-17 08:37:45 +02:00
2019-03-23 14:35:14 +01:00
2019-03-19 13:13:22 +01:00
2019-06-22 08:16:14 +02:00
2019-06-09 09:18:10 +02:00
2019-05-31 06:47:22 -07:00
2018-09-09 19:55:52 +02:00
2019-03-13 14:03:09 -07:00
2017-10-21 01:56:38 +01:00
2019-05-16 19:42:30 +02:00
2019-03-13 14:03:08 -07:00
2019-04-03 06:25:08 +02:00
2019-02-06 17:31:32 +01:00
2019-05-16 19:42:32 +02:00
2018-07-22 14:28:49 +02:00
2019-06-22 08:16:15 +02:00
2019-05-16 19:42:34 +02:00
2019-03-23 14:35:16 +01:00
2017-11-01 12:19:03 +09:00
2018-08-24 13:09:13 +02:00
2019-06-11 12:21:45 +02:00
2018-05-16 10:10:26 +02:00
2019-05-02 09:40:34 +02:00
2019-05-08 07:20:44 +02:00
2019-05-16 19:42:30 +02:00
2019-06-11 12:21:44 +02:00
2019-01-09 17:14:46 +01:00
2018-07-22 14:28:47 +02:00
2019-05-02 09:40:29 +02:00
2017-08-07 14:48:48 -07:00
2019-06-09 09:18:12 +02:00
2018-12-05 19:41:11 +01:00
2019-03-19 13:13:24 +01:00
2019-05-25 18:25:17 +02:00
2017-11-02 11:10:55 +01:00
2019-05-31 06:47:22 -07:00
2019-03-19 13:13:23 +01:00
2019-05-25 18:25:33 +02:00
2019-01-09 17:14:46 +01:00
2017-09-04 13:25:20 +02:00
2017-11-02 11:10:55 +01:00
2019-03-13 14:03:09 -07:00
60086c3773