Theodore Ts'o b9ec63f78b ext4: Remove bogus BUG() check in ext4_bmap()
The code to support journal-less ext4 operation added a BUG to
ext4_bmap() which fired if there was no journal and the
EXT4_STATE_JDATA bit was set in the i_state field.  This caused
running the filefrag program (which uses the FIMBAP ioctl) to trigger
a BUG().

The EXT4_STATE_JDATA bit is only used for ext4_bmap(), and it's
harmless for the bit to be set.  We could add a check in
__ext4_journalled_writepage() and ext4_journalled_write_end() to only
set the EXT4_STATE_JDATA bit if the journal is present, but that adds
an extra test and jump instruction.  It's easier to simply remove the
BUG check.

http://bugzilla.kernel.org/show_bug.cgi?id=12568

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
2009-01-30 00:00:24 -05:00
..
2008-10-10 20:02:48 -04:00
2009-01-26 19:26:26 -05:00
2009-01-04 13:33:20 -08:00
2009-01-26 19:26:26 -05:00
2008-11-22 15:04:59 -05:00
2009-01-06 14:53:16 -05:00
2008-10-10 20:02:48 -04:00
2009-01-26 19:26:26 -05:00
2009-01-06 14:53:16 -05:00
2008-10-10 20:02:48 -04:00
2008-10-10 20:02:48 -04:00