iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Guangguan Wang d1c6c93c27 net/smc: use smc_lgr_list.lock to protect smc_lgr_list.list iterate in smcr_port_add 
[ Upstream commit f5146e3ef0a9eea405874b36178c19a4863b8989 ]

While doing smcr_port_add, there maybe linkgroup add into or delete
from smc_lgr_list.list at the same time, which may result kernel crash.
So, use smc_lgr_list.lock to protect smc_lgr_list.list iterate in
smcr_port_add.

The crash calltrace show below:
BUG: kernel NULL pointer dereference, address: 0000000000000000
PGD 0 P4D 0
Oops: 0000 [#1] SMP NOPTI
CPU: 0 PID: 559726 Comm: kworker/0:92 Kdump: loaded Tainted: G
Hardware name: Alibaba Cloud Alibaba Cloud ECS, BIOS 449e491 04/01/2014
Workqueue: events smc_ib_port_event_work [smc]
RIP: 0010:smcr_port_add+0xa6/0xf0 [smc]
RSP: 0000:ffffa5a2c8f67de0 EFLAGS: 00010297
RAX: 0000000000000001 RBX: ffff9935e0650000 RCX: 0000000000000000
RDX: 0000000000000010 RSI: ffff9935e0654290 RDI: ffff9935c8560000
RBP: 0000000000000000 R08: 0000000000000000 R09: ffff9934c0401918
R10: 0000000000000000 R11: ffffffffb4a5c278 R12: ffff99364029aae4
R13: ffff99364029aa00 R14: 00000000ffffffed R15: ffff99364029ab08
FS:  0000000000000000(0000) GS:ffff994380600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000000 CR3: 0000000f06a10003 CR4: 0000000002770ef0
PKRU: 55555554
Call Trace:
 smc_ib_port_event_work+0x18f/0x380 [smc]
 process_one_work+0x19b/0x340
 worker_thread+0x30/0x370
 ? process_one_work+0x340/0x340
 kthread+0x114/0x130
 ? __kthread_cancel_work+0x50/0x50
 ret_from_fork+0x1f/0x30

Fixes: 1f90a05d9ff9 ("net/smc: add smcr_port_add() and smcr_link_up() processing")
Signed-off-by: Guangguan Wang <guangguan.wang@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-09-19 12:20:29 +02:00
..
6lowpan
6lowpan: iphc: Fix an off-by-one check of array index
2021-09-15 09:50:34 +02:00
9p
9p: virtio: make sure 'offs' is initialized in zc_request
2023-09-19 12:20:04 +02:00
802
mrp: introduce active flags to prevent UAF when applicant uninit
2023-01-14 10:16:18 +01:00
8021q
vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()
2023-05-30 12:57:53 +01:00
appletalk
…
atm
atm: hide unused procfs functions
2023-06-09 10:30:12 +02:00
ax25
net: ax25: Fix deadlock caused by skb_recv_datagram in ax25_recvmsg
2022-06-22 14:13:17 +02:00
batman-adv
batman-adv: Hold rtnl lock during MTU update via netlink
2023-08-30 16:23:16 +02:00
bluetooth
Bluetooth: Fix potential use-after-free when clear keys
2023-09-19 12:20:08 +02:00
bpf
bpf: Move skb->len == 0 checks into __bpf_redirect
2023-01-14 10:15:31 +01:00
bpfilter
bpfilter: Specify the log level for the kmsg message
2021-07-14 16:56:29 +02:00
bridge
bridge: Add extack warning when enabling STP in netns.
2023-07-27 08:44:39 +02:00
caif
net: caif: Fix use-after-free in cfusbl_device_notify()
2023-03-17 08:45:11 +01:00
can
can: bcm: Fix UAF in bcm_proc_show()
2023-07-27 08:44:35 +02:00
ceph
libceph, rbd: ignore addr->type while comparing in some cases
2023-08-30 16:23:11 +02:00
core
af_unix: Fix data race around sk->sk_err.
2023-09-19 12:20:26 +02:00
dcb
net: dcb: choose correct policy to parse DCB_ATTR_BCN
2023-08-11 11:57:50 +02:00
dccp
dccp: Fix out of bounds access in DCCP error handler
2023-09-19 12:20:22 +02:00
decnet
Remove DECnet support from kernel
2023-06-21 15:45:38 +02:00
dns_resolver
…
dsa
net: dsa: tag_sja1105: fix MAC DA patching from meta frames
2023-07-27 08:44:10 +02:00
ethernet
…
ethtool
net/ethtool/ioctl: return -EOPNOTSUPP if we have no phy stats
2023-01-24 07:19:55 +01:00
hsr
hsr: ratelimit only when errors are printed
2023-04-05 11:23:52 +02:00
ieee802154
net: ieee802154: fix error return code in dgram_bind()
2022-11-03 23:57:51 +09:00
ife
…
ipv4
net: ipv4: fix one memleak in __inet_del_ifa()
2023-09-19 12:20:29 +02:00
ipv6
net: ipv6/addrconf: avoid integer underflow in ipv6_create_tempaddr
2023-09-19 12:20:26 +02:00
iucv
net/iucv: Fix size of interrupt data
2023-03-22 13:30:00 +01:00
kcm
kcm: Destroy mutex in kcm_exit_net()
2023-09-19 12:20:26 +02:00
key
net: af_key: fix sadb_x_filter validation
2023-08-26 15:26:51 +02:00
l2tp
inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
2023-04-26 11:27:41 +02:00
l3mdev
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
2022-04-27 13:53:50 +02:00
lapb
…
llc
llc: Don't drop packet from non-root netns.
2023-07-27 08:44:40 +02:00
mac80211
wifi: mac80211: fix min center freq offset tracing
2023-05-30 12:57:53 +01:00
mac802154
mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()
2022-12-14 11:32:01 +01:00
mpls
net: mpls: fix stale pointer if allocation fails during device rename
2023-02-22 12:55:58 +01:00
mptcp
inet6: Remove inet6_destroy_sock() in sk->sk_prot->destroy().
2023-04-26 11:27:41 +02:00
ncsi
net/ncsi: clear Tx enable mode when handling a Config required AEN
2023-05-17 11:48:10 +02:00
netfilter
netfilter: nfnetlink_osf: avoid OOB read
2023-09-19 12:20:27 +02:00
netlabel
netlabel: fix shift wrapping bug in netlbl_catmap_setlong()
2023-09-19 12:20:05 +02:00
netlink
netlink: Add __sock_i_ino() for __netlink_diag_dump().
2023-07-27 08:43:43 +02:00
netrom
netrom: Deny concurrent connect().
2023-09-19 12:20:10 +02:00
nfc
net: nfc: Fix use-after-free caused by nfc_llcp_find_local
2023-07-27 08:43:43 +02:00
nsh
net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()
2023-05-30 12:57:52 +01:00
openvswitch
net: openvswitch: fix possible memory leak in ovs_meter_cmd_set()
2023-02-22 12:55:57 +01:00
packet
net/packet: annotate data-races around tp->status
2023-08-16 18:21:01 +02:00
phonet
phonet: refcount leak in pep_sock_accep
2022-01-11 15:25:01 +01:00
psample
…
qrtr
net: qrtr: Fix an uninit variable access bug in qrtr_tx_resume()
2023-04-20 12:10:26 +02:00
rds
rds: rds_rm_zerocopy_callback() correct order for list_add_tail()
2023-03-11 16:39:26 +01:00
rfkill
…
rose
net/rose: Fix to not accept on connected socket
2023-02-22 12:55:53 +01:00
rxrpc
rxrpc: Fix hard call timeout units
2023-05-17 11:48:11 +02:00
sched
net: sched: sch_qfq: Fix UAF in qfq_dequeue()
2023-09-19 12:20:26 +02:00
sctp
sctp: annotate data-races around sk->sk_wmem_queued
2023-09-19 12:20:25 +02:00
smc
net/smc: use smc_lgr_list.lock to protect smc_lgr_list.list iterate in smcr_port_add
2023-09-19 12:20:29 +02:00
strparser
bpf: sockmap, strparser, and tls are reusing qdisc_skb_cb and colliding
2021-11-18 14:04:27 +01:00
sunrpc
xprtrdma: Remap Receive buffers after a reconnect
2023-08-30 16:23:09 +02:00
switchdev
…
tipc
tipc: stop tipc crypto on failure in tipc_node_create
2023-08-11 11:57:37 +02:00
tls
net: deal with most data-races in sk_wait_event()
2023-05-30 12:57:46 +01:00
unix
af_unix: Fix data-race around unix_tot_inflight.
2023-09-19 12:20:26 +02:00
vmw_vsock
vsock: avoid to close connected socket after the timeout
2023-05-30 12:57:52 +01:00
wimax
…
wireless
wifi: cfg80211: Fix return value in scan logic
2023-08-11 11:57:47 +02:00
x25
net/x25: Fix to not accept on connected socket
2023-02-15 17:22:15 +01:00
xdp
xsk: Honor SO_BINDTODEVICE on bind
2023-07-27 08:44:09 +02:00
xfrm
xfrm: add forgotten nla_policy for XFRMA_MTIMER_THRESH
2023-08-26 15:26:52 +02:00
compat.c
net: Return the correct errno code
2021-06-18 10:00:06 +02:00
devres.c
…
Kconfig
Remove DECnet support from kernel
2023-06-21 15:45:38 +02:00
Makefile
Remove DECnet support from kernel
2023-06-21 15:45:38 +02:00
socket.c
net: Avoid address overwrite in kernel_connect
2023-09-19 12:20:06 +02:00
sysctl_net.c
…