b0df306284
Fix the following warnings by adding return check and error handling.
test_execve.c: In function ‘do_tests’:
test_execve.c💯17: warning: ignoring return value of
‘capng_get_caps_process’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
100 | capng_get_caps_process();
| ^~~~~~~~~~~~~~~~~~~~~~~~
validate_cap.c: In function ‘main’:
validate_cap.c:47:9: warning: ignoring return value of
‘capng_get_caps_process’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
47 | capng_get_caps_process();
| ^~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Amer Al Shanawany <amer.shanawany@gmail.com>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
78 lines
1.7 KiB
C
78 lines
1.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <cap-ng.h>
|
|
#include <linux/capability.h>
|
|
#include <stdbool.h>
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#include <sys/prctl.h>
|
|
#include <sys/auxv.h>
|
|
|
|
#include "../kselftest.h"
|
|
|
|
#if __GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 19)
|
|
# define HAVE_GETAUXVAL
|
|
#endif
|
|
|
|
static bool bool_arg(char **argv, int i)
|
|
{
|
|
if (!strcmp(argv[i], "0"))
|
|
return false;
|
|
else if (!strcmp(argv[i], "1"))
|
|
return true;
|
|
else {
|
|
ksft_exit_fail_msg("wrong argv[%d]\n", i);
|
|
return false;
|
|
}
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
const char *atsec = "";
|
|
int ret;
|
|
|
|
/*
|
|
* Be careful just in case a setgid or setcapped copy of this
|
|
* helper gets out.
|
|
*/
|
|
|
|
if (argc != 5)
|
|
ksft_exit_fail_msg("wrong argc\n");
|
|
|
|
#ifdef HAVE_GETAUXVAL
|
|
if (getauxval(AT_SECURE))
|
|
atsec = " (AT_SECURE is set)";
|
|
else
|
|
atsec = " (AT_SECURE is not set)";
|
|
#endif
|
|
|
|
ret = capng_get_caps_process();
|
|
if (ret == -1) {
|
|
ksft_print_msg("capng_get_caps_process failed\n");
|
|
return 1;
|
|
}
|
|
|
|
if (capng_have_capability(CAPNG_EFFECTIVE, CAP_NET_BIND_SERVICE) != bool_arg(argv, 1)) {
|
|
ksft_print_msg("Wrong effective state%s\n", atsec);
|
|
return 1;
|
|
}
|
|
|
|
if (capng_have_capability(CAPNG_PERMITTED, CAP_NET_BIND_SERVICE) != bool_arg(argv, 2)) {
|
|
ksft_print_msg("Wrong permitted state%s\n", atsec);
|
|
return 1;
|
|
}
|
|
|
|
if (capng_have_capability(CAPNG_INHERITABLE, CAP_NET_BIND_SERVICE) != bool_arg(argv, 3)) {
|
|
ksft_print_msg("Wrong inheritable state%s\n", atsec);
|
|
return 1;
|
|
}
|
|
|
|
if (prctl(PR_CAP_AMBIENT, PR_CAP_AMBIENT_IS_SET, CAP_NET_BIND_SERVICE, 0, 0, 0) != bool_arg(argv, 4)) {
|
|
ksft_print_msg("Wrong ambient state%s\n", atsec);
|
|
return 1;
|
|
}
|
|
|
|
ksft_print_msg("%s: Capabilities after execve were correct\n",
|
|
"validate_cap:");
|
|
return 0;
|
|
}
|