iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Taehee Yoo bc928fdf5d bpf: use GFP_ATOMIC instead of GFP_KERNEL in bpf_parse_prog() 
[ Upstream commit 71eb5255f55bdb484d35ff7c9a1803f453dfbf82 ]

bpf_parse_prog() is protected by rcu_read_lock().
so that GFP_KERNEL is not allowed in the bpf_parse_prog().

[51015.579396] =============================
[51015.579418] WARNING: suspicious RCU usage
[51015.579444] 4.18.0-rc6+ #208 Not tainted
[51015.579464] -----------------------------
[51015.579488] ./include/linux/rcupdate.h:303 Illegal context switch in RCU read-side critical section!
[51015.579510] other info that might help us debug this:
[51015.579532] rcu_scheduler_active = 2, debug_locks = 1
[51015.579556] 2 locks held by ip/1861:
[51015.579577]  #0: 00000000a8c12fd1 (rtnl_mutex){+.+.}, at: rtnetlink_rcv_msg+0x2e0/0x910
[51015.579711]  #1: 00000000bf815f8e (rcu_read_lock){....}, at: lwtunnel_build_state+0x96/0x390
[51015.579842] stack backtrace:
[51015.579869] CPU: 0 PID: 1861 Comm: ip Not tainted 4.18.0-rc6+ #208
[51015.579891] Hardware name: To be filled by O.E.M. To be filled by O.E.M./Aptio CRB, BIOS 5.6.5 07/08/2015
[51015.579911] Call Trace:
[51015.579950]  dump_stack+0x74/0xbb
[51015.580000]  ___might_sleep+0x16b/0x3a0
[51015.580047]  __kmalloc_track_caller+0x220/0x380
[51015.580077]  kmemdup+0x1c/0x40
[51015.580077]  bpf_parse_prog+0x10e/0x230
[51015.580164]  ? kasan_kmalloc+0xa0/0xd0
[51015.580164]  ? bpf_destroy_state+0x30/0x30
[51015.580164]  ? bpf_build_state+0xe2/0x3e0
[51015.580164]  bpf_build_state+0x1bb/0x3e0
[51015.580164]  ? bpf_parse_prog+0x230/0x230
[51015.580164]  ? lock_is_held_type+0x123/0x1a0
[51015.580164]  lwtunnel_build_state+0x1aa/0x390
[51015.580164]  fib_create_info+0x1579/0x33d0
[51015.580164]  ? sched_clock_local+0xe2/0x150
[51015.580164]  ? fib_info_update_nh_saddr+0x1f0/0x1f0
[51015.580164]  ? sched_clock_local+0xe2/0x150
[51015.580164]  fib_table_insert+0x201/0x1990
[51015.580164]  ? lock_downgrade+0x610/0x610
[51015.580164]  ? fib_table_lookup+0x1920/0x1920
[51015.580164]  ? lwtunnel_valid_encap_type.part.6+0xcb/0x3a0
[51015.580164]  ? rtm_to_fib_config+0x637/0xbd0
[51015.580164]  inet_rtm_newroute+0xed/0x1b0
[51015.580164]  ? rtm_to_fib_config+0xbd0/0xbd0
[51015.580164]  rtnetlink_rcv_msg+0x331/0x910
[ ... ]

Fixes: 3a0af8fd61f9 ("bpf: BPF for lightweight tunnel infrastructure")
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-09-05 09:26:30 +02:00
..
6lowpan
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
9p
9p/trans_virtio: discard zero-length reply
2018-02-22 15:42:30 +01:00
802
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
8021q
net: fix use-after-free in GRO with ESP
2018-07-22 14:28:44 +02:00
appletalk
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
atm
atm: Preserve value of skb->truesize when accounting to vcc
2018-07-22 14:28:43 +02:00
ax25
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
batman-adv
batman-adv: Fix multicast TT issues with bogus ROAM flags
2018-08-24 13:09:05 +02:00
bluetooth
Bluetooth: avoid killing an already killed socket
2018-08-22 07:46:11 +02:00
bpf
bpf: Align packet data properly in program testing framework.
2017-05-02 11:46:28 -04:00
bridge
netfilter: ebtables: reject non-bridge targets
2018-07-22 14:28:49 +02:00
caif
net: caif: Add a missing rcu_read_unlock() in caif_flow_cb
2018-09-05 09:26:27 +02:00
can
can: af_can: canfd_rcv(): replace WARN_ONCE by pr_warn_once
2018-01-23 19:58:17 +01:00
ceph
libceph, ceph: avoid memory leak when specifying same option several times
2018-05-30 07:52:04 +02:00
core
bpf: use GFP_ATOMIC instead of GFP_KERNEL in bpf_parse_prog()
2018-09-05 09:26:30 +02:00
dcb
rtnetlink: make rtnl_register accept a flags parameter
2017-08-09 16:57:38 -07:00
dccp
dccp: fix undefined behavior with 'cwnd' shift in ccid2_cwnd_restart()
2018-08-22 07:46:08 +02:00
decnet
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock
2018-02-25 11:07:52 +01:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:28:49 +02:00
dsa
net: dsa: Do not suspend/resume closed slave_dev
2018-08-06 16:20:48 +02:00
ethernet
networking: make skb_push & __skb_push return void pointers
2017-06-16 11:48:40 -04:00
hsr
net/hsr: Check skb_put_padto() return value
2017-08-22 13:40:23 -07:00
ieee802154
ieee802154: 6lowpan: set IFLA_LINK
2018-08-24 13:09:12 +02:00
ife
net: sched: ife: check on metadata length
2018-04-29 11:33:13 +02:00
ipv4
tcp: identify cryptic messages as TCP seq # bugs
2018-08-24 13:09:19 +02:00
ipv6
esp6: fix memleak on error path in esp6_input
2018-09-05 09:26:23 +02:00
ipx
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
iucv
net/iucv: Free memory obtained by kzalloc
2018-03-31 18:10:41 +02:00
kcm
kcm: Fix use-after-free caused by clonned sockets
2018-06-11 22:49:19 +02:00
key
af_key: Always verify length of provided sadb_key
2018-06-16 09:45:14 +02:00
l2tp
l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache
2018-08-22 07:46:08 +02:00
l3mdev
…
lapb
net, lapb: convert lapb_cb.refcnt from atomic_t to refcount_t
2017-07-04 22:35:16 +01:00
llc
llc: use refcount_inc_not_zero() for llc_sap_find()
2018-08-22 07:46:08 +02:00
mac80211
mac80211: add stations tied to AP_VLANs during hw reconfig
2018-09-05 09:26:23 +02:00
mac802154
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
mpls
mpls, nospec: Sanitize array index in mpls_label_ok()
2018-02-22 15:42:28 +01:00
ncsi
net/ncsi: Fix length of GVI response packet
2017-10-21 01:56:38 +01:00
netfilter
netfilter: nf_tables: don't allow to rename to already-pending name
2018-09-05 09:26:27 +02:00
netlabel
netlabel: If PF_INET6, check sk_buff ip header version
2018-05-30 07:52:40 +02:00
netlink
netlink: Don't shift on 64 for ngroups
2018-08-09 12:16:38 +02:00
netrom
net, netrom: convert nr_node.refcount from atomic_t to refcount_t
2017-07-04 22:35:17 +01:00
nfc
net/nfc: Avoid stalls when nfc_alloc_send_skb() returned NULL.
2018-07-22 14:28:49 +02:00
nsh
nsh: set mac len based on inner packet
2018-07-22 14:28:49 +02:00
openvswitch
openvswitch: Don't swap table in nlattr_set() after OVS_ATTR_NESTED is found
2018-05-19 10:20:24 +02:00
packet
packet: refine ring v3 block size test to hold one frame
2018-08-24 13:09:22 +02:00
phonet
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
psample
MAINTAINERS: Update Yotam's E-mail
2017-11-01 12:19:03 +09:00
qrtr
net: qrtr: Broadcast messages only from control port
2018-08-24 13:09:13 +02:00
rds
rds: avoid unenecessary cong_update in loop transport
2018-07-22 14:28:49 +02:00
rfkill
rfkill: gpio: fix memory leak in probe error path
2018-05-16 10:10:26 +02:00
rose
…
rxrpc
rxrpc: Fix user call ID check in rxrpc_service_prealloc_one
2018-08-06 16:20:48 +02:00
sched
net/sched: act_tunnel_key: fix NULL dereference when 'goto chain' is used
2018-08-24 13:09:14 +02:00
sctp
sctp: fix erroneous inc of snmp SctpFragUsrMsgs
2018-08-24 13:09:03 +02:00
smc
net/smc: no shutdown in state SMC_LISTEN
2018-08-24 13:09:22 +02:00
strparser
strparser: Remove early eaten to fix full tcp receive buffer stall
2018-07-22 14:28:47 +02:00
sunrpc
xprtrdma: Fix corner cases when handling device removal
2018-07-22 14:28:42 +02:00
switchdev
net: switchdev: Remove bridge bypass support from switchdev
2017-08-07 14:48:48 -07:00
tipc
tipc: eliminate KMSAN uninit-value in strcmp complaint
2018-06-21 04:02:56 +09:00
tls
sock: fix sg page frag coalescing in sk_alloc_sg
2018-07-28 07:55:42 +02:00
unix
License cleanup: add SPDX license identifiers to some files
2017-11-02 10:04:46 -07:00
vmw_vsock
vsock: split dwork to avoid reinitializations
2018-08-22 07:46:08 +02:00
wimax
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
wireless
nl80211: Add a missing break in parse_station_flags
2018-09-05 09:26:24 +02:00
x25
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
xfrm
xfrm: free skb if nlsk pointer is NULL
2018-09-05 09:26:23 +02:00
compat.c
net: support compat 64-bit time in {s,g}etsockopt
2018-05-19 10:20:24 +02:00
Kconfig
net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.
2017-09-04 13:25:20 +02:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
socket.c
net: socket: fix potential spectre v1 gadget in socketcall
2018-08-06 16:20:48 +02:00
sysctl_net.c
…