linux

iv/linux

History

Jiri Pirko 61c43780e9 devlink: fix port dump cmd type

Unlike other commands, due to a c&p error, port dump fills-up cmd with
wrong value, different from port-get request cmd, port-get doit reply
and port notification.

Fix it by filling cmd with value DEVLINK_CMD_PORT_NEW.

Skimmed through devlink userspace implementations, none of them cares
about this cmd value. Only ynl, for which, this is actually a fix, as it
expects doit and dumpit ops rsp_value to be the same.

Omit the fixes tag, even thought this is fix, better to target this for
next release.

Fixes: bfcd3a466172 ("Introduce devlink infrastructure")
Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20240220075245.75416-1-jiri@resnulli.us
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

2024-02-21 17:11:04 -08:00

core.c

devlink: fix possible use-after-free and memory leaks in devlink_init()

2024-02-20 10:17:46 +01:00

dev.c

devlink: introduce a helper for netlink multicast send

2023-12-19 15:31:40 +01:00

devl_internal.h

devlink: extend multicast filtering by port index

2023-12-19 15:31:40 +01:00

dpipe.c

devlink: rename netlink callback to be aligned with the generated ones