Jason Gunthorpe 61e9081748 vfio/pci: Move VGA and VF initialization to functions
vfio_pci_probe() is quite complicated, with optional VF and VGA sub
components. Move these into clear init/uninit functions and have a linear
flow in probe/remove.

This fixes a few little buglets:
 - vfio_pci_remove() is in the wrong order, vga_client_register() removes
   a notifier and is after kfree(vdev), but the notifier refers to vdev,
   so it can use after free in a race.
 - vga_client_register() can fail but was ignored

Organize things so destruction order is the reverse of creation order.

Fixes: ecaa1f6a0154 ("vfio-pci: Add VGA arbiter client")
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Message-Id: <7-v3-225de1400dfc+4e074-vfio1_jgg@nvidia.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
2021-04-06 11:55:10 -06:00
..
2021-04-03 10:14:47 -07:00
2021-04-02 16:13:13 -07:00
2021-03-18 23:52:27 +01:00
2021-02-22 14:44:39 -08:00
2021-02-23 15:05:10 -08:00
2021-02-22 10:05:12 -08:00
2021-02-22 14:27:07 -08:00
2021-02-22 09:52:55 -08:00
2021-02-28 15:48:25 -08:00
2021-02-24 10:25:37 -08:00
2021-02-24 09:35:54 -08:00
2021-02-24 10:25:37 -08:00
2021-03-21 10:57:35 -07:00
2021-03-30 00:46:49 +02:00
2021-02-25 12:23:49 -08:00
2021-04-03 09:07:35 -07:00
2021-04-03 15:42:45 -07:00
2021-04-03 10:00:53 -07:00
2021-03-18 11:20:35 -07:00
2021-04-03 10:42:20 -07:00
2021-03-18 11:20:35 -07:00
2021-02-09 12:15:07 +01:00
2021-03-26 11:15:25 -07:00