linux/net/sunrpc
David S. Miller 51c739d1f4 [NET]: Fix incorrect sg_mark_end() calls.
This fixes scatterlist corruptions added by

	commit 68e3f5dd4d
	[CRYPTO] users: Fix up scatterlist conversion errors

The issue is that the code calls sg_mark_end() which clobbers the
sg_page() pointer of the final scatterlist entry.

The first part fo the fix makes skb_to_sgvec() do __sg_mark_end().

After considering all skb_to_sgvec() call sites the most correct
solution is to call __sg_mark_end() in skb_to_sgvec() since that is
what all of the callers would end up doing anyways.

I suspect this might have fixed some problems in virtio_net which is
the sole non-crypto user of skb_to_sgvec().

Other similar sg_mark_end() cases were converted over to
__sg_mark_end() as well.

Arguably sg_mark_end() is a poorly named function because it doesn't
just "mark", it clears out the page pointer as a side effect, which is
what led to these bugs in the first place.

The one remaining plain sg_mark_end() call is in scsi_alloc_sgtable()
and arguably it could be converted to __sg_mark_end() if only so that
we can delete this confusing interface from linux/scatterlist.h

Signed-off-by: David S. Miller <davem@davemloft.net>
2007-10-30 21:29:29 -07:00
..
auth_gss [NET]: Fix incorrect sg_mark_end() calls. 2007-10-30 21:29:29 -07:00
xprtrdma [SUNRPC] rpc_rdma: we need to cast u64 to unsigned long long for printing 2007-10-30 00:44:32 -07:00
auth_null.c SUNRPC: cleanup rpc credential cache garbage collection 2007-07-10 23:40:35 -04:00
auth_unix.c SUNRPC: Remove the tk_auth macro... 2007-07-10 23:40:37 -04:00
auth.c SUNRPC: move bkl locking and xdr proc invocation into a common helper 2007-07-19 15:21:39 -04:00
cache.c [SUNRPC]: Make the sunrpc use the seq_open_private() 2007-10-10 16:55:36 -07:00
clnt.c SUNRPC: Don't call xprt_release in call refresh 2007-10-09 17:20:42 -04:00
Makefile RPCRDMA: rpc rdma transport switch 2007-10-09 17:18:03 -04:00
rpc_pipe.c Slab API: remove useless ctor parameter and reorder parameters 2007-10-17 08:42:45 -07:00
rpcb_clnt.c [2.6 patch] net/sunrpc/rpcb_clnt.c: make struct rpcb_program static 2007-10-09 17:20:32 -04:00
sched.c Use helpers to obtain task pid in printks 2007-10-19 11:53:43 -07:00
socklib.c SUNRPC: add EXPORT_SYMBOL_GPL for generic transport functions 2007-10-09 17:17:36 -04:00
stats.c [NET]: Make /proc/net per network namespace 2007-10-10 16:49:06 -07:00
sunrpc_syms.c SUNRPC: rearrange RPC sockets definitions 2007-10-09 17:17:48 -04:00
svc.c knfsd: Add source address to sunrpc svc errors 2007-10-09 18:31:57 -04:00
svcauth_unix.c knfsd: nfsd: set rq_client to ip-address-determined-domain 2007-07-17 10:23:07 -07:00
svcauth.c
svcsock.c [NET] Cleanup: Use sock_owned_by_user() macro 2007-10-10 16:49:00 -07:00
sysctl.c [SUNRPC]: fix rpc debugging 2007-10-30 01:07:15 -07:00
timer.c SUNRPC: add EXPORT_SYMBOL_GPL for generic transport functions 2007-10-09 17:17:36 -04:00
xdr.c [CRYPTO] users: Fix up scatterlist conversion errors 2007-10-27 00:52:07 -07:00
xprt.c NFS/SUNRPC: support transport protocol naming 2007-10-09 17:17:50 -04:00
xprtsock.c Merge git://git.linux-nfs.org/pub/linux/nfs-2.6 2007-10-15 10:47:35 -07:00