6277fbfdd2
There is no need for the a3/a4 union. The two structs are identical except for the addition of a4. Excepting one place, the structs are only ever used in the union, and the union is always allocated at full size. The one instance of the a3-specific struct can be replaced with the full version, as no sizing information is used. Replace the union with the a4 version of the struct. "diffoscope" reports there are no object code differences after this change. Cc: Allen Pais <apais@linux.microsoft.com> Cc: Romain Perier <romain.perier@gmail.com> Cc: Chen Lin <chen.lin5@zte.com.cn> Cc: Ivan Safonov <insafonov@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: linux-staging@lists.linux.dev Signed-off-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20210819174537.3499227-2-keescook@chromium.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
|---|---|---|
| .. | ||
| cfg80211.c | ||
| hfa384x_usb.c | ||
| hfa384x.h | ||
| Kconfig | ||
| Makefile | ||
| p80211conv.c | ||
| p80211conv.h | ||
| p80211hdr.h | ||
| p80211ioctl.h | ||
| p80211metadef.h | ||
| p80211metastruct.h | ||
| p80211mgmt.h | ||
| p80211msg.h | ||
| p80211netdev.c | ||
| p80211netdev.h | ||
| p80211req.c | ||
| p80211req.h | ||
| p80211types.h | ||
| p80211wep.c | ||
| prism2fw.c | ||
| prism2mgmt.c | ||
| prism2mgmt.h | ||
| prism2mib.c | ||
| prism2sta.c | ||
| prism2usb.c | ||
| README | ||
TODO: - checkpatch.pl cleanups - sparse warnings - move to use the in-kernel wireless stack Please send any patches or complaints about this driver to Greg Kroah-Hartman <greg@kroah.com> and don't bother the upstream wireless kernel developers about it, they want nothing to do with it.