iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Baokun Li e711913463 jffs2: fix memory leak in jffs2_scan_medium 
commit 9cdd3128874f5fe759e2c4e1360ab7fb96a8d1df upstream.

If an error is returned in jffs2_scan_eraseblock() and some memory
has been added to the jffs2_summary *s, we can observe the following
kmemleak report:

--------------------------------------------
unreferenced object 0xffff88812b889c40 (size 64):
  comm "mount", pid 692, jiffies 4294838325 (age 34.288s)
  hex dump (first 32 bytes):
    40 48 b5 14 81 88 ff ff 01 e0 31 00 00 00 50 00  @H........1...P.
    00 00 01 00 00 00 01 00 00 00 02 00 00 00 09 08  ................
  backtrace:
    [<ffffffffae93a3a3>] __kmalloc+0x613/0x910
    [<ffffffffaf423b9c>] jffs2_sum_add_dirent_mem+0x5c/0xa0
    [<ffffffffb0f3afa8>] jffs2_scan_medium.cold+0x36e5/0x4794
    [<ffffffffb0f3dbe1>] jffs2_do_mount_fs.cold+0xa7/0x2267
    [<ffffffffaf40acf3>] jffs2_do_fill_super+0x383/0xc30
    [<ffffffffaf40c00a>] jffs2_fill_super+0x2ea/0x4c0
    [<ffffffffb0315d64>] mtd_get_sb+0x254/0x400
    [<ffffffffb0315f5f>] mtd_get_sb_by_nr+0x4f/0xd0
    [<ffffffffb0316478>] get_tree_mtd+0x498/0x840
    [<ffffffffaf40bd15>] jffs2_get_tree+0x25/0x30
    [<ffffffffae9f358d>] vfs_get_tree+0x8d/0x2e0
    [<ffffffffaea7a98f>] path_mount+0x50f/0x1e50
    [<ffffffffaea7c3d7>] do_mount+0x107/0x130
    [<ffffffffaea7c5c5>] __se_sys_mount+0x1c5/0x2f0
    [<ffffffffaea7c917>] __x64_sys_mount+0xc7/0x160
    [<ffffffffb10142f5>] do_syscall_64+0x45/0x70
unreferenced object 0xffff888114b54840 (size 32):
  comm "mount", pid 692, jiffies 4294838325 (age 34.288s)
  hex dump (first 32 bytes):
    c0 75 b5 14 81 88 ff ff 02 e0 02 00 00 00 02 00  .u..............
    00 00 84 00 00 00 44 00 00 00 6b 6b 6b 6b 6b a5  ......D...kkkkk.
  backtrace:
    [<ffffffffae93be24>] kmem_cache_alloc_trace+0x584/0x880
    [<ffffffffaf423b04>] jffs2_sum_add_inode_mem+0x54/0x90
    [<ffffffffb0f3bd44>] jffs2_scan_medium.cold+0x4481/0x4794
    [...]
unreferenced object 0xffff888114b57280 (size 32):
  comm "mount", pid 692, jiffies 4294838393 (age 34.357s)
  hex dump (first 32 bytes):
    10 d5 6c 11 81 88 ff ff 08 e0 05 00 00 00 01 00  ..l.............
    00 00 38 02 00 00 28 00 00 00 6b 6b 6b 6b 6b a5  ..8...(...kkkkk.
  backtrace:
    [<ffffffffae93be24>] kmem_cache_alloc_trace+0x584/0x880
    [<ffffffffaf423c34>] jffs2_sum_add_xattr_mem+0x54/0x90
    [<ffffffffb0f3a24f>] jffs2_scan_medium.cold+0x298c/0x4794
    [...]
unreferenced object 0xffff8881116cd510 (size 16):
  comm "mount", pid 692, jiffies 4294838395 (age 34.355s)
  hex dump (first 16 bytes):
    00 00 00 00 00 00 00 00 09 e0 60 02 00 00 6b a5  ..........`...k.
  backtrace:
    [<ffffffffae93be24>] kmem_cache_alloc_trace+0x584/0x880
    [<ffffffffaf423cc4>] jffs2_sum_add_xref_mem+0x54/0x90
    [<ffffffffb0f3b2e3>] jffs2_scan_medium.cold+0x3a20/0x4794
    [...]
--------------------------------------------

Therefore, we should call jffs2_sum_reset_collected(s) on exit to
release the memory added in s. In addition, a new tag "out_buf" is
added to prevent the NULL pointer reference caused by s being NULL.
(thanks to Zhang Yi for this analysis)

Fixes: e631ddba5887 ("[JFFS2] Add erase block summary support (mount time improvement)")
Cc: stable@vger.kernel.org
Co-developed-with: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-15 14:14:39 +02:00
..
9p
9P: Cast to loff_t before multiplying
2020-11-05 11:08:53 +01:00
adfs
fs/adfs: super: fix use-after-free bug
2019-08-06 19:06:49 +02:00
affs
fs/affs: release old buffer head on error path
2021-03-04 09:39:55 +01:00
afs
afs: Fix an IS_ERR() vs NULL check
2021-06-30 08:48:14 -04:00
autofs
autofs: fix a leak in autofs_expire_indirect()
2019-12-13 08:51:01 +01:00
befs
…
bfs
bfs: add sanity check at bfs_fill_super()
2018-12-01 09:37:27 +01:00
btrfs
btrfs: unlock newly allocated extent buffer after error
2022-03-16 13:20:28 +01:00
cachefiles
cachefiles: Handle readpage error correctly
2020-11-05 11:08:54 +01:00
ceph
ceph: lockdep annotations for try_nonblocking_invalidate
2021-09-26 13:39:48 +02:00
cifs
cifs: fix double free race when mount fails in cifs_get_root()
2022-03-08 19:04:06 +01:00
coda
coda: add error handling for fget
2019-08-06 19:06:51 +02:00
configfs
configfs: fix a race in configfs_{,un}register_subsystem()
2022-03-02 11:38:13 +01:00
cramfs
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:08:55 -08:00
crypto
fscrypt: add fscrypt_symlink_getattr() for computing st_size
2021-09-22 11:47:56 +02:00
debugfs
debugfs: fix use-after-free on symlink traversal
2019-05-08 07:21:48 +02:00
devpts
fs/devpts: always delete dcache dentry-s in dput()
2019-03-23 20:09:59 +01:00
dlm
fs: dlm: filter user dlm messages for kernel locks
2022-01-27 09:04:23 +01:00
ecryptfs
Revert "ecryptfs: replace BUG_ON with error handling code"
2021-05-26 11:48:34 +02:00
efivarfs
efivarfs: revert "fix memory leak in efivarfs_create()"
2020-12-02 08:48:12 +01:00
efs
…
exofs
exofs_mount(): fix leaks on failure exits
2019-12-05 09:20:32 +01:00
exportfs
exportfs: fix 'passing zero to ERR_PTR()' warning
2020-01-27 14:50:02 +01:00
ext2
ext2: fix sleeping in atomic bugs on error
2021-10-09 14:11:03 +02:00
ext4
ext4: add check to prevent attempting to resize an fs with sparse_super2
2022-03-16 13:20:28 +01:00
f2fs
f2fs: fix to unlock page correctly in error path of is_alive()
2022-04-15 14:14:39 +02:00
fat
fat: don't allow to mount if the FAT length == 0
2020-06-22 09:05:08 +02:00
freevxfs
…
fscache
fscache: Fix cookie key hashing
2021-09-22 11:48:02 +02:00
fuse
fuse: fix pipe buffer lifetime for direct_io
2022-04-15 14:14:37 +02:00
gfs2
gfs2: Fix length of holes reported at end-of-file
2021-12-08 08:50:11 +01:00
hfs
hfs: add lock nesting notation to hfs_find_init
2021-07-31 08:22:38 +02:00
hfsplus
hfsplus: prevent corruption in shrinking truncate
2021-05-22 10:59:45 +02:00
hostfs
…
hpfs
…
hugetlbfs
hugetlbfs: hugetlb_fault_mutex_hash() cleanup
2021-06-03 08:38:12 +02:00
isofs
isofs: Fix out of bound access for corrupted isofs image
2021-11-12 14:40:50 +01:00
jbd2
jbd2: abort journal if free a async write error metadata buffer
2020-09-03 11:24:24 +02:00
jffs2
jffs2: fix memory leak in jffs2_scan_medium
2022-04-15 14:14:39 +02:00
jfs
JFS: fix memleak in jfs_mount
2021-11-26 11:36:12 +01:00
kernfs
kernfs: fix ino wrap-around detection
2019-12-13 08:52:43 +01:00
lockd
lockd: don't use interval-based rebinding over TCP
2020-12-30 11:25:59 +01:00
minix
fs/minix: remove expected error message in block_to_path()
2020-08-21 11:05:38 +02:00
nfs
NFS: Do not report writeback errors in nfs_getattr()
2022-02-23 11:58:40 +01:00
nfs_common
nfs_common: need lock during iterate through the list
2020-12-30 11:26:02 +01:00
nfsd
NFSD: prevent underflow in nfssvc_decode_writeargs()
2022-04-15 14:14:39 +02:00
nilfs2
nilfs2: fix memory leak in nilfs_sysfs_delete_snapshot_group
2021-09-26 13:39:49 +02:00
nls
…
notify
fanotify: fix ignore mask logic for events on child and on dir
2020-06-30 23:17:00 -04:00
ntfs
ntfs: fix validity check for file name attribute
2021-07-20 16:15:39 +02:00
ocfs2
ocfs2: fix crash when initialize filecheck kobj fails
2022-03-23 09:10:44 +01:00
omfs
…
openpromfs
…
orangefs
orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()
2022-01-27 09:04:13 +01:00
overlayfs
ovl: fix warning in ovl_create_real()
2021-12-22 09:19:04 +01:00
proc
proc/vmcore: fix clearing user buffer by properly using clear_user()
2021-12-01 09:27:39 +01:00
pstore
pstore: Fix typo in compression option name
2021-03-04 09:39:54 +01:00
qnx4
qnx4: work around gcc false positive warning bug
2021-10-06 15:31:20 +02:00
qnx6
…
quota
quota: make dquot_quota_sync return errors from ->sync_fs
2022-02-23 11:58:38 +01:00
ramfs
ramfs: fix nommu mmap with gaps in the page cache
2020-10-30 10:38:21 +01:00
reiserfs
reiserfs: check directory items on read from disk
2021-08-12 13:19:44 +02:00
romfs
romfs: fix uninitialized memory leak in romfs_dev_read()
2020-08-26 10:30:59 +02:00
squashfs
squashfs: fix divide error in calculate_skip()
2021-05-22 10:59:45 +02:00
sysfs
fs: sysfs_emit: Remove PAGE_SIZE alignment check
2022-03-23 09:10:42 +01:00
sysv
sysv: return 'err' instead of 0 in __sysv_write_inode
2018-12-17 09:24:30 +01:00
tracefs
tracefs: Set the group ownership in apply_options() not parse_options()
2022-03-02 11:38:17 +01:00
ubifs
ubifs: Error path in ubifs_remount_rw() seems to wrongly free write buffers
2022-01-27 09:04:30 +01:00
udf
udf: Fix NULL ptr deref when converting from inline format
2022-02-08 18:23:03 +01:00
ufs
fs/ufs: avoid potential u32 multiplication overflow
2020-08-21 11:05:38 +02:00
xfs
xfs: map unwritten blocks in XFS_IOC_{ALLOC,FREE}SP just like fallocate
2022-01-11 13:58:49 +01:00
aio.c
aio: fix use-after-free due to missing POLLFREE handling
2021-12-14 10:18:07 +01:00
anon_inodes.c
…
attr.c
…
bad_inode.c
…
binfmt_aout.c
…
binfmt_elf_fdpic.c
…
binfmt_elf.c
elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
2021-10-06 15:31:24 +02:00
binfmt_em86.c
…
binfmt_flat.c
fs/binfmt_flat.c: make load_flat_shared_library() work
2019-07-03 13:14:44 +02:00
binfmt_misc.c
binfmt_misc: fix possible deadlock in bm_register_write
2021-03-17 16:43:51 +01:00
binfmt_script.c
exec: load_script: Do not exec truncated interpreter path
2019-11-06 13:05:37 +01:00
block_dev.c
block: reexpand iov_iter after read/write
2021-05-22 10:59:49 +02:00
buffer.c
fs: Don't invalidate page buffers in block_write_full_page()
2020-11-05 11:08:46 +01:00
char_dev.c
chardev: Avoid potential use-after-free in 'chrdev_open()'
2020-01-14 20:06:57 +01:00
compat_binfmt_elf.c
…
compat_ioctl.c
fix compat handling of FICLONERANGE, FIDEDUPERANGE and FS_IOC_FIEMAP
2020-01-09 10:19:07 +01:00
compat.c
…
coredump.c
coredump: fix crash when umh is disabled
2020-05-14 07:57:21 +02:00
d_path.c
…
dax.c
dax: pass NOWAIT flag to iomap_apply
2020-03-05 16:42:12 +01:00
dcache.c
fs, fscrypt: clear DCACHE_ENCRYPTED_NAME when unaliasing directory
2020-11-05 11:08:35 +01:00
dcookies.c
…
direct-io.c
fs: direct-io: fix missing sdio->boundary
2021-04-14 08:22:32 +02:00
drop_caches.c
fs: avoid softlockups in s_inodes iterators
2020-01-12 12:17:20 +01:00
eventfd.c
eventfd: track eventfd_signal() recursion depth
2020-02-11 04:34:08 -08:00
eventpoll.c
ep_create_wakeup_source(): dentry name can change under you...
2020-10-07 08:00:09 +02:00
exec.c
vfs: check fd has read access in kernel_read_file_from_fd()
2021-10-27 09:53:13 +02:00
fcntl.c
fcntl: fix potential deadlock for &fasync_struct.fa_lock
2021-09-22 11:47:50 +02:00
fhandle.c
…
file_table.c
fs: add fget_many() and fput_many()
2021-12-08 08:50:13 +01:00
file.c
fget: clarify and improve __fget_files() implementation
2022-03-02 11:38:15 +01:00
filesystems.c
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once()
2020-04-17 10:48:51 +02:00
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
writeback: fix obtain a reference to a freeing memcg css
2021-07-20 16:15:52 +02:00
inode.c
futex: Fix inode life-time issue
2020-03-25 08:06:14 +01:00
internal.h
acct_on(): don't mess with freeze protection
2019-05-31 06:46:05 -07:00
ioctl.c
vfs: fix FIGETBSZ ioctl on an overlayfs file
2018-11-21 09:19:14 +01:00
iomap.c
iomap: fix sub-page uptodate handling
2021-05-22 10:59:50 +02:00
Kconfig
…
Kconfig.binfmt
…
libfs.c
libfs: fix error cast of negative value in simple_attr_write()
2020-11-24 13:27:23 +01:00
locks.c
locks: print unsigned ino in /proc/locks
2020-01-09 10:19:00 +01:00
Makefile
…
mbcache.c
…
mount.h
…
mpage.c
…
namei.c
namei: only return -ECHILD from follow_dotdot_rcu()
2020-03-05 16:42:20 +01:00
namespace.c
fs: warn about impending deprecation of mandatory locks
2021-08-26 08:36:49 -04:00
no-block.c
…
nsfs.c
dcache: sort the freeing-without-RCU-delay mess for good.
2019-05-25 18:23:26 +02:00
open.c
cifs_atomic_open(): fix double-put on late allocation failure
2020-03-18 07:14:21 +01:00
pipe.c
pipe: increase minimum default pipe size to 2 pages
2021-08-12 13:19:43 +02:00
pnode.c
propagate_one(): mnt_set_mountpoint() needs mount_lock
2020-05-02 17:26:01 +02:00
pnode.h
…
posix_acl.c
…
proc_namespace.c
…
read_write.c
vfs: avoid problematic remapping requests into partial EOF block
2019-12-01 09:17:04 +01:00
readdir.c
readdir: make sure to verify directory entry for legacy interfaces too
2021-04-28 13:16:50 +02:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:19:18 +01:00
seq_file.c
seq_file: disallow extremely large seq buffer allocations
2021-07-20 16:16:16 +02:00
signalfd.c
signalfd: use wake_up_pollfree()
2021-12-14 10:18:07 +01:00
splice.c
splice: only read in as much information as there is pipe buffer space
2019-12-17 20:35:43 +01:00
stack.c
…
stat.c
…
statfs.c
vfs: Fix EOVERFLOW testing in put_compat_statfs64
2019-10-11 18:21:39 +02:00
super.c
vfs: make freeze_super abort when sync_filesystem returns error
2022-02-23 11:58:38 +01:00
sync.c
…
timerfd.c
…
userfaultfd.c
userfaultfd: prevent concurrent API initialization
2021-09-22 11:48:02 +02:00
utimes.c
…
xattr.c
xattr: break delegations in {set,remove}xattr
2020-08-11 15:32:34 +02:00