Mikhail Zolotaryov 62f0c338d1 powerpc 4xx EMAC driver: device name reported on timeout is not correct
Hi,

IBM EMAC driver performs device reset (drivers/net/ibm_newemac/core.c:
emac_probe() -> emac_init_phy() -> emac_reset()) before registering
appropriate net_device (emac_probe() -> register_netdev()), so
net_device name contains raw format string during EMAC reset ("eth%d").

If the case of reset timeout, emac_report_timeout_error() function is
called to report an error. The problem is this function uses net_device
name to report device related, which is not correct, as a result in the
kernel log buffer we see:

eth%d: reset timeout

The solution is to print device_node full_name instead. After applying
the patch proposed, error string is like the following:

/plb/opb/ethernet@ef600e00: reset timeout

Signed-off-by: Mikhail Zolotaryov <lebon@lebon.org.ua>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2009-03-21 16:50:20 -07:00
..
2009-02-02 23:26:57 -08:00
2009-02-18 15:37:56 -08:00
2009-01-29 18:04:43 -08:00
2009-03-04 21:49:14 +10:00
2009-02-26 10:32:31 -08:00
2009-01-15 16:39:40 -08:00
2009-02-25 13:18:47 +11:00
2009-02-27 16:26:22 -08:00
2009-02-02 19:53:02 +03:00
2009-02-11 14:25:36 -08:00
2009-02-18 15:37:56 -08:00
2009-03-05 14:39:32 -05:00