Colin Ian King
bd6042e9c3
mm/page_idle.c: fix oops because end_pfn is larger than max_pfn
...
commit 7298e3b0a149c91323b3205d325e942c3b3b9ef6 upstream.
Currently the calcuation of end_pfn can round up the pfn number to more
than the actual maximum number of pfns, causing an Oops. Fix this by
ensuring end_pfn is never more than max_pfn.
This can be easily triggered when on systems where the end_pfn gets
rounded up to more than max_pfn using the idle-page stress-ng stress test:
sudo stress-ng --idle-page 0
BUG: unable to handle kernel paging request at 00000000000020d8
#PF error: [normal kernel read fault]
PGD 0 P4D 0
Oops: 0000 [#1 ] SMP PTI
CPU: 1 PID: 11039 Comm: stress-ng-idle- Not tainted 5.0.0-5-generic #6-Ubuntu
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
RIP: 0010:page_idle_get_page+0xc8/0x1a0
Code: 0f b1 0a 75 7d 48 8b 03 48 89 c2 48 c1 e8 33 83 e0 07 48 c1 ea 36 48 8d 0c 40 4c 8d 24 88 49 c1 e4 07 4c 03 24 d5 00 89 c3 be <49> 8b 44 24 58 48 8d b8 80 a1 02 00 e8 07 d5 77 00 48 8b 53 08 48
RSP: 0018:ffffafd7c672fde8 EFLAGS: 00010202
RAX: 0000000000000005 RBX: ffffe36341fff700 RCX: 000000000000000f
RDX: 0000000000000284 RSI: 0000000000000275 RDI: 0000000001fff700
RBP: ffffafd7c672fe00 R08: ffffa0bc34056410 R09: 0000000000000276
R10: ffffa0bc754e9b40 R11: ffffa0bc330f6400 R12: 0000000000002080
R13: ffffe36341fff700 R14: 0000000000080000 R15: ffffa0bc330f6400
FS: 00007f0ec1ea5740(0000) GS:ffffa0bc7db00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000000020d8 CR3: 0000000077d68000 CR4: 00000000000006e0
Call Trace:
page_idle_bitmap_write+0x8c/0x140
sysfs_kf_bin_write+0x5c/0x70
kernfs_fop_write+0x12e/0x1b0
__vfs_write+0x1b/0x40
vfs_write+0xab/0x1b0
ksys_write+0x55/0xc0
__x64_sys_write+0x1a/0x20
do_syscall_64+0x5a/0x110
entry_SYSCALL_64_after_hwframe+0x44/0xa9
Link: http://lkml.kernel.org/r/20190618124352.28307-1-colin.king@canonical.com
Fixes: 33c3fc71c8cf ("mm: introduce idle page tracking")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-07-10 09:56:30 +02:00
..
2018-08-24 13:26:58 +02:00
2019-06-11 12:23:41 +02:00
2016-03-03 15:07:18 -08:00
2015-09-08 15:35:28 -07:00
2015-04-14 16:49:03 -07:00
2019-06-22 08:18:18 +02:00
2019-06-22 08:18:17 +02:00
2015-08-14 15:56:32 -07:00
2018-01-17 09:35:26 +01:00
2017-11-24 11:26:29 +01:00
2018-09-19 22:49:00 +02:00
2015-11-06 17:50:42 -08:00
2018-02-25 11:03:41 +01:00
2018-09-15 09:40:38 +02:00
2015-11-06 17:50:42 -08:00
2018-05-26 08:48:54 +02:00
2018-12-17 21:55:16 +01:00
2015-06-24 17:49:45 -07:00
2018-12-17 21:55:17 +01:00
2014-08-06 18:01:22 -07:00
2018-11-10 07:41:42 -08:00
2015-11-06 17:50:42 -08:00
2019-06-22 08:18:17 +02:00
2015-09-10 13:29:01 -07:00
2017-01-06 11:16:11 +01:00
2017-08-11 09:08:50 -07:00
2015-02-10 14:30:31 -08:00
2018-05-26 08:48:55 +02:00
2015-01-08 15:10:52 -08:00
2014-10-09 22:25:50 -04:00
2018-05-30 07:49:06 +02:00
2018-05-30 07:49:08 +02:00
2019-06-22 08:18:22 +02:00
2015-11-05 19:34:48 -08:00
2018-10-10 08:52:11 +02:00
2015-09-11 16:42:39 -07:00
2017-06-14 13:16:26 +02:00
2018-07-25 10:18:16 +02:00
2019-03-23 08:44:26 +01:00
2018-01-31 12:06:09 +01:00
2018-12-17 21:55:17 +01:00
2019-04-27 09:33:47 +02:00
2017-08-12 19:29:09 -07:00
2015-09-08 15:35:28 -07:00
2019-03-23 08:44:23 +01:00
2019-06-11 12:23:36 +02:00
2018-12-13 09:21:33 +01:00
2015-06-30 19:44:56 -07:00
2019-06-22 08:18:27 +02:00
2017-12-25 14:22:09 +01:00
2015-09-10 13:29:01 -07:00
2015-02-11 17:06:02 -08:00
2018-08-15 17:42:10 +02:00
2018-11-10 07:41:42 -08:00
2015-11-05 19:34:48 -08:00
2015-06-30 19:44:55 -07:00
2018-12-17 21:55:17 +01:00
2019-02-06 19:43:07 +01:00
2018-07-11 16:03:51 +02:00
2015-11-05 19:34:48 -08:00
2019-04-27 09:33:48 +02:00
2019-07-10 09:56:30 +02:00
2015-08-13 12:32:00 -06:00
2016-04-20 15:41:53 +09:00
2017-11-24 08:32:25 +01:00
2019-01-26 09:42:55 +01:00
2017-11-24 08:32:25 +01:00
2014-09-02 14:46:05 -04:00
2014-09-02 14:46:02 -04:00
2018-05-16 10:06:46 +02:00
2016-02-25 12:01:23 -08:00
2018-12-17 21:55:16 +01:00
2015-11-06 17:50:42 -08:00
2019-04-03 06:23:18 +02:00
2019-03-23 08:44:34 +01:00
2017-10-21 17:09:05 +02:00
2019-04-27 09:33:48 +02:00
2015-11-22 11:58:44 -08:00
2015-11-22 11:58:44 -08:00
2018-10-10 08:52:08 +02:00
2017-07-05 14:37:15 +02:00
2015-09-08 15:35:28 -07:00
2015-11-06 17:50:42 -08:00
2018-08-15 17:42:10 +02:00
2018-12-13 09:21:33 +01:00
2015-09-04 16:54:41 -07:00
2018-12-17 21:55:16 +01:00
2018-09-19 22:49:00 +02:00
2019-04-27 09:33:48 +02:00
2017-03-12 06:37:25 +01:00
2018-06-06 16:46:23 +02:00
2019-04-27 09:34:02 +02:00
2016-10-28 03:01:34 -04:00
2015-11-06 17:50:42 -08:00
2015-11-06 17:50:42 -08:00
2016-05-18 17:06:44 -07:00
2018-09-05 09:18:36 +02:00