iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Thomas Pedersen 4546109c30 mac80211: mesh: fix RCU warning 
[ Upstream commit 551842446ed695641a00782cd118cbb064a416a1 ]

ifmsh->csa is an RCU-protected pointer. The writer context
in ieee80211_mesh_finish_csa() is already mutually
exclusive with wdev->sdata.mtx, but the RCU checker did
not know this. Use rcu_dereference_protected() to avoid a
warning.

fixes the following warning:

[   12.519089] =============================
[   12.520042] WARNING: suspicious RCU usage
[   12.520652] 5.1.0-rc7-wt+ #16 Tainted: G        W
[   12.521409] -----------------------------
[   12.521972] net/mac80211/mesh.c:1223 suspicious rcu_dereference_check() usage!
[   12.522928] other info that might help us debug this:
[   12.523984] rcu_scheduler_active = 2, debug_locks = 1
[   12.524855] 5 locks held by kworker/u8:2/152:
[   12.525438]  #0: 00000000057be08c ((wq_completion)phy0){+.+.}, at: process_one_work+0x1a2/0x620
[   12.526607]  #1: 0000000059c6b07a ((work_completion)(&sdata->csa_finalize_work)){+.+.}, at: process_one_work+0x1a2/0x620
[   12.528001]  #2: 00000000f184ba7d (&wdev->mtx){+.+.}, at: ieee80211_csa_finalize_work+0x2f/0x90
[   12.529116]  #3: 00000000831a1f54 (&local->mtx){+.+.}, at: ieee80211_csa_finalize_work+0x47/0x90
[   12.530233]  #4: 00000000fd06f988 (&local->chanctx_mtx){+.+.}, at: ieee80211_csa_finalize_work+0x51/0x90

Signed-off-by: Thomas Pedersen <thomas@eero.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-07-21 09:07:06 +02:00
..
6lowpan
6lowpan: iphc: reset mac_header after decompress to fix panic
2018-10-10 08:52:04 +02:00
9p
net/9p: include trans_common.h to fix missing prototype warning.
2019-07-10 09:56:35 +02:00
802
…
8021q
vlan: disable SIOCSHWTSTAMP in container
2019-05-16 19:45:17 +02:00
appletalk
appletalk: Fix use-after-free in atalk_proc_exit
2019-04-27 09:33:59 +02:00
atm
net: atm: Fix potential Spectre v1 vulnerabilities
2019-04-27 09:33:59 +02:00
ax25
ax25: fix inconsistent lock state in ax25_destroy_timer
2019-06-22 08:18:25 +02:00
batman-adv
batman-adv: fix uninit-value in batadv_interface_tx()
2019-03-23 08:44:17 +01:00
bluetooth
Bluetooth: Fix faulty expression for minimum encryption key size check
2019-07-10 09:56:38 +02:00
bridge
bridge: Fix error path for kobject_init_and_add()
2019-05-16 19:45:17 +02:00
caif
net: caif: Add a missing rcu_read_unlock() in caif_flow_cb
2018-09-05 09:18:34 +02:00
can
can: purge socket error queue on sock destruct
2019-07-10 09:56:33 +02:00
ceph
libceph: handle an empty authorize reply
2019-03-23 08:44:18 +01:00
core
neigh: fix use-after-free read in pneigh_get_next
2019-06-22 08:18:25 +02:00
dcb
net: dcb: For wild-card lookups, use priority -1, not 0
2018-09-19 22:48:58 +02:00
dccp
dccp: do not use ipv6 header for ipv4 flow
2019-04-03 06:23:25 +02:00
decnet
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock
2018-02-25 11:03:38 +01:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:25:54 +02:00
dsa
net: dsa: slave: Don't propagate flag changes on down slave interfaces
2019-02-20 10:13:15 +01:00
ethernet
net: introduce device min_header_len
2017-02-18 16:39:27 +01:00
hsr
net/hsr: fix possible crash in add_timer()
2019-03-23 08:44:31 +01:00
ieee802154
inet: frags: fix ip6frag_low_thresh boundary
2019-02-08 11:25:32 +01:00
ipv4
ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop
2019-07-10 09:56:37 +02:00
ipv6
ipv6: flowlabel: fl6_sock_lookup() must use atomic_inc_not_zero
2019-06-22 08:18:25 +02:00
ipx
ipx: call ipxitf_put() in ioctl error path
2017-05-25 14:30:13 +02:00
irda
irda: Only insert new objects into the global database via setsockopt
2018-09-15 09:40:40 +02:00
iucv
af_iucv: Move sockaddr length checks to before accessing sa_family in bind and connect handlers
2018-11-10 07:41:35 -08:00
key
af_key: Always verify length of provided sadb_key
2018-06-16 09:54:25 +02:00
l2tp
l2tp: fix infoleak in l2tp_ip6_recvmsg()
2019-03-23 08:44:29 +01:00
l3mdev
net: Add netif_is_l3_slave
2015-10-07 04:27:43 -07:00
lapb
lapb: fixed leak of control-blocks.
2019-06-22 08:18:25 +02:00
llc
llc: fix skb leak in llc_build_and_send_ui_pkt()
2019-06-11 12:24:06 +02:00
mac80211
mac80211: mesh: fix RCU warning
2019-07-21 09:07:06 +02:00
mac802154
net: mac802154: tx: expand tailroom if necessary
2018-09-09 20:04:32 +02:00
mpls
mpls, nospec: Sanitize array index in mpls_label_ok()
2018-03-11 16:19:47 +01:00
netfilter
ipvs: do not schedule icmp errors from tunnels
2019-05-16 19:45:06 +02:00
netlabel
netlabel: check for IPV4MASK in addrinfo_get
2018-10-20 09:52:36 +02:00
netlink
netlink: Don't shift on 64 for ngroups
2018-08-09 12:19:28 +02:00
netrom
netrom: switch to sock timer API
2019-02-06 19:43:06 +01:00
nfc
net: nfc: Fix NULL dereference on nfc_llcp_build_tlv fails
2019-03-23 08:44:22 +01:00
openvswitch
openvswitch: fix flow actions reallocation
2019-04-27 09:33:54 +02:00
packet
packet: Fix error path in packet_init
2019-05-16 19:45:17 +02:00
phonet
phonet: fix building with clang
2019-03-23 08:44:34 +01:00
rds
net: rds: fix memory leak in rds_ib_flush_mr_pool
2019-06-11 12:24:12 +02:00
rfkill
rfkill: gpio: fix memory leak in probe error path
2018-05-16 10:06:51 +02:00
rose
net: rose: fix a possible stack overflow
2019-04-03 06:23:25 +02:00
rxrpc
rxrpc: check return value of skb_to_sgvec always
2018-04-13 19:50:23 +02:00
sched
net: create skb_gso_validate_mac_len()
2019-06-11 12:24:10 +02:00
sctp
sctp: change to hold sk after auth shkey is created successfully
2019-07-10 09:56:36 +02:00
sunrpc
sunrpc: don't mark uninitialised items as VALID.
2019-05-16 19:44:44 +02:00
switchdev
switchdev: pass pointer to fib_info instead of copy
2016-06-24 10:18:16 -07:00
tipc
tipc: check msg->req data len in tipc_nl_compat_bearer_disable
2019-07-10 09:56:37 +02:00
unix
missing barriers in some of unix_sock ->addr and ->path accesses
2019-03-23 08:44:31 +01:00
vmw_vsock
vsock: cope with memory allocation failure at socket creation time
2019-02-23 09:05:13 +01:00
wimax
net:wimax: Fix doucble word "the the" in networking.xml
2015-08-09 22:43:52 -07:00
wireless
cfg80211: fix memory leak of wiphy device name
2019-07-10 09:56:34 +02:00
x25
net/x25: fix a race in x25_bind()
2019-03-23 08:44:30 +01:00
xfrm
xfrm: policy: Fix out-of-bound array accesses in __xfrm_policy_unlink
2019-06-11 12:23:48 +02:00
compat.c
sock: Make sock->sk_stamp thread-safe
2019-01-13 10:05:28 +01:00
Kconfig
Make DST_CACHE a silent config option
2018-02-25 11:03:37 +01:00
Makefile
net: Introduce L3 Master device abstraction
2015-09-29 20:40:32 -07:00
socket.c
sockfs: getxattr: Fail with -EOPNOTSUPP for invalid attribute names
2019-03-23 08:44:21 +01:00
sysctl_net.c
net: Use ns_capable_noaudit() when determining net sysctl permissions
2016-09-15 08:27:50 +02:00