Guillaume Nault 9403cf2302 tcp: free request sock directly upon TFO or syncookies error
Since the request socket is created locally, it'd make more sense to
use reqsk_free() instead of reqsk_put() in TFO and syncookies' error
path.

However, tcp_get_cookie_sock() may set ->rsk_refcnt before freeing the
socket; tcp_conn_request() may also have non-null ->rsk_refcnt because
of tcp_try_fastopen(). In both cases 'req' hasn't been exposed
to the outside world and is safe to free immediately, but that'd
trigger the WARN_ON_ONCE in reqsk_free().

Define __reqsk_free() for these situations where we know nobody's
referencing the socket, even though ->rsk_refcnt might be non-null.
Now we can consolidate the error path of tcp_get_cookie_sock() and
tcp_conn_request().

Signed-off-by: Guillaume Nault <gnault@redhat.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-03-19 14:13:01 -07:00
..
2018-12-25 17:07:49 +09:00
2019-01-23 11:18:00 -08:00
2019-03-19 14:09:32 -07:00
2018-11-10 16:55:11 -08:00
2019-01-27 10:38:04 -08:00
2019-02-21 16:23:56 -08:00
2019-03-09 15:53:03 -08:00
2019-03-08 14:48:40 -08:00
2019-03-11 15:40:14 -07:00
2019-03-16 01:27:51 +01:00
2019-03-15 15:29:47 -07:00