Oleg Nesterov 65450cebc6 pids: de_thread: don't clear session/pgrp pids for the old leader
Based on Eric W. Biederman's idea.

Unless task == current, without tasklist_lock held task_session()/task_pgrp()
can return NULL if the caller races with de_thread() which switches the group
leader.

Change transfer_pid() to not clear old->pids[type].pid for the old leader.
This means that its .pid can point to "nowhere", but this is already true for
sub-threads, and the old leader is not group_leader() any longer.  IOW, with
or without this change we can't trust task's special pids unless it is the
group leader.

With this change the following code

	rcu_read_lock();
	task = find_task_by_xxx();
	do_something(task_pgrp(task), task_session(task));
	rcu_read_unlock();

can't race with exec and hit the NULL pid.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc:  "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Pavel Emelyanov <xemul@openvz.org>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-30 08:29:48 -07:00
..
2008-02-14 21:13:33 -08:00
2008-04-30 08:29:37 -07:00
2008-03-30 14:18:41 -07:00
2008-03-30 14:18:41 -07:00
2008-01-25 21:08:29 +01:00
2008-04-28 08:58:23 -07:00
2007-07-16 09:05:50 -07:00
2008-04-30 08:29:48 -07:00
2008-02-08 09:22:31 -08:00
2008-04-29 08:05:59 -07:00
2008-04-30 08:29:47 -07:00
2008-04-30 08:29:38 -07:00
2008-01-25 21:08:24 +01:00
2008-02-13 16:21:18 -08:00
2008-01-25 21:08:24 +01:00
2008-04-19 19:45:00 +02:00
2008-04-19 19:45:00 +02:00
2007-07-16 09:05:50 -07:00
2008-04-17 10:43:01 -04:00
2008-04-30 08:29:37 -07:00
2008-01-30 13:31:20 +01:00
2008-02-06 10:41:02 -08:00
2008-02-05 09:44:07 -08:00
2008-04-30 08:29:34 -07:00
2008-04-30 08:29:48 -07:00
2008-04-17 12:22:31 +02:00
2008-02-08 09:22:31 -08:00