9030e39cd1
Some selftests assume that nothing will attempt to grab these bitlocks while they are held by the selftests. With GuC, for example, that is not true because the hanging workloads may cause the GuC code to attempt to grab them for a global reset, and that may cause it to end up sleeping on the bit never waking up. Regardless whether that will be the final solution for GuC, use clear_and_wake_up_bit() pending a more thorough investigation on how this should be handled moving forward. To be clear this needs to be a temporary solution. If we can't find an in-kernel locking primitive to use here, we should at the very least add lockdep annotation to these bitlocks with a thorough explanation as to why we need to use bits. v3: - Use GEM_BUG_ON(test_and_set_bit()) rather than set_bit() to verify the assumption that nothing is holding the reset locks when we attempt to grab them. (Chris Wilson) Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20211105150146.834052-1-thomas.hellstrom@linux.intel.com
52 lines
1.1 KiB
C
52 lines
1.1 KiB
C
/*
|
|
* SPDX-License-Identifier: MIT
|
|
*
|
|
* Copyright © 2018 Intel Corporation
|
|
*/
|
|
|
|
#include "igt_reset.h"
|
|
|
|
#include "gt/intel_engine.h"
|
|
#include "gt/intel_gt.h"
|
|
|
|
#include "../i915_drv.h"
|
|
|
|
void igt_global_reset_lock(struct intel_gt *gt)
|
|
{
|
|
struct intel_engine_cs *engine;
|
|
enum intel_engine_id id;
|
|
|
|
pr_debug("%s: current gpu_error=%08lx\n", __func__, gt->reset.flags);
|
|
|
|
while (test_and_set_bit(I915_RESET_BACKOFF, >->reset.flags))
|
|
wait_event(gt->reset.queue,
|
|
!test_bit(I915_RESET_BACKOFF, >->reset.flags));
|
|
|
|
for_each_engine(engine, gt, id) {
|
|
while (test_and_set_bit(I915_RESET_ENGINE + id,
|
|
>->reset.flags))
|
|
wait_on_bit(>->reset.flags, I915_RESET_ENGINE + id,
|
|
TASK_UNINTERRUPTIBLE);
|
|
}
|
|
}
|
|
|
|
void igt_global_reset_unlock(struct intel_gt *gt)
|
|
{
|
|
struct intel_engine_cs *engine;
|
|
enum intel_engine_id id;
|
|
|
|
for_each_engine(engine, gt, id)
|
|
clear_and_wake_up_bit(I915_RESET_ENGINE + id, >->reset.flags);
|
|
|
|
clear_bit(I915_RESET_BACKOFF, >->reset.flags);
|
|
wake_up_all(>->reset.queue);
|
|
}
|
|
|
|
bool igt_force_reset(struct intel_gt *gt)
|
|
{
|
|
intel_gt_set_wedged(gt);
|
|
intel_gt_reset(gt, 0, NULL);
|
|
|
|
return !intel_gt_is_wedged(gt);
|
|
}
|