Reinette Chatre 6744a030d8 dmaengine: idxd: Do not call DMX TX callbacks during workqueue disable
On driver unload any pending descriptors are flushed and pending
DMA descriptors are explicitly completed:
idxd_dmaengine_drv_remove() ->
	drv_disable_wq() ->
		idxd_wq_free_irq() ->
			idxd_flush_pending_descs() ->
				idxd_dma_complete_txd()

With this done during driver unload any remaining descriptor is
likely stuck and can be dropped. Even so, the descriptor may still
have a callback set that could no longer be accessible. An
example of such a problem is when the dmatest fails and the dmatest
module is unloaded. The failure of dmatest leaves descriptors with
dma_async_tx_descriptor::callback pointing to code that no longer
exist. This causes a page fault as below at the time the IDXD driver
is unloaded when it attempts to run the callback:
 BUG: unable to handle page fault for address: ffffffffc0665190
 #PF: supervisor instruction fetch in kernel mode
 #PF: error_code(0x0010) - not-present page

Fix this by clearing the callback pointers on the transmit
descriptors only when workqueue is disabled.

Fixes: 403a2e236538 ("dmaengine: idxd: change MSIX allocation based on per wq activation")
Signed-off-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/37d06b772aa7f8863ca50f90930ea2fd80b38fc3.1670452419.git.reinette.chatre@intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
2022-12-28 16:24:50 +05:30
..
2022-12-13 15:22:14 -08:00
2022-12-13 10:54:19 -08:00
2022-12-19 12:33:32 -06:00
2022-12-16 03:49:24 -08:00
2022-12-12 16:39:38 -08:00
2022-12-19 07:13:33 -06:00
2022-12-19 07:13:33 -06:00
2022-12-08 13:03:47 -08:00
2022-12-16 03:54:54 -08:00
2022-12-21 09:37:14 -08:00
2022-12-16 03:49:24 -08:00
2022-12-21 09:41:28 -08:00
2022-12-13 15:47:48 -08:00
2022-12-13 13:09:38 -08:00
2022-12-11 21:25:58 +01:00
2022-12-16 03:49:24 -08:00
2022-12-19 08:34:39 -06:00
2022-12-13 15:22:14 -08:00
2022-12-21 09:19:24 -08:00
2022-12-23 12:00:24 -08:00
2022-12-13 13:41:26 -08:00
2022-12-13 12:32:07 -08:00
2022-12-22 11:22:31 -08:00
2022-12-20 08:48:24 -06:00
2022-12-19 08:40:58 -06:00
2022-12-19 08:40:58 -06:00
2022-12-13 15:47:48 -08:00
2022-12-21 09:41:28 -08:00
2022-12-23 14:38:00 -08:00
2022-12-21 09:19:24 -08:00
2022-12-16 03:54:54 -08:00
2022-12-19 16:07:59 -06:00
2022-12-19 08:47:33 -06:00
2022-12-23 14:44:08 -08:00
2022-12-14 08:58:51 -08:00
2022-12-12 10:17:08 -08:00
2022-12-14 08:58:51 -08:00
2022-12-16 03:54:54 -08:00
2022-12-21 09:24:39 -08:00
2022-12-16 03:49:24 -08:00
2022-12-17 08:34:01 -06:00
2022-12-13 11:59:58 -08:00