linux/string_helpers.h provides a helper to return "yes"/"no" strings. Replace the open coded versions with str_yes_no(). The places were identified with the following semantic patch: @@ expression b; @@ - b ? "yes" : "no" + str_yes_no(b) Then the includes were added, so we include-what-we-use, and parenthesis adjusted in drivers/gpu/drm/v3d/v3d_debugfs.c. After the conversion we still see the same binary sizes: text data bss dec hex filename 51149 3295 212 54656 d580 virtio/virtio-gpu.ko.old 51149 3295 212 54656 d580 virtio/virtio-gpu.ko 1441491 60340 800 1502631 16eda7 radeon/radeon.ko.old 1441491 60340 800 1502631 16eda7 radeon/radeon.ko 6125369 328538 34000 6487907 62ff63 amd/amdgpu/amdgpu.ko.old 6125369 328538 34000 6487907 62ff63 amd/amdgpu/amdgpu.ko 411986 10490 6176 428652 68a6c drm.ko.old 411986 10490 6176 428652 68a6c drm.ko 98129 1636 264 100029 186bd dp/drm_dp_helper.ko.old 98129 1636 264 100029 186bd dp/drm_dp_helper.ko 1973432 109640 2352 2085424 1fd230 nouveau/nouveau.ko.old 1973432 109640 2352 2085424 1fd230 nouveau/nouveau.ko Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220126093951.1470898-10-lucas.demarchi@intel.com
112 lines
3.7 KiB
C
112 lines
3.7 KiB
C
/*
|
|
* Copyright (C) 2015 Red Hat, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining
|
|
* a copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sublicense, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the
|
|
* next paragraph) shall be included in all copies or substantial
|
|
* portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
|
|
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
|
|
* IN NO EVENT SHALL THE COPYRIGHT OWNER(S) AND/OR ITS SUPPLIERS BE
|
|
* LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
|
|
* OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
|
|
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <linux/string_helpers.h>
|
|
|
|
#include <drm/drm_debugfs.h>
|
|
#include <drm/drm_file.h>
|
|
|
|
#include "virtgpu_drv.h"
|
|
|
|
static void virtio_gpu_add_bool(struct seq_file *m, const char *name,
|
|
bool value)
|
|
{
|
|
seq_printf(m, "%-16s : %s\n", name, str_yes_no(value));
|
|
}
|
|
|
|
static void virtio_gpu_add_int(struct seq_file *m, const char *name, int value)
|
|
{
|
|
seq_printf(m, "%-16s : %d\n", name, value);
|
|
}
|
|
|
|
static int virtio_gpu_features(struct seq_file *m, void *data)
|
|
{
|
|
struct drm_info_node *node = (struct drm_info_node *)m->private;
|
|
struct virtio_gpu_device *vgdev = node->minor->dev->dev_private;
|
|
|
|
virtio_gpu_add_bool(m, "virgl", vgdev->has_virgl_3d);
|
|
virtio_gpu_add_bool(m, "edid", vgdev->has_edid);
|
|
virtio_gpu_add_bool(m, "indirect", vgdev->has_indirect);
|
|
|
|
virtio_gpu_add_bool(m, "resource uuid",
|
|
vgdev->has_resource_assign_uuid);
|
|
|
|
virtio_gpu_add_bool(m, "blob resources", vgdev->has_resource_blob);
|
|
virtio_gpu_add_bool(m, "context init", vgdev->has_context_init);
|
|
virtio_gpu_add_int(m, "cap sets", vgdev->num_capsets);
|
|
virtio_gpu_add_int(m, "scanouts", vgdev->num_scanouts);
|
|
if (vgdev->host_visible_region.len) {
|
|
seq_printf(m, "%-16s : 0x%lx +0x%lx\n", "host visible region",
|
|
(unsigned long)vgdev->host_visible_region.addr,
|
|
(unsigned long)vgdev->host_visible_region.len);
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
virtio_gpu_debugfs_irq_info(struct seq_file *m, void *data)
|
|
{
|
|
struct drm_info_node *node = (struct drm_info_node *) m->private;
|
|
struct virtio_gpu_device *vgdev = node->minor->dev->dev_private;
|
|
|
|
seq_printf(m, "fence %llu %lld\n",
|
|
(u64)atomic64_read(&vgdev->fence_drv.last_fence_id),
|
|
vgdev->fence_drv.current_fence_id);
|
|
return 0;
|
|
}
|
|
|
|
static int
|
|
virtio_gpu_debugfs_host_visible_mm(struct seq_file *m, void *data)
|
|
{
|
|
struct drm_info_node *node = (struct drm_info_node *)m->private;
|
|
struct virtio_gpu_device *vgdev = node->minor->dev->dev_private;
|
|
struct drm_printer p;
|
|
|
|
if (!vgdev->has_host_visible) {
|
|
seq_puts(m, "Host allocations not visible to guest\n");
|
|
return 0;
|
|
}
|
|
|
|
p = drm_seq_file_printer(m);
|
|
drm_mm_print(&vgdev->host_visible_mm, &p);
|
|
return 0;
|
|
}
|
|
|
|
static struct drm_info_list virtio_gpu_debugfs_list[] = {
|
|
{ "virtio-gpu-features", virtio_gpu_features },
|
|
{ "virtio-gpu-irq-fence", virtio_gpu_debugfs_irq_info, 0, NULL },
|
|
{ "virtio-gpu-host-visible-mm", virtio_gpu_debugfs_host_visible_mm },
|
|
};
|
|
|
|
#define VIRTIO_GPU_DEBUGFS_ENTRIES ARRAY_SIZE(virtio_gpu_debugfs_list)
|
|
|
|
void
|
|
virtio_gpu_debugfs_init(struct drm_minor *minor)
|
|
{
|
|
drm_debugfs_create_files(virtio_gpu_debugfs_list,
|
|
VIRTIO_GPU_DEBUGFS_ENTRIES,
|
|
minor->debugfs_root, minor);
|
|
}
|