iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/mm
History
Tetsuo Handa 68aaee147e mm: memcontrol: fix potential oom_lock recursion deadlock 
syzbot is reporting GFP_KERNEL allocation with oom_lock held when
reporting memcg OOM [1].  If this allocation triggers the global OOM
situation then the system can livelock because the GFP_KERNEL
allocation with oom_lock held cannot trigger the global OOM killer
because __alloc_pages_may_oom() fails to hold oom_lock.

Fix this problem by removing the allocation from memory_stat_format()
completely, and pass static buffer when calling from memcg OOM path.

Note that the caller holding filesystem lock was the trigger for syzbot
to report this locking dependency.  Doing GFP_KERNEL allocation with
filesystem lock held can deadlock the system even without involving OOM
situation.

Link: https://syzkaller.appspot.com/bug?extid=2d2aeadc6ce1e1f11d45 [1]
Link: https://lkml.kernel.org/r/86afb39f-8c65-bec2-6cfc-c5e3cd600c0b@I-love.SAKURA.ne.jp
Fixes: c8713d0b23123759 ("mm: memcontrol: dump memory.stat during cgroup OOM")
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reported-by: syzbot <syzbot+2d2aeadc6ce1e1f11d45@syzkaller.appspotmail.com>
Suggested-by: Michal Hocko <mhocko@suse.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Shakeel Butt <shakeelb@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
2022-07-29 18:07:18 -07:00
..
damon
mm/damon/reclaim: fix potential memory leak in damon_reclaim_init()
2022-07-29 18:07:15 -07:00
kasan
kasan: separate double free case from invalid free
2022-07-17 17:14:33 -07:00
kfence
mm: kfence: pass a pointer to virt_to_page()
2022-07-17 17:14:36 -07:00
backing-dev.c
init: Initialize noop_backing_dev_info early
2022-06-16 10:55:57 +02:00
balloon_compaction.c
mm/balloon_compaction: make balloon page compaction callbacks static
2022-03-28 16:52:57 -04:00
bootmem_info.c
bootmem: Use page->index instead of page->freelist
2022-01-06 12:27:03 +01:00
cma_debug.c
mm/cma_debug.c: align the name buffer length as struct cma
2022-07-29 18:07:16 -07:00
cma_sysfs.c
mm: cma: support sysfs
2021-05-05 11:27:24 -07:00
cma.c
Revert "mm/cma.c: remove redundant cma_mutex lock"
2022-05-13 15:11:26 -07:00
cma.h
mm/cma: provide option to opt out from exposing pages on activation failure
2022-03-22 15:57:09 -07:00
compaction.c
mm: compaction: include compound page count for scanning in pageblock isolation
2022-07-29 18:07:14 -07:00
debug_page_ref.c
…
debug_vm_pgtable.c
docs: rename Documentation/vm to Documentation/mm
2022-06-27 12:52:53 -07:00
debug.c
mm: unexport page_init_poison
2022-03-24 19:06:45 -07:00
dmapool.c
mm/dmapool.c: revert "make dma pool to use kmalloc_node"
2022-01-15 16:30:28 +02:00
early_ioremap.c
mm/early_ioremap: declare early_memremap_pgprot_adjust()
2022-03-22 15:57:11 -07:00
fadvise.c
riscv: compat: syscall: Add compat_sys_call_table implementation
2022-04-26 13:36:25 -07:00
failslab.c
mm: fix missing handler for __GFP_NOWARN
2022-05-19 14:08:55 -07:00
filemap.c
filemap: minor cleanup for filemap_write_and_wait_range
2022-07-29 18:07:14 -07:00
folio-compat.c
fs: Remove aop flags parameter from grab_cache_page_write_begin()
2022-05-08 14:28:19 -04:00
frontswap.c
docs: rename Documentation/vm to Documentation/mm
2022-06-27 12:52:53 -07:00
gup_test.c
mm: rename is_pinnable_page() to is_longterm_pinnable_page()
2022-07-17 17:14:27 -07:00
gup_test.h
selftests/vm: gup_test: fix test flag
2021-05-05 11:27:26 -07:00
gup.c
mm/gup.c: fix formatting in check_and_migrate_movable_page()
2022-07-29 18:07:18 -07:00
highmem.c
mm/highmem: pass a pointer to virt_to_page()
2022-07-17 17:14:36 -07:00
hmm.c
mm: teach core mm about pte markers
2022-05-13 07:20:09 -07:00
huge_memory.c
mm/huge_memory: use helper macro IS_ERR_OR_NULL in split_huge_pages_pid
2022-07-17 17:14:47 -07:00
hugetlb_cgroup.c
hugetlb_cgroup: fix wrong hugetlb cgroup numa stat
2022-07-29 18:07:17 -07:00
hugetlb_vmemmap.c
mm: memory_hotplug: make hugetlb_optimize_vmemmap compatible with memmap_on_memory
2022-07-03 18:08:49 -07:00
hugetlb_vmemmap.h
mm: hugetlb_vmemmap: cleanup CONFIG_HUGETLB_PAGE_FREE_VMEMMAP*
2022-04-28 23:16:15 -07:00
hugetlb.c
mm, hugetlb: skip irrelevant nodes in show_free_areas()
2022-07-17 17:14:47 -07:00
hwpoison-inject.c
mm/memory-failure: disable unpoison once hw error happens
2022-06-16 19:11:32 -07:00
init-mm.c
kernel/fork: Initialize mm's PASID
2022-02-14 19:51:47 +01:00
internal.h
mm/gup: migrate device coherent pages when pinning instead of failing
2022-07-17 17:14:28 -07:00
interval_tree.c
…
io-mapping.c
mm: add a io_mapping_map_user helper
2021-04-30 11:20:39 -07:00
ioremap.c
mm: move ioremap_page_range to vmalloc.c
2021-09-08 11:50:24 -07:00
Kconfig
mm/mmap: drop ARCH_HAS_VM_GET_PAGE_PROT
2022-07-17 17:14:41 -07:00
Kconfig.debug
Two followon fixes for the post-5.19 series "Use pageblock_order for cma
2022-05-27 11:40:49 -07:00
khugepaged.c
mm: khugepaged: reorg some khugepaged helpers
2022-07-17 17:14:33 -07:00
kmemleak.c
mm/kmemleak: prevent soft lockup in first object iteration loop of kmemleak_scan()
2022-06-16 19:48:32 -07:00
ksm.c
mm: handling Non-LRU pages returned by vm_normal_pages
2022-07-17 17:14:28 -07:00
list_lru.c
mm: kmem: make mem_cgroup_from_obj() vmalloc()-safe
2022-06-16 19:48:31 -07:00
maccess.c
asm-generic updates for 5.18
2022-03-23 18:03:08 -07:00
madvise.c
mm: handling Non-LRU pages returned by vm_normal_pages
2022-07-17 17:14:28 -07:00
Makefile
mm: shrinkers: introduce debugfs interface for memory shrinkers
2022-07-03 18:08:40 -07:00
mapping_dirty_helpers.c
mm: move tlb_flush_pending inline helpers to mm_inline.h
2022-01-15 16:30:27 +02:00
memblock.c
memblock,arm64: expand the static memblock memory table
2022-07-29 18:07:15 -07:00
memcontrol.c
mm: memcontrol: fix potential oom_lock recursion deadlock
2022-07-29 18:07:18 -07:00
memfd.c
memfd: fix F_SEAL_WRITE after shmem huge page allocated
2022-03-05 11:08:32 -08:00
memory_hotplug.c
mm: memory_hotplug: make hugetlb_optimize_vmemmap compatible with memmap_on_memory
2022-07-03 18:08:49 -07:00
memory-failure.c
mm: introduce mf_dax_kill_procs() for fsdax case
2022-07-17 17:14:30 -07:00
memory.c
mm: remove unneeded PageAnon check in restore_exclusive_pte()
2022-07-29 18:07:16 -07:00
mempolicy.c
mm/mempolicy: remove unneeded out label
2022-07-29 18:07:16 -07:00
mempool.c
mm/mempool: use might_alloc()
2022-06-16 19:48:30 -07:00
memremap.c
mm: add zone device coherent type memory support
2022-07-17 17:14:27 -07:00
memtest.c
…
migrate_device.c
mm/gup: migrate device coherent pages when pinning instead of failing
2022-07-17 17:14:28 -07:00
migrate.c
mm: handling Non-LRU pages returned by vm_normal_pages
2022-07-17 17:14:28 -07:00
mincore.c
mm: teach core mm about pte markers
2022-05-13 07:20:09 -07:00
mlock.c
mm: handling Non-LRU pages returned by vm_normal_pages
2022-07-17 17:14:28 -07:00
mm_init.c
include/linux/page-flags-layout.h: cleanups
2021-04-30 11:20:42 -07:00
mmap_lock.c
mm: mmap_lock: fix disabling preemption directly
2021-07-23 17:43:28 -07:00
mmap.c
mm/mmap.c: fix missing call to vm_unacct_memory in mmap_region
2022-07-29 18:07:13 -07:00
mmu_gather.c
mm/mmu_gather: limit free batch count and add schedule point in tlb_batch_pages_flush
2022-04-28 23:16:12 -07:00
mmu_notifier.c
mm/mmu_notifier.c: fix race in mmu_interval_notifier_remove()
2022-04-21 20:01:10 -07:00
mmzone.c
Folio changes for 5.18
2022-03-22 17:03:12 -07:00
mprotect.c
mm/mprotect: remove the redundant initialization for error
2022-07-17 17:14:47 -07:00
mremap.c
Yang Shi has improved the behaviour of khugepaged collapsing of readonly
2022-05-26 12:32:41 -07:00
msync.c
…
nommu.c
mm: nommu: pass a pointer to virt_to_page()
2022-07-17 17:14:37 -07:00
oom_kill.c
mm/oom_kill.c: fix vm_oom_kill_table[] ifdeffery
2022-06-01 15:57:16 -07:00
page_alloc.c
mm/page_alloc: correct the wrong cpuset file path in comment
2022-07-29 18:07:16 -07:00
page_counter.c
mm/page_counter: remove an incorrect call to propagate_protected_usage()
2022-01-15 16:30:27 +02:00
page_ext.c
mm: use for_each_online_node and node_online instead of open coding
2022-04-29 14:36:58 -07:00
page_idle.c
mm: don't be stuck to rmap lock on reclaim path
2022-05-19 14:08:54 -07:00
page_io.c
Yang Shi has improved the behaviour of khugepaged collapsing of readonly
2022-05-26 12:32:41 -07:00
page_isolation.c
mm/page_isolation.c: fix one kernel-doc comment
2022-06-16 19:11:30 -07:00
page_owner.c
Yang Shi has improved the behaviour of khugepaged collapsing of readonly
2022-05-26 12:32:41 -07:00
page_poison.c
…
page_reporting.c
mm/page_reporting: allow driver to specify reporting order
2021-06-29 10:53:47 -07:00
page_reporting.h
mm/page_reporting: export reporting order as module parameter
2021-06-29 10:53:47 -07:00
page_table_check.c
Six hotfixes. One from Miaohe Lin is considered a minor thing so it isn't
2022-05-27 11:29:35 -07:00
page_vma_mapped.c
mm/page_vma_mapped.c: use helper function huge_pte_lock
2022-07-17 17:14:47 -07:00
page-writeback.c
sysctl changes for v5.19-rc1
2022-05-26 16:57:20 -07:00
pagewalk.c
mm: pagewalk: fix walk for hugepage tables
2021-06-29 10:53:49 -07:00
percpu-internal.h
percpu: improve percpu_alloc_percpu event trace
2022-05-13 07:20:18 -07:00
percpu-km.c
percpu: flush tlb in pcpu_reclaim_populated()
2021-07-04 18:30:17 +00:00
percpu-stats.c
mm: use vmalloc_array and vcalloc for array allocations
2022-03-08 09:30:46 -05:00
percpu-vm.c
percpu: flush tlb in pcpu_reclaim_populated()
2021-07-04 18:30:17 +00:00
percpu.c
mm: percpu: use kmemleak_ignore_phys() instead of kmemleak_free()
2022-07-17 17:14:47 -07:00
pgalloc-track.h
mm: fix typos in comments
2021-05-07 00:26:35 -07:00
pgtable-generic.c
mm: avoid unnecessary flush on change_huge_pmd()
2022-05-13 07:20:05 -07:00
process_vm_access.c
mm/process_vm_access.c: remove duplicate include
2021-05-05 11:27:27 -07:00
ptdump.c
mm: sparsemem: use page table lock to protect kernel pmd operations
2022-03-22 15:57:08 -07:00
readahead.c
filemap: Fix serialization adding transparent huge pages to page cache
2022-06-23 12:22:00 -04:00
rmap.c
hugetlb: do not update address in huge_pmd_unshare
2022-07-17 17:14:34 -07:00
rodata_test.c
…
secretmem.c
secretmem: Convert to free_folio
2022-05-09 23:12:53 -04:00
shmem.c
mm/shmem: support FS_IOC_[SG]ETFLAGS in tmpfs
2022-07-29 18:07:15 -07:00
shrinker_debug.c
mm: shrinkers: fix double kfree on shrinker name
2022-07-29 18:07:13 -07:00
shuffle.c
…
shuffle.h
mm/shuffle: fix section mismatch warning
2021-05-22 15:09:07 -10:00
slab_common.c
Yang Shi has improved the behaviour of khugepaged collapsing of readonly
2022-05-26 12:32:41 -07:00
slab.c
mm/slab: delete cache_alloc_debugcheck_before()
2022-06-16 19:48:29 -07:00
slab.h
slab changes for 5.19
2022-05-25 10:24:04 -07:00
slob.c
mm: make minimum slab alignment a runtime property
2022-05-13 07:20:07 -07:00
slub.c
mm/slub: add missing TID updates on slab deactivation
2022-06-13 17:41:36 +02:00
sparse-vmemmap.c
mm: sparsemem: drop unexpected word 'a' in comments
2022-07-03 18:08:50 -07:00
sparse.c
mm: memory_hotplug: enumerate all supported section flags
2022-07-03 18:08:49 -07:00
swap_cgroup.c
mm: use vmalloc_array and vcalloc for array allocations
2022-03-08 09:30:46 -05:00
swap_slots.c
mm/swap: remove buggy cache->nr check in refill_swap_slots_cache
2022-05-19 14:08:51 -07:00
swap_state.c
mm/swap: convert __delete_from_swap_cache() to a folio
2022-07-03 18:08:48 -07:00
swap.c
mm: convert destroy_compound_page() to destroy_large_folio()
2022-07-03 18:08:48 -07:00
swap.h
mm/khugepaged: try to free transhuge swapcache when possible
2022-07-03 18:08:52 -07:00
swapfile.c
mm/swap: convert delete_from_swap_cache() to take a folio
2022-07-03 18:08:48 -07:00
truncate.c
Filesystem folio changes for 5.18
2022-03-22 18:26:56 -07:00
usercopy.c
usercopy: Make usercopy resilient against ridiculously large copies
2022-06-13 09:54:52 -07:00
userfaultfd.c
mm/uffd: enable write protection for shmem & hugetlbfs
2022-05-13 07:20:11 -07:00
util.c
docs: rename Documentation/vm to Documentation/mm
2022-06-27 12:52:53 -07:00
vmacache.c
…
vmalloc.c
mm/vmalloc: extend __find_vmap_area() with one more argument
2022-07-03 18:08:41 -07:00
vmpressure.c
mm/vmpressure: fix data-race with memcg->socket_pressure
2021-11-06 13:30:40 -07:00
vmscan.c
mm: vmpressure: don't count proactive reclaim in vmpressure
2022-07-29 18:07:15 -07:00
vmstat.c
Bitmap patches for 5.19-rc1
2022-06-04 14:04:27 -07:00
workingset.c
mm: shrinkers: provide shrinkers with names
2022-07-03 18:08:40 -07:00
z3fold.c
mm/z3fold: fix z3fold_page_migrate races with z3fold_map
2022-05-27 09:33:44 -07:00
zbud.c
mm/zbud: add kerneldoc fields for zbud_pool
2021-07-01 11:06:03 -07:00
zpool.c
zpool: remove the list of pools_head
2022-01-15 16:30:31 +02:00
zsmalloc.c
zsmalloc: zs_malloc: return ERR_PTR on failure
2022-07-29 18:07:15 -07:00
zswap.c
zswap: memcg accounting
2022-05-19 14:08:53 -07:00