Eric Dumazet
68f40354a3
netfilter: nfnetlink_queue: acquire rcu_read_lock() in instance_destroy_rcu()
...
[ Upstream commit dc21c6cc3d6986d938efbf95de62473982c98dec ]
syzbot reported that nf_reinject() could be called without rcu_read_lock() :
WARNING: suspicious RCU usage
6.9.0-rc7-syzkaller-02060-g5c1672705a1a #0 Not tainted
net/netfilter/nfnetlink_queue.c:263 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 2, debug_locks = 1
2 locks held by syz-executor.4/13427:
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline]
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_do_batch kernel/rcu/tree.c:2190 [inline]
#0 : ffffffff8e334f60 (rcu_callback){....}-{0:0}, at: rcu_core+0xa86/0x1830 kernel/rcu/tree.c:2471
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: nfqnl_flush net/netfilter/nfnetlink_queue.c:405 [inline]
#1 : ffff88801ca92958 (&inst->lock){+.-.}-{2:2}, at: instance_destroy_rcu+0x30/0x220 net/netfilter/nfnetlink_queue.c:172
stack backtrace:
CPU: 0 PID: 13427 Comm: syz-executor.4 Not tainted 6.9.0-rc7-syzkaller-02060-g5c1672705a1a #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
<IRQ>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
lockdep_rcu_suspicious+0x221/0x340 kernel/locking/lockdep.c:6712
nf_reinject net/netfilter/nfnetlink_queue.c:323 [inline]
nfqnl_reinject+0x6ec/0x1120 net/netfilter/nfnetlink_queue.c:397
nfqnl_flush net/netfilter/nfnetlink_queue.c:410 [inline]
instance_destroy_rcu+0x1ae/0x220 net/netfilter/nfnetlink_queue.c:172
rcu_do_batch kernel/rcu/tree.c:2196 [inline]
rcu_core+0xafd/0x1830 kernel/rcu/tree.c:2471
handle_softirqs+0x2d6/0x990 kernel/softirq.c:554
__do_softirq kernel/softirq.c:588 [inline]
invoke_softirq kernel/softirq.c:428 [inline]
__irq_exit_rcu+0xf4/0x1c0 kernel/softirq.c:637
irq_exit_rcu+0x9/0x30 kernel/softirq.c:649
instr_sysvec_apic_timer_interrupt arch/x86/kernel/apic/apic.c:1043 [inline]
sysvec_apic_timer_interrupt+0xa6/0xc0 arch/x86/kernel/apic/apic.c:1043
</IRQ>
<TASK>
Fixes: 9872bec773c2 ("[NETFILTER]: nfnetlink: use RCU for queue instances hash")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2024-06-12 11:03:53 +02:00
..
2024-02-23 09:12:50 +01:00
2024-05-02 16:29:25 +02:00
2024-03-06 14:45:08 +00:00
2022-08-17 08:46:30 +02:00
2022-10-03 09:17:32 -07:00
2022-05-16 13:05:40 +02:00
2022-02-04 06:30:28 +01:00
2023-10-06 14:56:38 +02:00
2022-07-11 16:25:15 +02:00
2024-03-06 14:45:08 +00:00
2023-03-11 13:55:24 +01:00
2022-01-09 23:30:13 +01:00
2023-10-06 14:56:36 +02:00
2022-09-20 23:50:03 +02:00
2024-03-15 10:48:16 -04:00
2022-08-11 16:50:49 +02:00
2023-07-19 16:22:16 +02:00
2022-09-07 15:55:23 +02:00
2022-02-04 06:30:28 +01:00
2022-01-11 10:41:44 +01:00
2023-06-09 10:34:15 +02:00
2022-07-11 16:25:15 +02:00
2023-07-19 16:21:13 +02:00
2021-07-02 02:07:01 +02:00
2021-06-18 14:47:43 +02:00
2022-12-31 13:32:19 +01:00
2024-03-01 13:26:27 +01:00
2024-03-06 14:45:08 +00:00
2022-03-03 13:35:22 +01:00
2022-05-13 18:56:27 +02:00
2022-08-11 16:50:25 +02:00
2022-02-04 06:30:28 +01:00
2023-07-19 16:21:13 +02:00
2023-05-24 17:32:32 +01:00
2022-07-11 16:25:15 +02:00
2022-02-04 06:30:28 +01:00
2022-06-21 10:50:41 +02:00
2024-03-01 13:26:37 +01:00
2024-04-27 17:07:07 +02:00
2024-04-27 17:07:08 +02:00
2024-01-10 17:10:34 +01:00
2022-07-11 16:25:14 +02:00
2021-08-30 01:51:36 +02:00
2020-05-27 22:20:34 +02:00
2024-01-25 15:27:51 -08:00
2024-02-05 20:13:02 +00:00
2022-09-07 16:46:04 +02:00
2022-10-03 09:17:32 -07:00
2022-11-02 10:47:22 +01:00
2022-09-07 16:46:04 +02:00
2022-09-07 16:46:04 +02:00
2022-09-07 16:46:04 +02:00
2022-05-13 18:56:27 +02:00
2021-04-26 03:20:07 +02:00
2023-11-20 11:52:17 +01:00
2022-09-07 16:46:04 +02:00
2024-01-25 15:27:51 -08:00
2020-07-24 15:41:54 -07:00
2022-07-15 11:49:55 +01:00
2024-04-27 17:07:07 +02:00
2024-01-10 17:10:21 +01:00
2022-06-06 19:19:15 +02:00
2022-06-27 19:22:54 +02:00
2021-05-29 01:04:53 +02:00
2022-07-11 16:25:15 +02:00
2022-06-17 23:31:20 +02:00
2022-08-22 14:26:30 +01:00
2024-01-25 15:27:50 -08:00
2023-09-19 12:28:03 +02:00
2024-06-12 11:03:53 +02:00
2023-06-21 16:00:58 +02:00
2023-06-14 11:15:20 +02:00
2023-11-28 17:07:05 +00:00
2024-05-02 16:29:26 +02:00
2021-05-29 01:04:54 +02:00
2021-05-29 01:04:54 +02:00
2022-08-09 20:13:29 +02:00
2024-03-06 14:45:08 +00:00
2022-04-05 11:55:46 +02:00
2022-04-05 11:55:46 +02:00
2024-03-15 10:48:16 -04:00
2022-03-20 00:29:46 +01:00
2023-12-13 18:39:11 +01:00
2023-12-13 18:39:11 +01:00
2022-03-20 00:29:47 +01:00
2022-03-20 00:29:47 +01:00
2023-12-13 18:39:11 +01:00
2024-03-01 13:26:37 +01:00
2022-03-20 00:29:46 +01:00
2022-03-20 00:29:47 +01:00
2024-01-10 17:10:24 +01:00
2023-03-17 08:50:23 +01:00
2024-01-31 16:17:05 -08:00
2022-03-20 00:29:46 +01:00
2023-05-11 23:03:42 +09:00
2023-03-22 13:33:42 +01:00
2023-11-28 17:07:05 +00:00
2024-01-31 16:17:06 -08:00
2022-06-08 12:30:59 +02:00
2023-08-16 18:27:30 +02:00
2022-09-07 16:46:03 +02:00
2023-10-25 12:03:05 +02:00
2022-07-26 21:12:42 +02:00
2023-03-17 08:50:23 +01:00
2022-08-09 20:13:29 +02:00
2023-11-20 11:52:17 +01:00
2022-03-20 00:29:46 +01:00
2022-03-20 00:29:46 +01:00
2020-10-31 10:40:42 +01:00
2024-01-31 16:17:06 -08:00
2023-06-28 11:12:32 +02:00
2023-10-06 14:56:35 +02:00
2024-02-23 09:12:28 +01:00
2021-05-29 01:04:27 +02:00
2024-04-27 17:07:07 +02:00
2024-02-16 19:06:28 +01:00
2024-02-16 19:06:32 +01:00
2024-01-31 16:17:06 -08:00
2024-01-31 16:17:06 -08:00
2024-01-31 16:17:06 -08:00
2024-02-05 20:13:01 +00:00
2024-01-31 16:17:06 -08:00
2020-10-30 12:57:39 +01:00
2022-09-07 16:46:03 +02:00
2021-06-01 23:53:51 +02:00
2021-08-17 00:45:07 +02:00
2022-07-11 16:40:45 +02:00
2022-11-18 15:21:00 +01:00
2020-07-29 20:09:18 +02:00
2022-07-11 16:25:15 +02:00
2022-07-11 16:40:45 +02:00
2022-01-22 08:33:37 +02:00
2020-08-28 19:55:51 +02:00
2021-11-08 12:14:05 +01:00
2024-01-10 17:10:21 +01:00
2021-05-29 01:04:52 +02:00
2021-09-21 03:46:56 +02:00
2020-06-25 00:50:31 +02:00
2020-12-01 09:45:29 +01:00
2021-09-21 03:46:56 +02:00
2023-06-28 11:12:33 +02:00
2023-12-13 18:39:11 +01:00
2024-01-25 15:27:51 -08:00
2022-09-07 16:46:03 +02:00
2023-11-20 11:52:17 +01:00
2023-11-20 11:52:17 +01:00
2023-09-13 09:42:59 +02:00
2021-05-03 23:02:44 +02:00
2023-08-11 12:08:14 +02:00
2022-10-11 17:42:58 -06:00
2022-07-11 16:40:45 +02:00
2020-07-29 20:09:18 +02:00
2022-07-21 00:56:00 +02:00
2021-03-31 22:34:10 +02:00
2023-09-13 09:42:59 +02:00