Willy Tarreau 695309c5c7 secure_seq: use the 64 bits of the siphash for port offset calculation
commit b2d057560b8107c633b39aabe517ff9d93f285e3 upstream.

SipHash replaced MD5 in secure_ipv{4,6}_port_ephemeral() via commit
7cd23e5300c1 ("secure_seq: use SipHash in place of MD5"), but the output
remained truncated to 32-bit only. In order to exploit more bits from the
hash, let's make the functions return the full 64-bit of siphash_3u32().
We also make sure the port offset calculation in __inet_hash_connect()
remains done on 32-bit to avoid the need for div_u64_rem() and an extra
cost on 32-bit systems.

Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Moshe Kol <moshe.kol@mail.huji.ac.il>
Cc: Yossi Gilad <yossi.gilad@mail.huji.ac.il>
Cc: Amit Klein <aksecurity@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
[SG: Adjusted context]
Signed-off-by: Stefan Ghinea <stefan.ghinea@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-06-06 08:24:20 +02:00
..
2019-07-03 13:14:42 +02:00
2021-06-10 13:24:06 +02:00
2019-03-23 20:09:51 +01:00
2022-01-05 12:34:58 +01:00
2018-02-28 11:43:28 -05:00
2019-11-10 11:27:54 +01:00
2020-07-22 09:31:58 +02:00
2017-12-11 14:10:06 -05:00
2021-08-04 12:23:46 +02:00
2018-06-18 22:40:32 +02:00
2018-04-07 22:32:31 -04:00
2017-11-08 16:12:33 +09:00
2021-12-14 10:18:04 +01:00
2018-05-16 07:23:35 +02:00
2018-05-16 07:23:35 +02:00
2018-06-22 13:43:27 +09:00
2018-06-22 13:43:27 +09:00
2018-04-17 13:53:13 -04:00