Amir Goldstein 695b46e76b ovl: set i_ino to the value of st_ino for NFS export
Eddie Horng reported that readdir of an overlayfs directory that
was exported via NFSv3 returns entries with d_type set to DT_UNKNOWN.
The reason is that while preparing the response for readdirplus, nfsd
checks inside encode_entryplus_baggage() that a child dentry's inode
number matches the value of d_ino returns by overlayfs readdir iterator.

Because the overlayfs inodes use arbitrary inode numbers that are not
correlated with the values of st_ino/d_ino, NFSv3 falls back to not
encoding d_type. Although this is an allowed behavior, we can fix it for
the case of all overlayfs layers on the same underlying filesystem.

When NFS export is enabled and d_ino is consistent with st_ino
(samefs), set the same value also to i_ino in ovl_fill_inode() for all
overlayfs inodes, nfsd readdirplus sanity checks will pass.
ovl_fill_inode() may be called from ovl_new_inode(), before real inode
was created with ino arg 0. In that case, i_ino will be updated to real
upper inode i_ino on ovl_inode_init() or ovl_inode_update().

Reported-by: Eddie Horng <eddiehorng.tw@gmail.com>
Tested-by: Eddie Horng <eddiehorng.tw@gmail.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Fixes: 8383f1748829 ("ovl: wire up NFS export operations")
Cc: <stable@vger.kernel.org> #v4.16
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
2018-04-12 12:04:48 +02:00
..
2018-02-06 14:43:37 +00:00
2018-03-16 13:37:42 -07:00
2018-02-07 14:25:22 -08:00
2018-02-07 14:25:22 -08:00
2017-11-16 11:41:22 -08:00
2018-01-24 17:33:57 -05:00
2018-02-06 18:32:45 -08:00
2018-01-01 10:09:33 -05:00
2018-02-07 14:25:22 -08:00
2017-09-04 19:05:15 -04:00
2018-02-06 18:32:45 -08:00
2017-04-17 12:52:27 -04:00
2018-01-03 10:13:36 -08:00
2017-12-07 14:23:30 -05:00
2018-01-29 07:27:24 -08:00
2018-02-06 10:41:33 -08:00
2018-02-08 15:18:32 -08:00
2017-12-09 20:16:33 -05:00