Andrey Ryabinin
7d3996c74c
stackdepot: respect __GFP_NOLOCKDEP allocation flag
...
commit 6fe60465e1d53ea321ee909be26d97529e8f746c upstream.
If stack_depot_save_flags() allocates memory it always drops
__GFP_NOLOCKDEP flag. So when KASAN tries to track __GFP_NOLOCKDEP
allocation we may end up with lockdep splat like bellow:
======================================================
WARNING: possible circular locking dependency detected
6.9.0-rc3+ #49 Not tainted
------------------------------------------------------
kswapd0/149 is trying to acquire lock:
ffff88811346a920
(&xfs_nondir_ilock_class){++++}-{4:4}, at: xfs_reclaim_inode+0x3ac/0x590
[xfs]
but task is already holding lock:
ffffffff8bb33100 (fs_reclaim){+.+.}-{0:0}, at:
balance_pgdat+0x5d9/0xad0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (fs_reclaim){+.+.}-{0:0}:
__lock_acquire+0x7da/0x1030
lock_acquire+0x15d/0x400
fs_reclaim_acquire+0xb5/0x100
prepare_alloc_pages.constprop.0+0xc5/0x230
__alloc_pages+0x12a/0x3f0
alloc_pages_mpol+0x175/0x340
stack_depot_save_flags+0x4c5/0x510
kasan_save_stack+0x30/0x40
kasan_save_track+0x10/0x30
__kasan_slab_alloc+0x83/0x90
kmem_cache_alloc+0x15e/0x4a0
__alloc_object+0x35/0x370
__create_object+0x22/0x90
__kmalloc_node_track_caller+0x477/0x5b0
krealloc+0x5f/0x110
xfs_iext_insert_raw+0x4b2/0x6e0 [xfs]
xfs_iext_insert+0x2e/0x130 [xfs]
xfs_iread_bmbt_block+0x1a9/0x4d0 [xfs]
xfs_btree_visit_block+0xfb/0x290 [xfs]
xfs_btree_visit_blocks+0x215/0x2c0 [xfs]
xfs_iread_extents+0x1a2/0x2e0 [xfs]
xfs_buffered_write_iomap_begin+0x376/0x10a0 [xfs]
iomap_iter+0x1d1/0x2d0
iomap_file_buffered_write+0x120/0x1a0
xfs_file_buffered_write+0x128/0x4b0 [xfs]
vfs_write+0x675/0x890
ksys_write+0xc3/0x160
do_syscall_64+0x94/0x170
entry_SYSCALL_64_after_hwframe+0x71/0x79
Always preserve __GFP_NOLOCKDEP to fix this.
Link: https://lkml.kernel.org/r/20240418141133.22950-1-ryabinin.a.a@gmail.com
Fixes: cd11016e5f52 ("mm, kasan: stackdepot implementation. Enable stackdepot for SLAB")
Signed-off-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Reported-by: Xiubo Li <xiubli@redhat.com>
Closes: https://lore.kernel.org/all/a0caa289-ca02-48eb-9bf2-d86fd47b71f4@redhat.com/
Reported-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Closes: https://lore.kernel.org/all/f9ff999a-e170-b66b-7caf-293f2b147ac2@opensource.wdc.com/
Suggested-by: Dave Chinner <david@fromorbit.com>
Tested-by: Xiubo Li <xiubli@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-05-02 16:18:36 +02:00
..
2019-07-03 16:57:17 +02:00
2022-06-22 14:11:02 +02:00
2023-05-30 12:44:01 +01:00
2023-01-18 11:40:54 +01:00
2019-02-06 11:01:57 +01:00
2022-04-15 14:18:39 +02:00
2020-06-17 16:40:28 +02:00
2019-05-21 10:50:46 +02:00
2023-09-23 11:00:03 +02:00
2022-04-15 14:18:23 +02:00
2019-07-02 08:41:37 +02:00
2022-12-08 11:22:59 +01:00
2021-11-17 09:48:31 +01:00
2019-05-21 10:50:46 +02:00
2020-06-24 17:50:39 +02:00
2019-09-15 19:42:16 +02:00
2018-08-22 10:52:48 -07:00
2018-06-12 16:19:22 -07:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:39:02 +02:00
2019-05-24 17:27:11 +02:00
2022-06-06 08:33:50 +02:00
2019-05-30 11:26:32 -07:00
2019-06-03 12:32:56 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-10-12 09:17:46 +02:00
2019-07-25 15:47:37 +02:00
2019-05-21 10:50:45 +02:00
2019-06-05 17:37:10 +02:00
2019-06-05 17:37:16 +02:00
2018-08-16 12:14:42 -07:00
2021-05-14 09:44:27 +02:00
2019-05-24 17:27:11 +02:00
2018-11-30 07:22:05 +01:00
2019-05-30 11:26:32 -07:00
2017-11-02 11:10:55 +01:00
2019-05-30 11:26:32 -07:00
2023-08-30 16:27:25 +02:00
2017-11-02 11:10:55 +01:00
2019-06-19 17:09:06 +02:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2023-06-14 10:59:56 +02:00
2019-03-12 10:04:02 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2017-09-26 15:01:20 -06:00
2019-06-19 17:09:06 +02:00
2020-10-29 09:57:52 +01:00
2018-07-27 19:04:33 +08:00
2020-11-10 12:37:27 +01:00
2018-08-22 10:52:48 -07:00
2019-06-19 17:09:06 +02:00
2019-06-19 17:09:06 +02:00
2020-08-19 08:15:54 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2023-07-27 08:37:41 +02:00
2018-06-12 23:33:24 +02:00
2018-07-27 19:16:38 +08:00
2017-11-02 11:10:55 +01:00
2021-07-20 16:10:46 +02:00
2019-05-24 17:37:53 +02:00
2021-11-17 09:48:31 +01:00
2017-11-02 11:10:55 +01:00
2020-08-21 13:05:32 +02:00
2019-07-10 18:43:43 -07:00
2019-11-06 08:47:50 -08:00
2023-06-09 10:29:02 +02:00
2017-11-15 11:56:19 -08:00
2019-06-05 17:36:37 +02:00
2019-04-09 14:19:06 +02:00
2018-04-27 08:51:26 -04:00
2019-09-25 17:51:39 -07:00
2019-06-18 13:47:24 +02:00
2019-06-05 17:36:38 +02:00
2020-04-13 10:48:07 +02:00
2017-11-02 11:10:55 +01:00
2018-07-27 19:04:33 +08:00
2018-12-29 11:36:44 -08:00
2021-01-12 20:16:10 +01:00
2019-10-14 15:04:00 -07:00
2017-02-24 17:46:57 -08:00
2017-02-24 17:46:57 -08:00
2022-05-09 09:03:22 +02:00
2019-05-13 11:07:33 +02:00
2024-01-25 14:34:21 -08:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:56 +02:00
2019-01-22 13:39:59 +01:00
2018-05-09 06:55:44 +02:00
2019-07-16 19:23:22 -07:00
2023-01-18 11:41:55 +01:00
2019-02-19 20:52:19 -07:00
2019-05-30 11:26:32 -07:00
2019-05-24 17:27:11 +02:00
2017-11-02 11:10:55 +01:00
2022-03-19 13:40:16 +01:00
2022-12-08 11:23:05 +01:00
2019-09-24 15:54:07 -07:00
2019-05-21 10:50:46 +02:00
2019-05-21 10:50:46 +02:00
2019-08-30 18:47:15 -07:00
2019-06-19 17:09:08 +02:00
2021-05-19 10:08:33 +02:00
2023-11-08 11:23:38 +01:00
2021-07-14 16:53:16 +02:00
2021-07-14 16:53:16 +02:00
2019-05-30 11:26:32 -07:00
2022-08-25 11:18:36 +02:00
2019-06-20 14:07:34 -06:00
2019-06-05 17:37:06 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-02-28 07:55:43 +01:00
2023-02-06 07:52:42 +01:00
2021-03-17 17:03:44 +01:00
2019-05-24 17:37:53 +02:00
2019-05-24 17:39:02 +02:00
2021-05-07 10:51:37 +02:00
2018-10-16 13:45:44 +02:00
2019-05-21 10:50:45 +02:00
2017-11-02 11:10:55 +01:00
2019-05-24 17:39:02 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2023-02-06 07:52:45 +01:00
2018-07-09 14:10:40 +02:00
2022-06-14 18:12:02 +02:00
2023-01-18 11:40:55 +01:00
2017-11-02 11:10:55 +01:00
2019-06-05 19:03:39 -07:00
2019-05-21 10:50:45 +02:00
2019-05-24 17:27:11 +02:00
2022-10-26 13:22:27 +02:00
2019-05-03 10:49:17 -04:00
2017-02-03 16:35:42 -05:00
2019-06-19 17:09:06 +02:00
2018-01-26 11:45:16 -06:00
2018-08-30 12:56:40 +02:00
2019-05-21 10:50:45 +02:00
2019-07-14 16:17:18 -07:00
2019-05-21 11:28:45 +02:00
2019-05-21 10:50:45 +02:00
2023-08-30 16:27:26 +02:00
2022-06-22 14:11:13 +02:00
2022-09-05 10:27:42 +02:00
2019-09-25 17:51:39 -07:00
2019-07-16 19:23:22 -07:00
2022-07-29 17:14:17 +02:00
2019-06-19 17:09:55 +02:00
2020-01-12 12:21:44 +01:00
2020-11-05 11:43:22 +01:00
2021-07-19 08:53:16 +02:00
2019-07-11 15:17:41 -07:00
2019-08-08 07:45:01 -06:00
2022-06-22 14:11:03 +02:00
2019-09-24 15:54:09 -07:00
2022-06-22 14:11:16 +02:00
2019-06-03 11:49:37 +02:00
2019-08-19 13:14:53 -03:00
2024-05-02 16:18:36 +02:00
2019-05-30 11:26:32 -07:00
2019-07-16 19:23:22 -07:00
2020-10-01 13:18:23 +02:00
2020-01-29 16:45:29 +01:00
2020-01-29 16:45:29 +01:00
2020-12-11 13:23:32 +01:00
2018-06-27 18:58:49 +03:00
2019-05-21 10:50:45 +02:00
2024-03-26 18:22:15 -04:00
2021-09-22 12:26:29 +02:00
2019-05-21 10:50:45 +02:00
2023-08-11 11:54:00 +02:00
2019-05-21 10:50:45 +02:00
2018-11-30 12:13:15 -08:00
2024-01-25 14:34:21 -08:00
2020-06-22 09:31:12 +02:00
2022-04-15 14:18:21 +02:00
2019-05-21 10:50:45 +02:00
2018-10-16 13:45:44 +02:00
2023-10-25 11:53:17 +02:00
2019-05-21 10:50:45 +02:00
2020-06-30 15:37:04 -04:00
2019-07-16 19:23:22 -07:00
2017-02-26 11:03:38 -05:00
2020-05-27 17:46:43 +02:00
2019-06-19 17:09:55 +02:00
2017-01-09 13:58:57 -05:00
2019-05-21 10:50:45 +02:00
2021-09-22 12:26:38 +02:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-16 19:23:22 -07:00
2019-04-08 16:44:21 -06:00
2019-05-14 19:52:51 -07:00
2019-03-07 18:32:00 -08:00
2019-10-16 14:56:21 +02:00
2017-07-21 09:38:30 +02:00
2019-05-14 19:52:49 -07:00
2022-04-15 14:18:28 +02:00
2019-10-03 12:12:23 -04:00
2019-07-24 17:38:01 +02:00
2023-07-27 08:37:12 +02:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-01-09 10:20:07 +01:00
2019-05-06 11:12:09 -07:00
2019-05-24 17:39:02 +02:00
2018-06-07 17:34:39 -07:00
2023-02-25 11:53:26 +01:00
2019-05-30 11:26:41 -07:00
2022-06-22 14:11:13 +02:00
2017-11-02 11:10:55 +01:00
2022-04-15 14:18:28 +02:00
2017-08-15 09:02:07 -07:00