Eric Dumazet
ac1968ac39
af_unix: fix struct pid leaks in OOB support ...
[ Upstream commit 2aab4b96900272885bc157f8b236abf1cdc02e08 ]
syzbot reported struct pid leak [1].
Issue is that queue_oob() calls maybe_add_creds() which potentially
holds a reference on a pid.
But skb->destructor is not set (either directly or by calling
unix_scm_to_skb())
This means that subsequent kfree_skb() or consume_skb() would leak
this reference.
In this fix, I chose to fully support scm even for the OOB message.
[1]
BUG: memory leak
unreferenced object 0xffff8881053e7f80 (size 128):
comm "syz-executor242", pid 5066, jiffies 4294946079 (age 13.220s)
hex dump (first 32 bytes):
01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<ffffffff812ae26a>] alloc_pid+0x6a/0x560 kernel/pid.c:180
[<ffffffff812718df>] copy_process+0x169f/0x26c0 kernel/fork.c:2285
[<ffffffff81272b37>] kernel_clone+0xf7/0x610 kernel/fork.c:2684
[<ffffffff812730cc>] __do_sys_clone+0x7c/0xb0 kernel/fork.c:2825
[<ffffffff849ad699>] do_syscall_x64 arch/x86/entry/common.c:50 [inline]
[<ffffffff849ad699>] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
[<ffffffff84a0008b>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
Fixes: 314001f0bf92 ("af_unix: Add OOB support")
Reported-by: syzbot+7699d9e5635c10253a27@syzkaller.appspotmail.com
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Rao Shoaib <rao.shoaib@oracle.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://lore.kernel.org/r/20230307164530.771896-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-03-17 08:50:28 +01:00
2023-03-11 13:55:26 +01:00
2022-12-31 13:33:02 +01:00
2022-08-25 10:33:21 +02:00
2022-10-15 11:08:36 +01:00
2022-08-22 17:55:50 -07:00
2022-09-22 13:02:10 -07:00
2023-03-10 09:33:01 +01:00
2023-03-17 08:50:26 +01:00
2023-03-11 13:55:24 +01:00
2023-03-17 08:50:24 +01:00
2023-03-10 09:33:51 +01:00
2023-02-09 11:28:04 +01:00
2023-03-17 08:50:24 +01:00
2023-02-22 12:59:52 +01:00
2022-12-31 13:32:29 +01:00
2022-08-25 10:33:21 +02:00
2023-01-24 07:24:31 +01:00
2022-12-31 13:32:22 +01:00
2022-10-07 09:29:17 +02:00
2023-03-17 08:50:25 +01:00
2023-03-17 08:50:25 +01:00
2022-06-10 16:21:27 -07:00
2022-11-15 12:42:26 +01:00
2022-11-22 07:14:55 +01:00
2023-03-10 09:33:07 +01:00
2023-03-10 09:33:05 +01:00
2022-12-05 09:53:08 +01:00
2023-02-06 08:06:34 +01:00
2023-02-22 12:59:53 +01:00
2023-02-22 12:59:40 +01:00
2022-08-29 12:47:15 +01:00
2023-03-17 08:50:27 +01:00
2022-08-29 12:47:15 +01:00
2023-02-01 08:34:45 +01:00
2023-02-09 11:28:06 +01:00
2023-03-17 08:50:17 +01:00
2023-02-22 12:59:52 +01:00
2022-11-29 08:30:18 -08:00
2022-08-29 12:47:15 +01:00
2023-02-09 11:28:15 +01:00
2023-03-10 09:33:02 +01:00
2023-02-22 12:59:42 +01:00
2022-12-31 13:32:55 +01:00
2023-03-11 13:55:28 +01:00
2023-03-11 13:55:26 +01:00
2023-03-17 08:50:28 +01:00
2022-07-08 18:38:44 -07:00
2023-03-17 08:50:28 +01:00
2023-02-22 12:59:53 +01:00
2023-03-17 08:50:26 +01:00
2023-03-17 08:50:28 +01:00
2022-12-31 13:32:26 +01:00
2023-03-13 10:21:31 +01:00
2023-02-09 11:28:13 +01:00
2023-03-10 09:33:06 +01:00
2023-03-03 11:52:20 +01:00
2023-02-09 11:28:04 +01:00
2022-08-22 14:26:30 +01:00
2022-09-20 14:23:56 -07:00
2022-08-22 14:26:30 +01:00
2023-03-10 09:34:34 +01:00
ac1968ac39