iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/mm
History
Naoya Horiguchi 47e2fe17d1 mm, hugetlb: use pte_present() instead of pmd_present() in follow_huge_pmd() 
commit c9d398fa237882ea07167e23bcfc5e6847066518 upstream.

I found the race condition which triggers the following bug when
move_pages() and soft offline are called on a single hugetlb page
concurrently.

    Soft offlining page 0x119400 at 0x700000000000
    BUG: unable to handle kernel paging request at ffffea0011943820
    IP: follow_huge_pmd+0x143/0x190
    PGD 7ffd2067
    PUD 7ffd1067
    PMD 0
        [61163.582052] Oops: 0000 [#1] SMP
    Modules linked in: binfmt_misc ppdev virtio_balloon parport_pc pcspkr i2c_piix4 parport i2c_core acpi_cpufreq ip_tables xfs libcrc32c ata_generic pata_acpi virtio_blk 8139too crc32c_intel ata_piix serio_raw libata virtio_pci 8139cp virtio_ring virtio mii floppy dm_mirror dm_region_hash dm_log dm_mod [last unloaded: cap_check]
    CPU: 0 PID: 22573 Comm: iterate_numa_mo Tainted: P           OE   4.11.0-rc2-mm1+ #2
    Hardware name: Red Hat KVM, BIOS 0.5.1 01/01/2011
    RIP: 0010:follow_huge_pmd+0x143/0x190
    RSP: 0018:ffffc90004bdbcd0 EFLAGS: 00010202
    RAX: 0000000465003e80 RBX: ffffea0004e34d30 RCX: 00003ffffffff000
    RDX: 0000000011943800 RSI: 0000000000080001 RDI: 0000000465003e80
    RBP: ffffc90004bdbd18 R08: 0000000000000000 R09: ffff880138d34000
    R10: ffffea0004650000 R11: 0000000000c363b0 R12: ffffea0011943800
    R13: ffff8801b8d34000 R14: ffffea0000000000 R15: 000077ff80000000
    FS:  00007fc977710740(0000) GS:ffff88007dc00000(0000) knlGS:0000000000000000
    CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
    CR2: ffffea0011943820 CR3: 000000007a746000 CR4: 00000000001406f0
    Call Trace:
     follow_page_mask+0x270/0x550
     SYSC_move_pages+0x4ea/0x8f0
     SyS_move_pages+0xe/0x10
     do_syscall_64+0x67/0x180
     entry_SYSCALL64_slow_path+0x25/0x25
    RIP: 0033:0x7fc976e03949
    RSP: 002b:00007ffe72221d88 EFLAGS: 00000246 ORIG_RAX: 0000000000000117
    RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fc976e03949
    RDX: 0000000000c22390 RSI: 0000000000001400 RDI: 0000000000005827
    RBP: 00007ffe72221e00 R08: 0000000000c2c3a0 R09: 0000000000000004
    R10: 0000000000c363b0 R11: 0000000000000246 R12: 0000000000400650
    R13: 00007ffe72221ee0 R14: 0000000000000000 R15: 0000000000000000
    Code: 81 e4 ff ff 1f 00 48 21 c2 49 c1 ec 0c 48 c1 ea 0c 4c 01 e2 49 bc 00 00 00 00 00 ea ff ff 48 c1 e2 06 49 01 d4 f6 45 bc 04 74 90 <49> 8b 7c 24 20 40 f6 c7 01 75 2b 4c 89 e7 8b 47 1c 85 c0 7e 2a
    RIP: follow_huge_pmd+0x143/0x190 RSP: ffffc90004bdbcd0
    CR2: ffffea0011943820
    ---[ end trace e4f81353a2d23232 ]---
    Kernel panic - not syncing: Fatal exception
    Kernel Offset: disabled

This bug is triggered when pmd_present() returns true for non-present
hugetlb, so fixing the present check in follow_huge_pmd() prevents it.
Using pmd_present() to determine present/non-present for hugetlb is not
correct, because pmd_present() checks multiple bits (not only
_PAGE_PRESENT) for historical reason and it can misjudge hugetlb state.

Fixes: e66f17ff7177 ("mm/hugetlb: take page table lock in follow_huge_pmd()")
Link: http://lkml.kernel.org/r/1490149898-20231-1-git-send-email-n-horiguchi@ah.jp.nec.com
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Acked-by: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-04-08 09:53:32 +02:00
..
kasan
kasan: update kasan_global for gcc 7
2016-12-08 07:15:24 +01:00
backing-dev.c
block: fix double-free in the failure path of cgwb_bdi_init()
2017-02-26 11:07:51 +01:00
balloon_compaction.c
virtio_balloon: fix race between migration and ballooning
2016-03-03 15:07:18 -08:00
bootmem.c
bootmem: avoid freeing to bootmem after bootmem is done
2015-09-08 15:35:28 -07:00
cleancache.c
cleancache: remove limit on the number of cleancache enabled filesystems
2015-04-14 16:49:03 -07:00
cma_debug.c
mm/cma_debug: correct size input to bitmap function
2015-07-17 16:39:54 -07:00
cma.c
mm/cma: silence warnings due to max() usage
2016-11-10 16:36:36 +01:00
cma.h
mm: cma: mark cma_bitmap_maxno() inline in header
2015-08-14 15:56:32 -07:00
compaction.c
mm, compaction: prevent VM_BUG_ON when terminating freeing scanner
2016-08-10 11:49:25 +02:00
debug-pagealloc.c
mm/debug-pagealloc: make debug-pagealloc boottime configurable
2014-12-13 12:42:48 -08:00
debug.c
mm: make compound_head() robust
2015-11-06 17:50:42 -08:00
dmapool.c
mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd
2015-11-06 17:50:42 -08:00
early_ioremap.c
mm/early_ioremap: use offset_in_page macro
2015-11-05 19:34:48 -08:00
fadvise.c
writeback: implement and use inode_congested()
2015-06-02 08:33:35 -06:00
failslab.c
mm, page_alloc: rename __GFP_WAIT to __GFP_RECLAIM
2015-11-06 17:50:42 -08:00
filemap.c
mm: do not access page->mapping directly on page_endio
2017-03-12 06:37:25 +01:00
frame_vector.c
mm: fix docbook comment for get_vaddr_frames()
2015-11-05 19:34:48 -08:00
frontswap.c
frontswap: allow multiple backends
2015-06-24 17:49:45 -07:00
gup.c
mm: remove gup_flags FOLL_WRITE games from __get_user_pages()
2016-10-20 10:00:47 +02:00
highmem.c
mm/highmem: make kmap cache coloring aware
2014-08-06 18:01:22 -07:00
huge_memory.c
mm/huge_memory: replace VM_NO_THP VM_BUG_ON with actual VMA check
2016-05-04 14:48:49 -07:00
hugetlb_cgroup.c
mm: make compound_head() robust
2015-11-06 17:50:42 -08:00
hugetlb.c
mm, hugetlb: use pte_present() instead of pmd_present() in follow_huge_pmd()
2017-04-08 09:53:32 +02:00
hwpoison-inject.c
hwpoison: use page_cgroup_ino for filtering by memcg
2015-09-10 13:29:01 -07:00
init-mm.c
mm: Add a user_ns owner to mm_struct and fix ptrace permission checks
2017-01-06 11:16:11 +01:00
internal.h
mm, sl[au]b: add __GFP_ATOMIC to the GFP reclaim mask
2016-08-10 11:49:25 +02:00
interval_tree.c
mm: replace vma->sharead.linear with vma->shared
2015-02-10 14:30:31 -08:00
Kconfig
mm: make compound_head() robust
2015-11-06 17:50:42 -08:00
Kconfig.debug
mm/debug_pagealloc: remove obsolete Kconfig options
2015-01-08 15:10:52 -08:00
kmemcheck.c
mm/slab_common: move kmem_cache definition to internal header
2014-10-09 22:25:50 -04:00
kmemleak-test.c
mm/kmemleak-test.c: use pr_fmt for logging
2014-06-06 16:08:18 -07:00
kmemleak.c
mm/kmemleak.c: remove unneeded initialization of object to NULL
2015-11-05 19:34:48 -08:00
ksm.c
mm,ksm: fix endless looping in allocating memory when ksm enable
2016-10-07 15:23:40 +02:00
list_lru.c
mm/list_lru.c: avoid error-path NULL pointer deref
2016-11-10 16:36:32 +01:00
maccess.c
mm/maccess.c: actually return -EFAULT from strncpy_from_unsafe
2015-11-05 19:34:48 -08:00
madvise.c
mm: madvise allow remove operation for hugetlbfs
2015-09-08 15:35:28 -07:00
Makefile
media updates for v4.3-rc1
2015-09-11 16:42:39 -07:00
memblock.c
mm/memblock: make memblock_remove_range() static
2015-11-05 19:34:48 -08:00
memcontrol.c
mm: memcontrol: avoid unused function warning
2017-03-18 19:09:57 +08:00
memory_hotplug.c
base/memory, hotplug: fix a kernel oops in show_valid_zones()
2017-02-09 08:02:47 +01:00
memory-failure.c
mm: soft-offline: check return value in second __get_any_page() call
2016-02-25 12:01:21 -08:00
memory.c
numa: fix /proc/<pid>/numa_maps for THP
2016-05-04 14:48:49 -07:00
mempolicy.c
mm/mempolicy.c: do not put mempolicy before using its nodemask
2017-02-01 08:30:52 +01:00
mempool.c
mm, page_alloc: distinguish between being unable to sleep, unwilling to sleep and avoiding waking kswapd
2015-11-06 17:50:42 -08:00
memtest.c
memtest: remove unused header files
2015-09-08 15:35:28 -07:00
migrate.c
mm: Export migrate_page_move_mapping and migrate_page_copy
2016-07-27 09:47:31 -07:00
mincore.c
mm/mincore: use offset_in_page macro
2015-11-05 19:34:48 -08:00
mlock.c
mm: fix mlock accouting
2016-02-25 12:01:21 -08:00
mm_init.c
mm: meminit: remove mminit_verify_page_links
2015-06-30 19:44:56 -07:00
mmap.c
mm: fix regression in remap_file_pages() emulation
2016-02-25 12:01:21 -08:00
mmu_context.c
…
mmu_notifier.c
mmu-notifier: add clear_young callback
2015-09-10 13:29:01 -07:00
mmzone.c
mm: microoptimize zonelist operations
2015-02-11 17:06:02 -08:00
mprotect.c
userfaultfd: teach vma_merge to merge across vma->vm_userfaultfd_ctx
2015-09-04 16:54:41 -07:00
mremap.c
mm/mremap: use offset_in_page macro
2015-11-05 19:34:48 -08:00
msync.c
mm/msync: use offset_in_page macro
2015-11-05 19:34:48 -08:00
nobootmem.c
mm: page_alloc: pass PFN to __free_pages_bootmem
2015-06-30 19:44:55 -07:00
nommu.c
mm/nommu.c: drop unlikely inside BUG_ON()
2015-11-05 19:34:48 -08:00
oom_kill.c
mm/oom_kill.c: avoid attempting to kill init sharing same memory
2015-12-12 10:15:34 -08:00
page_alloc.c
mm/page_alloc: fix nodes for reclaim in fast path
2017-03-12 06:37:25 +01:00
page_counter.c
mm: page_counter: let page_counter_try_charge() return bool
2015-11-05 19:34:48 -08:00
page_ext.c
mm: introduce idle page tracking
2015-09-10 13:29:01 -07:00
page_idle.c
mm: introduce idle page tracking
2015-09-10 13:29:01 -07:00
page_io.c
fs: use helper bio_add_page() instead of open coding on bi_io_vec
2015-08-13 12:32:00 -06:00
page_isolation.c
mm: fix invalid node in alloc_migrate_target()
2016-04-20 15:41:53 +09:00
page_owner.c
mm/page_owner: set correct gfp_mask on page_owner
2015-07-17 16:39:54 -07:00
page-writeback.c
writeback: use higher precision calculation in domain_dirty_limits()
2016-07-27 09:47:29 -07:00
pagewalk.c
mm/pagewalk.c: prevent positive return value of walk_page_test() from being passed to callers
2015-03-25 16:20:30 -07:00
percpu-km.c
percpu: implmeent pcpu_nr_empty_pop_pages and chunk->nr_populated
2014-09-02 14:46:05 -04:00
percpu-vm.c
percpu: move region iterations out of pcpu_[de]populate_chunk()
2014-09-02 14:46:02 -04:00
percpu.c
percpu: acquire pcpu_lock when updating pcpu_nr_empty_pop_pages
2017-03-26 12:13:20 +02:00
pgtable-generic.c
mm,thp: khugepaged: call pte flush at the time of collapse
2016-02-25 12:01:23 -08:00
process_vm_access.c
ptrace: use fsuid, fsgid, effective creds for fs access checks
2016-02-25 12:01:16 -08:00
quicklist.c
…
readahead.c
mm, fs: introduce mapping_gfp_constraint()
2015-11-06 17:50:42 -08:00
rmap.c
mm: page migration use migration entry for swapcache too
2015-11-05 19:34:48 -08:00
shmem.c
tmpfs: fix regression hang in fallocate undo
2016-07-27 09:47:40 -07:00
slab_common.c
mm: memcontrol: fix cgroup creation failure after many small jobs
2016-08-16 09:30:51 +02:00
slab.c
slab/slub: adjust kmem_cache_alloc_bulk API
2015-11-22 11:58:44 -08:00
slab.h
slab/slub: adjust kmem_cache_alloc_bulk API
2015-11-22 11:58:44 -08:00
slob.c
slab/slub: adjust kmem_cache_alloc_bulk API
2015-11-22 11:58:44 -08:00
slub.c
slub: clean up code for kmem cgroup support to kmem_cache_free_bulk
2016-05-04 14:48:49 -07:00
sparse-vmemmap.c
…
sparse.c
…
swap_cgroup.c
mm: page_cgroup: rename file to mm/swap_cgroup.c
2014-12-10 17:41:09 -08:00
swap_state.c
mm: swap: zswap: maybe_preload & refactoring
2015-09-08 15:35:28 -07:00
swap.c
mm: make compound_head() robust
2015-11-06 17:50:42 -08:00
swapfile.c
swapfile: fix memory corruption via malformed swapfile
2016-11-18 10:48:34 +01:00
truncate.c
memcg: add per cgroup dirty page accounting
2015-06-02 08:33:33 -06:00
userfaultfd.c
userfaultfd: avoid mmap_sem read recursion in mcopy_atomic
2015-09-04 16:54:41 -07:00
util.c
proc: revert /proc/<pid>/maps [stack:TID] annotation
2016-09-15 08:27:46 +02:00
vmacache.c
mm/vmacache: inline vmacache_valid_mm()
2015-11-05 19:34:48 -08:00
vmalloc.c
mm: vmalloc: don't remove inexistent guard hole in remove_vm_area()
2015-11-20 16:17:32 -08:00
vmpressure.c
mm: vmpressure: fix sending wrong events on underflow
2017-03-12 06:37:25 +01:00
vmscan.c
mm/vmscan.c: set correct defer count for shrinker
2017-01-06 11:16:14 +01:00
vmstat.c
vmstat: allocate vmstat_wq before it is used
2016-01-08 23:47:54 -08:00
workingset.c
mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page()
2016-10-28 03:01:34 -04:00
zbud.c
mm: zsmalloc: constify struct zs_pool name
2015-11-06 17:50:42 -08:00
zpool.c
mm: zsmalloc: constify struct zs_pool name
2015-11-06 17:50:42 -08:00
zsmalloc.c
zsmalloc: fix zs_can_compact() integer overflow
2016-05-18 17:06:44 -07:00
zswap.c
zswap: disable changing params if init fails
2017-02-09 08:02:45 +01:00