Ming Lei 69e9b2858b block: deactivate blk_stat timer in wbt_disable_default() ...

commit 544fbd16a461a318cd80537d1331c0df5c6cf930 upstream.

rwb_enabled() can't be changed when there is any inflight IO.

wbt_disable_default() may set rwb->wb_normal as zero, however the
blk_stat timer may still be pending, and the timer function will update
wrb->wb_normal again.

This patch introduces blk_stat_deactivate() and applies it in
wbt_disable_default(), then the following IO hang triggered when running
parted & switching io scheduler can be fixed:

[  369.937806] INFO: task parted:3645 blocked for more than 120 seconds.
[  369.938941]       Not tainted 4.20.0-rc6-00284-g906c801e5248 #498
[  369.939797] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
[  369.940768] parted          D    0  3645   3239 0x00000000
[  369.941500] Call Trace:
[  369.941874]  ? __schedule+0x6d9/0x74c
[  369.942392]  ? wbt_done+0x5e/0x5e
[  369.942864]  ? wbt_cleanup_cb+0x16/0x16
[  369.943404]  ? wbt_done+0x5e/0x5e
[  369.943874]  schedule+0x67/0x78
[  369.944298]  io_schedule+0x12/0x33
[  369.944771]  rq_qos_wait+0xb5/0x119
[  369.945193]  ? karma_partition+0x1c2/0x1c2
[  369.945691]  ? wbt_cleanup_cb+0x16/0x16
[  369.946151]  wbt_wait+0x85/0xb6
[  369.946540]  __rq_qos_throttle+0x23/0x2f
[  369.947014]  blk_mq_make_request+0xe6/0x40a
[  369.947518]  generic_make_request+0x192/0x2fe
[  369.948042]  ? submit_bio+0x103/0x11f
[  369.948486]  ? __radix_tree_lookup+0x35/0xb5
[  369.949011]  submit_bio+0x103/0x11f
[  369.949436]  ? blkg_lookup_slowpath+0x25/0x44
[  369.949962]  submit_bio_wait+0x53/0x7f
[  369.950469]  blkdev_issue_flush+0x8a/0xae
[  369.951032]  blkdev_fsync+0x2f/0x3a
[  369.951502]  do_fsync+0x2e/0x47
[  369.951887]  __x64_sys_fsync+0x10/0x13
[  369.952374]  do_syscall_64+0x89/0x149
[  369.952819]  entry_SYSCALL_64_after_hwframe+0x49/0xbe
[  369.953492] RIP: 0033:0x7f95a1e729d4
[  369.953996] Code: Bad RIP value.
[  369.954456] RSP: 002b:00007ffdb570dd48 EFLAGS: 00000246 ORIG_RAX: 000000000000004a
[  369.955506] RAX: ffffffffffffffda RBX: 000055c2139c6be0 RCX: 00007f95a1e729d4
[  369.956389] RDX: 0000000000000001 RSI: 0000000000001261 RDI: 0000000000000004
[  369.957325] RBP: 0000000000000002 R08: 0000000000000000 R09: 000055c2139c6ce0
[  369.958199] R10: 0000000000000000 R11: 0000000000000246 R12: 000055c2139c0380
[  369.959143] R13: 0000000000000004 R14: 0000000000000100 R15: 0000000000000008

Cc: stable@vger.kernel.org
Cc: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2019-01-13 09:51:06 +01:00

..

partitions

partitions/aix: append null character to print data from disk

2018-07-27 09:17:41 -06:00

badblocks.c

badblocks: fix wrong return value in badblocks_set if badblocks are disabled

2017-11-03 11:29:50 -07:00

bfq-cgroup.c

block: bfq: swap puts in bfqg_and_blkg_put

2018-09-06 11:32:58 -06:00

bfq-iosched.c

block, bfq: reduce write overcharge

2018-08-16 13:08:13 -06:00

bfq-iosched.h

block, bfq: add/remove entity weights correctly

2018-07-09 09:07:52 -06:00

bfq-wf2q.c

block, bfq: correctly charge and reset entity service in all cases

2018-11-13 11:08:28 -08:00

bio-integrity.c

block: move bio_integrity_{intervals,bytes} into blkdev.h

2018-07-26 15:49:41 -06:00

bio.c

block/bio: Do not zero user pages

2018-12-19 19:19:50 +01:00

blk-cgroup.c

blk-cgroup: increase number of supported policies

2018-09-11 10:59:53 -06:00

blk-core.c

SCSI: fix queue cleanup race before queue initialization is done

2018-11-21 09:19:18 +01:00

blk-exec.c

blk-mq-sched: remove unused 'can_block' arg from blk_mq_sched_insert_request

2018-01-17 09:49:21 -07:00

blk-flush.c

block: fix use-after-free in block flush handling

2018-06-09 06:37:14 -06:00

blk-integrity.c

block drivers/block: Use octal not symbolic permissions

2018-05-24 13:38:59 -06:00

blk-ioc.c

block, mm: remove unnecessary __GFP_HIGH flag

2018-07-09 09:07:54 -06:00

blk-iolatency.c

block: make iolatency avg_lat exponentially decay

2018-08-02 09:58:14 -06:00

blk-lib.c

block: make sure writesame bio is aligned with logical block size

2018-11-13 11:08:16 -08:00

blk-map.c

Merge branch 'for-4.16/block' of git://git.kernel.dk/linux-block

2018-01-29 11:51:49 -08:00

blk-merge.c

block: make sure discard bio is aligned with logical block size

2018-11-13 11:08:16 -08:00

blk-mq-cpumap.c

blk-mq: don't keep offline CPUs mapped to hctx 0

2018-04-10 08:38:46 -06:00

blk-mq-debugfs-zoned.c

block: Make struct request_queue smaller for CONFIG_BLK_DEV_ZONED=n

2018-07-09 09:07:52 -06:00

blk-mq-debugfs.c

blk-mq: dequeue request one by one from sw queue if hctx is busy

2018-07-09 09:07:53 -06:00

blk-mq-debugfs.h

block: Make struct request_queue smaller for CONFIG_BLK_DEV_ZONED=n

2018-07-09 09:07:52 -06:00

blk-mq-pci.c

blk-mq: code clean-up by adding an API to clear set->mq_map

2018-07-09 09:07:53 -06:00

blk-mq-rdma.c

block: Add rdma affinity based queue mapping helper

2017-08-08 14:58:03 -04:00

blk-mq-sched.c

blk-mq: init hctx sched after update ctx and hctx mapping

2018-08-21 09:02:55 -06:00

blk-mq-sched.h

blk-mq: init hctx sched after update ctx and hctx mapping

2018-08-21 09:02:55 -06:00

blk-mq-sysfs.c

block drivers/block: Use octal not symbolic permissions

2018-05-24 13:38:59 -06:00

blk-mq-tag.c

blk-mq: Allow blocking queue tag iter callbacks

2018-09-25 20:17:59 -06:00

blk-mq-tag.h

Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block

2017-11-14 15:32:19 -08:00

blk-mq-virtio.c

blk-mq: provide a default queue mapping for virtio device

2017-02-27 20:54:05 +02:00

blk-mq.c

blk-mq: punt failed direct issue to dispatch list

2018-12-08 12:59:10 +01:00

blk-mq.h

blk-mq: issue directly if hw queue isn't busy in case of 'none'

2018-07-17 16:04:00 -06:00

blk-rq-qos.c

blk-rq-qos: make depth comparisons unsigned

2018-07-22 11:30:53 -06:00

blk-rq-qos.h

blk-rq-qos: make depth comparisons unsigned

2018-07-22 11:30:53 -06:00

blk-settings.c

block: allow max_discard_segments to be stacked

2018-07-24 14:46:39 -06:00

blk-softirq.c

block: fix timeout changes for legacy request drivers

2018-06-19 11:27:18 -06:00

blk-stat.c

blk-stat: export helpers for modifying blk_rq_stat

2018-07-09 09:07:54 -06:00

blk-stat.h

block: deactivate blk_stat timer in wbt_disable_default()

2019-01-13 09:51:06 +01:00

blk-sysfs.c

blk-wbt: don't maintain inflight counts if disabled

2018-08-23 09:34:46 -06:00

blk-tag.c

for-linus-20180616

2018-06-17 05:37:55 +09:00

blk-throttle.c

blkcg: use tryget logic when associating a blkg with a bio

2018-08-31 14:48:58 -06:00

blk-timeout.c

blk-mq: Fix timeout handling in case the timeout handler returns BLK_EH_DONE

2018-06-23 10:25:45 -06:00

blk-wbt.c

block: deactivate blk_stat timer in wbt_disable_default()

2019-01-13 09:51:06 +01:00

blk-wbt.h

block: remove external dependency on wbt_flags

2018-07-09 09:07:54 -06:00

blk-zoned.c

block: Remove a superfluous cast from blkdev_report_zones()

2018-07-09 09:07:52 -06:00

blk.h

block: make sure discard bio is aligned with logical block size

2018-11-13 11:08:16 -08:00

bounce.c

block: copy ioprio in __bio_clone_fast() and bounce

2018-12-01 09:37:32 +01:00

bsg-lib.c

block/bsg-lib: use PTR_ERR_OR_ZERO to simplify the flow path

2018-08-01 09:13:03 -06:00

bsg.c

block: bsg: move atomic_t ref_count variable to refcount API

2018-08-27 19:17:02 -06:00

cfq-iosched.c

cfq: Suppress compiler warnings about comparisons

2018-08-07 17:57:13 -06:00

cmdline-parser.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

compat_ioctl.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

deadline-iosched.c

block drivers/block: Use octal not symbolic permissions

2018-05-24 13:38:59 -06:00

elevator.c

block: fix deadline elevator drain for zoned block devices

2018-09-26 19:57:24 -06:00

genhd.c

block: use nanosecond resolution for iostat

2018-09-21 20:26:59 -06:00

ioctl.c

block: pass inclusive 'lend' parameter to truncate_inode_pages_range

2018-02-23 15:20:19 -07:00

ioprio.c

block: add ioprio_check_cap function

2018-05-31 10:50:54 -04:00

Kconfig

block: introduce blk-iolatency io controller

2018-07-09 09:07:54 -06:00

Kconfig.iosched

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

kyber-iosched.c

block: kyber: make kyber more friendly with merging

2018-05-30 10:47:40 -06:00

Makefile

block: introduce blk-iolatency io controller

2018-07-09 09:07:54 -06:00

mq-deadline.c

block drivers/block: Use octal not symbolic permissions

2018-05-24 13:38:59 -06:00

noop-iosched.c

block: move existing elevator ops to union

2017-01-17 10:03:33 -07:00

opal_proto.h

block: sed-opal: Set MBRDone on S3 resume path if TPER is MBREnabled

2017-09-11 09:45:52 -06:00

partition-generic.c

block: use nanosecond resolution for iostat

2018-09-21 20:26:59 -06:00

scsi_ioctl.c

block: consistently use GFP_NOIO instead of __GFP_NORECLAIM

2018-05-14 08:55:18 -06:00

sed-opal.c

block: sed-opal: Fix a couple off by one bugs

2018-06-20 12:04:06 -06:00

t10-pi.c

block: move dif_prepare/dif_complete functions to block layer

2018-07-30 08:27:02 -06:00